Idea to sort a list and get a result

[Aditya Sirohi]

Hola Friends,

I have a question i have an output from a method like below:-

CINSTALLDIR CM
CINSTALLDIR CT
CINSTALLDIR PJ
CINSTALLDIR RM
CINSTALLDIR RX
CINSTALLDIR SV
CINSTALLDIR TM

I am trying to write a method that take the above as input and generates this:-

CINSTALLDIR CM CT PJ RM RX SV TM

If i try to put them into an array, i think i will be difficult, should i try using Hash Map. Any other data structure you suggest?

Thanks
Aditya

[Paul Clapham]

Take the first entry from the first column and follow it by all entries from the second column. You don't need any collections at all.

[Aditya Sirohi]

The input are in an array. So i wrote the code like this as below. Does not work!!

-Aditya

public class StringSplit {
          
	public static void main(String[] args){
		String[] test = {"wCINSTALLDIR CM", "CINSTALLDIR CT", "CINSTALLDIR PJ", "CINSTALLDIR RM", "CINSTALLDIR SX"
				         ,"CINSTALLDIR SV", "CINSTALLDIR TM"};
		
		
	    
		for(int i=0;i<test.length;i++){
			  String j = test[i];
			 String[] Regex = j.split(" ");
			System.out.println(Regex[0]+ " " +Regex[1]);
		}
	}
}

[Henry Wong]

Aditya Sirohi wrote:The input are in an array. So i wrote the code like this as below. Does not work!!

So, fix it. It looks pretty close. Change a println() to a print(). Add a condition on the prints. etc. And you'll be done.

Henry

[Aditya Sirohi]

Thanks Henry,

I am working on the idea you gave me. I never know print() works this way. This was a good exposure.

Thanks
Aditya

[Campbell Ritchie]

But don't call the String[] Regex. That will confuse anybody who reads your code quickly.

[Aditya Sirohi]

Not able to do it, still trying

[Aditya Sirohi]

Hello Cambell,

I use String[] Regex because that contains Split strings that are in test array. So then i have two fields.

Thanks
Aditya

[Aditya Sirohi]

Idea struck and i got it

[Campbell Ritchie]

But calling your String[] Regex tells the unwary reader two things

It contains a regular expression

It is the name of a class

And both are incorrect.

[fred rosenberger]

Campbell Ritchie wrote:But calling your String[] Regex tells the unwary reader two things

It contains a regular expression

It is the name of a class

And both are incorrect.

To expand on Campbell's point...

Traditionally, in Java, class names start with a capital letter, and variable start with a lower-case letter. Many people seeing "Regex" (note the capital 'R') would think this was a class name.

Second, the word 'regex' is a commonly used term for a 'regular expression'. If i was reading your code and saw a variable named that, I would expect it to contain a regular expression. If I saw it was an array of strings, I'd expect each element to contain a regular expression.

Your array contains the tokens after splitting up a string based on a single character. You don't even use a regex anywhere that I see.

A better name for the variable would be something like "tokens" or "myTokens" or something along those lines. The variable should be named for what it CONTAINS, not how you got the data you stick in it.

[Campbell Ritchie]

Maybe you were following the naming conventions in this article, which you should read when you have enough time