file upload works on windows, doesn't on unix

[eddy johns]

Hi everyone,

I have a standard file upload code that works with no issues on windows (both xp and 7) running on tomcat and called from a jsp page. But it throws an IndexOutOfBoundsException when running on a unix machine. I'm copying the code below. Any idea? Just to get one possible issue out of the way, the path is correct and the image file is written to the directory it should be written to, but with 0 bytes.

Thanks! I'll really appreciate any help with this.

The stack trace:
java.lang.IndexOutOfBoundsException
at java.io.FileOutputStream.writeBytes(Native Method)
at java.io.FileOutputStream.write(FileOutputStream.java:260)
at FileUpload.uploadFile(FileUpload.java:70)
at org.apache.jsp.il_005fIL.upload_jsp._jspService(upload_jsp.java:75)
at org.apache.jasper.runtime.HttpJspBase.service(HttpJspBase.java:98)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:803)
at org.apache.jasper.servlet.JspServletWrapper.service(JspServletWrapper.java:331)
at org.apache.jasper.servlet.JspServlet.serviceJspFile(JspServlet.java:329)
at org.apache.jasper.servlet.JspServlet.service(JspServlet.java:265)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:803)
at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:269)
at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:188)
at com.village.common.action.SearchFilter.doFilter(SearchFilter.java:32)
at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:215)
at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:188)
at com.opensymphony.oscache.web.filter.CacheFilter.doFilter(CacheFilter.java:175)
at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:215)
at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:188)
at org.tuckey.web.filters.urlrewrite.UrlRewriteFilter.doFilter(UrlRewriteFilter.java:738)
at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:215)
at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:188)
at org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:213)
at org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:174)
at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:127)
at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:117)
at org.apache.catalina.valves.FastCommonAccessLogValve.invoke(FastCommonAccessLogValve.java:482)
at org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:108)
at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:174)
at org.apache.jk.server.JkCoyoteHandler.invoke(JkCoyoteHandler.java:200)
at org.apache.jk.common.HandlerRequest.invoke(HandlerRequest.java:283)
at org.apache.jk.common.ChannelSocket.invoke(ChannelSocket.java:773)
at org.apache.jk.common.ChannelSocket.processConnection(ChannelSocket.java:703)
at org.apache.jk.common.ChannelSocket$SocketConnection.runIt(ChannelSocket.java:895)
at org.apache.tomcat.util.threads.ThreadPool$ControlRunnable.run(ThreadPool.java:689)
at java.lang.Thread.run(Thread.java:595)



The code:

import java.io.*;
import javax.servlet.http.HttpServletRequest; 

public class FileUpload {
	
	
	public FileUpload() {
		
	}
	
	public String uploadFile(HttpServletRequest request, String serverPath) {
		
		String fileName = "";
		
		String contentType = request.getContentType();
	
		if ((contentType != null) && (contentType.indexOf("multipart/form-data") >= 0)) {
			
			
			try {
		 		DataInputStream in = new DataInputStream(request.getInputStream());
				//we are taking the length of Content type data
				int formDataLength = request.getContentLength();
				byte dataBytes[] = new byte[formDataLength];
				int byteRead = 0;
				int totalBytesRead = 0;

				//this loop converts the uploaded file into byte code
				while (totalBytesRead < formDataLength) {
					byteRead = in.read(dataBytes, totalBytesRead, formDataLength);
					totalBytesRead += byteRead;
				}

				String file = new String(dataBytes);
				System.out.println("FileUPload. dataBytes.length = " + file.getBytes().length);


				//for saving the file name
				fileName = file.substring(file.indexOf("filename=\"") + 10);
				fileName = fileName.substring(0, fileName.indexOf("\n"));
				fileName = fileName.substring(fileName.lastIndexOf("\\") + 1,fileName.indexOf("\""));
				int lastIndex = contentType.lastIndexOf("=");
				String boundary = contentType.substring(lastIndex + 1, contentType.length());

				int pos;
				//extracting the index of file 
				pos = file.indexOf("filename=\"");
				pos = file.indexOf("\n", pos) + 1;
				pos = file.indexOf("\n", pos) + 1;
				pos = file.indexOf("\n", pos) + 1;
				int boundaryLocation = file.indexOf(boundary, pos) - 4;
				int startPos = ((file.substring(0, pos)).getBytes()).length;
				int endPos = ((file.substring(0, boundaryLocation)).getBytes()).length;

				
				System.out.println("FileUpload: length = " + dataBytes.length + ", startPos = " + startPos + 
						", endPos - startPos = " + (endPos - startPos));
				
				FileOutputStream fileToFileSystem = new FileOutputStream(serverPath + fileName);  
				fileToFileSystem.write(dataBytes, startPos, (endPos - startPos));  

				
				fileToFileSystem.flush();  
				fileToFileSystem.close();  
				
			} 
			catch (Exception e) {
				e.printStackTrace();
			}
		
		}
		
		System.out.println("FileUplad. fileName = " + fileName);
		return fileName;
	}
	
}

[Rob Spoor]

Please UseCodeTags. You can use the edit button to change your post and add them. Also, please TellTheDetails. What's the exact stack trace?

[choong wing cheong]

Hi,

Do you have the solution? I also facing the same problem as you, which is running in window but not in linux. Looking for your feedback. Thanks

[Lorand Komaromi]

Don't hardcode the path separators, use File.separator instead of \\!

[eddy johns]

Here's the code from my jsp page. Note that I don't have a gui and this is just the server side, but your form should connect with this with no problem. The full code is on the web somewhere but I can't find it this morning. Also, you will need to add the commons fileupload jar to your build path. You can find the latest here: http://commons.apache.org/fileupload/download_fileupload.cgi. Good luck!

<%@ page import="org.apache.commons.fileupload.DiskFileUpload"%>
<%@ page import="org.apache.commons.fileupload.FileItem"%>
<%@ page import="java.util.List"%>
<%@ page import="java.util.Iterator"%>
<%@ page import="java.io.File"%>

<%
final String SERVER_PATH = "the path for where the file needs to go";
		
	boolean worked = true;
        String newName = request.getParameter("newName");

        try {
            DiskFileUpload fu = new DiskFileUpload();
            // If file size exceeds, a FileUploadException will be thrown
            fu.setSizeMax(100000000);
            List fileItems = fu.parseRequest(request);

            Iterator itr = fileItems.iterator();
            while(itr.hasNext()) {
                FileItem fi = (FileItem)itr.next();

                //Check if not form field so as to only handle the file inputs
                //else condition handles the submit button input
                if(!fi.isFormField()) {
          		String extension = fi.getName();
          		extension = extension.substring(extension.indexOf(".")+1);
                newName = newName + "." + extension;

                File fNew= new File(SERVER_PATH, newName);

                fi.write(fNew);
                }
              }
        } catch(Exception e) {
        	e.printStackTrace();
        	worked = false;
        }
        
        
%>

[choong wing cheong]

Hi eddy,

Thanks for your code. It is worked.