File upload problem

Hi everyone,

Can anyone please try to run the following code and see if it works? There's a FileUpload.html, calling a FileUpload.jsp, calling the FileUpload.java file and all of them do one simple thing: upload a file from the file system and write it to a location you specify. This is simple stuff and it works on my windows development machine but for some reason this code - or rather an identical one inside a larger application - fails on the client's deployment server (which is a unix machine.) It seems to read only two thirds of the image to the dataBytes array and then stops, and later in the code throws an IndexOutOfBounds exception. It writes the uploaded file to the correct path and with the correct name but with 0 bytes. This is baffling to me and I would really appreciate some help.

One possible reason that I can think of: the directory it needs to write to on the client's server is virtual, and running on a separate file server. Could this be the problem?

I apologize for posting this question a second time but I got no replies the first one and now I'm including all the relevant code. To run it you'll need to change the serverPath in the jsp file to a path on your machine.

Thank you very much for your help!
Eddy

Here are the files:

import java.io.*;
import javax.servlet.http.HttpServletRequest;

public class FileUpload {
	
	
	public FileUpload() {
		
	}
	
	public String uploadFile(HttpServletRequest request, String serverPath) {
		System.out.println("FileUpload. serverPath = " + serverPath);
		System.out.println("FileUpload. request = " + request.toString());
		
		String fileName = "--";
		
		String contentType = request.getContentType();
		System.out.println("FileUpload. contentType = " + contentType);
	
		if ((contentType != null) && (contentType.indexOf("multipart/form-data") >= 0)) {
			
			
			try {
		 		DataInputStream in = new DataInputStream(request.getInputStream());
				//we are taking the length of Content type data
				int formDataLength = request.getContentLength();
				byte dataBytes[] = new byte[formDataLength];
				int byteRead = 0;
				int totalBytesRead = 0;

//this loop converts the uploaded file into byte code
				try {
					while (totalBytesRead < formDataLength) {
						byteRead = in.read(dataBytes, totalBytesRead, formDataLength);
						System.out.println("FileUpload. byteRead = " + byteRead + ", dataBytes = " + dataBytes + ", totalBytesRead = " + totalBytesRead + 
								", formDataLength = " + formDataLength);
						totalBytesRead += byteRead;
					}					
				} catch (Exception ee) {
					System.out.println("FileUpload. try catch around while loop. The exception is " + ee.toString());
					ee.printStackTrace();
				}

String file = new String(dataBytes);
				System.out.println("FileUPload. dataBytes.length = " + file.getBytes().length);

//				System.out.println("the file = " + file);

//for saving the file name
				fileName = file.substring(file.indexOf("filename=\"") + 10);
				fileName = fileName.substring(0, fileName.indexOf("\n"));
				fileName = fileName.substring(fileName.lastIndexOf("\\") + 1,fileName.indexOf("\""));
				int lastIndex = contentType.lastIndexOf("=");
				String boundary = contentType.substring(lastIndex + 1, contentType.length());

int pos;
				//extracting the index of file 
				pos = file.indexOf("filename=\"");
				pos = file.indexOf("\n", pos) + 1;
				pos = file.indexOf("\n", pos) + 1;
				pos = file.indexOf("\n", pos) + 1;
				int boundaryLocation = file.indexOf(boundary, pos) - 4;
				int startPos = ((file.substring(0, pos)).getBytes()).length;
				int endPos = ((file.substring(0, boundaryLocation)).getBytes()).length;

// save the file to the location on the server
//				length: 94189 -> This Is the length dataBytes Array
//				Start: 285
//				End: 164274
				
				
				System.out.println("FileUpload: length = " + dataBytes.length + ", startPos = " + startPos + 
						", endPos - startPos = " + (endPos - startPos));
				
				FileOutputStream fileToFileSystem = new FileOutputStream(serverPath + fileName);  
				fileToFileSystem.write(dataBytes, startPos, (endPos - startPos));

//				fileToFileSystem.write(dataBytes, startPos, endPos);

fileToFileSystem.flush();  
				fileToFileSystem.close();  
				
			} 
			catch (Exception e) {
				e.printStackTrace();
			}
		
		}
		
		System.out.println("FileUplad. fileName = " + fileName);
		return fileName;
	}
	
}

Nothing to do with ORM; moving to servlets.

Why wouldn't you just use an existing library to do all the busywork, like commons-fileupload?

David is right -- no experienced web developer is going to re-invent the wheel. See the JSP FAQ for information on the available libraries.

I implemented the commons-fileupload and it works beautifully. Thank you very much, David and Bear!!

Glad you got it working--that's great!