submit button is not working

Hiiiiiii Freinds......I am a newcomer in the field of JSPs and Servlets.I am developing a web application and having a problem in forwarding control from one page to another page
welcome page of my application is index.jsp which is divided into three frames one frame is reserved for taking user input details i.e. username and password.after clicking upon submit button control should go to loginhandler.jsp after that a page welcome.jsp should open with welcome, ~~username~~ printed over it.
But i have a problem, upon clicking the submit button nothing is happening.What is the problem behind?please help me!
I am attaching code snippets with message.

Are you placing the Submit button inside a HTML <form> set? With the proper Action and Method values?

I recommend using Firefox with HttpFox plugin, it really helps see what is going on, which method you are using, paramtees, etc.

You aren't attaching any thing.

Don't attach anything, use code tags, and include the relevant configs/code.

i have written about attachments but havn't attached anything.oops

index.jsp

login.jsp

loginhandler.jsp

<%@ page contentType="text/html; charset=iso-8859-1" language="java" import="java.sql.*, java.io.*, java.util.*, java.text.*"

errorPage="" %>
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">

<% 
[b][size=18][color=red]/*code for database connectivity*/[/color][/size] [/b]
try
{                                                                                                                                                             
ResultSet rs;
Class.forName("oracle.jdbc.driver.OracleDriver");
    Connection con = DriverManager.getConnection("jdbc:oracle:thin:@localhost:1521:xe","system","ankit");
   	Statement stmt = con.createStatement();
   	String query = "select * from logindetails";
                stmt.executeQuery(query);
rs=stmt.getResultSet();
rs.close();
stmt.close();
}

}catch(Exception e){
      System.out.println(e);
      }
[b][size=18][color=red]/*parameters getting*/[/color][/size][/b]
      if(name.equals(request.getParameter("name")) 
             && password.equals(request.getParameter("password"))){
        out.println("WELCOME "+name);
      }
      else{
        out.println("Please enter correct username and password");
       out.println("<a href='login.jsp'><br>Login again</a>");
%>

}
<body></body>
</html>

now plesse reply!

Can you see that the formatting didn't work? Please edit your message to properly indent your code and remove the color/size tags.

Your form doesn't have an "action" attribute. (Or a closing form tag.)

Nothing to do with JSP -- moved to the HTML forum.

thank you for suggestions freinds!
i have edited the code for loginhandler.jsp,i application is in development mode and i am checking database connectivity at primary level....i want to knowthings like database beans are required at this level or not?
submit button is working now but even after entering the correct login details loginfailed.html page is openning!

formatted codes are given below

login.jsp

loginhandler.jsp

<%@ page contentType="text/html; charset=iso-8859-1" language="java" import="java.sql.*, java.io.*, java.util.*, java.text.*"

errorPage="" %>
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><title></title></head>
/*getting of parameters in request scope*/
<% 
String user=request.getParameter("name");
String pass=request.getParameter("password");
/*database connectivity code*/
try
{                                                                                                                                                             
ResultSet rs;
Class.forName("sun.jdbc.odbc.JdbcOdbcDriver");
Connection con = DriverManager.getConnection("jdbc:odbc:logindsn");
Statement stmt = con.createStatement();
String query = "select * from logindetails";
stmt.executeQuery(query);
rs=stmt.getResultSet();
if(rs.next())
{
String n=rs.getString(1);
String p=rs.getString(2);
if(p.equals(pass))
{
/*setting of attributes in session scope*/
session.setAttribute("user",n);
session.setAttribute("pass",p);
%>
/*forwarding to welcome.jsp*/
<jsp:forward page="welcome.jsp"></jsp:forward>
<%
}
else
{
/*forwarding to loginfailed.html*/			
session.setAttribute("inv","Invalid User & Pass word");
%>
<jsp:forward page="loginfailed.html"></jsp:forward>
<%
}
}
else
{
session.setAttribute("inv","Invalid User & Pass word");
%>
<jsp:forward page="loginfailed.html"></jsp:forward>
<%
}
rs.close();
con.close();
stmt.close();
}
catch(Exception ex)
{
System.out.println(ex);
}
%>
<body></body>
</html>

welcome.jsp

loginfailed.html

Do you really not indent your code?

sir,i am unable to understand how code would ne indented at javaranch?please tell clearly?

Use code tags and indented code and the indentation will be preserved.

but i have used them........i am really confused how to indent them further.

Adding code tags after you've lost the formatting won't help. If you use code tags and put formatted code between them, the formatting will be preserved.

please don't keep aside my queries and questions.i am looking for someone who can resolve them out after looking up the code thoroughly as i am not able to understand how indentation would be done?reply please?

It's hardly surprising that things don't work. You have scriptlets in your JSP -- that's a bad thing. Not only that but you have your JDBC connection hard-coded in those scriptlets -- that's not a very good idea. Not only that but you are trying to use the JDBC-ODBC bridge and there's a good chance you haven't configured an ODBC data source on the server where the JSPs are running.

Anyway it might well be that one of your JSPs is throwing an exception. Have a look in the server logs to see if that's the case.

Ankit Tripathi wrote:please don't keep aside my queries and questions.i am looking for someone who can resolve them out after looking up the code thoroughly as i am not able to understand how indentation would be done?reply please?

The thing is that unindented code is unnecessarily difficult to read: you're a *lot* more likely if you put the effort in to make things as easy as possible to help you.

I have separated the business logic and view.but this time i am getting a new error-
/loginhandler.jsp(4): class 'com.mycompany.login.Login' could not be loaded
probably occurred due to an error in /loginhandler.jsp line 4:
<jsp:useBean id="idHandler" class="com.mycompany.login.Login" scope="request" />
i am using weblogic 8.1 and oracle database server.codes for JSPs and bean class are given below-

login.jsp

loginhandler.jsp

welcome.jsp

Login.java

package com.mycompany.login;
import java.sql.*;
import java.io.*;

public class Login 
{
//default constructor
public Login(){}
//method for the database connection
public Connection getConnection()
throws IOException{
Connection conn = null;
try{
Class.forName("oracle.jdbc.driver.OracleDriver");
conn = DriverManager.getConnection(
"jdbc:oracle:thin:@localhost:1521:xe",
"system",
"abcdefgh");
}
catch(SQLException e)
{
System.out.println("SQLException: " + e.getMessage());
while((e = e.getNextException()) != null)
System.out.println(e.getMessage());
}
catch(ClassNotFoundException e)
{
System.out.println("ClassNotFoundException: " + e.getMessage());
}
return conn;
}
//method that is called from validateuser.jsp and this checks for the authentic user and
public boolean authenticate(String user, String pass)
throws SQLException, IOException{
String Username = null, Password = null;
Login dbconn = new Login();
Statement stmt = dbconn.getConnection().createStatement();
String sql = "SELECT USER_NAME, PASS_WORD FROM LOGINDETAILS WHERE USER_NAME='" + user + "'" + "AND PASS_WORD='" + pass + "'";
ResultSet rs = stmt.executeQuery(sql);
if(rs.next()){
Username = rs.getString("USER_NAME");
Password = rs.getString("PASS_WORD");
}
if(Username != null && Password != null && user.equals(Username) && pass.equals(Password)){
return true;
}
else return false;
}
}

Looks like a deployment issue, perhaps.

Seriously--indent your code. You're not likely to get much help if it's difficult to read.

Also, I'm not sure those sendRedirects will work since you'll have already written to the response.

seriously i am trying to keep my code as clear as possible.
what is the meaning of first and last sentences?pease explain clearly?

Ankit Tripathi wrote:seriously i am trying to keep my code as clear as possible.

Then indent it. Indentation indicates structure. Structure is important. Code is needlessly difficult to read without structure.

what is the meaning of first and last sentences?pease explain clearly?

You can't send a redirect after you've already written to the response (like with HTML).

hi,

i used javascript to focus() on the required field and it is working with <input type="text" name=... onchange=...> and similarly with <html><form></form></html>

but it is focusing something else when I am using <html:form...> and <html:text...>

please help me on this.

Thanks in advance for any help.

Regards.

arun saha,

Why did you hijack this old thread. Post your question in your own thread.

Eric

And make sure you post in the correct form if it's a Struts-specific question.