Having problem compiling this answer

[Nick Hallloran]

This is what it says after i compile the program

class, interface, or enum expected
}
^
1 error

 
public class CrapsGame {

	public static void main(String[] args) {
		//establish random number in dice roll
		int dice1 = (int)(Math.random()* 6) + 1;

		int dice2 = (int)(Math.random()* 6) + 1;

		int roll = dice1 + dice2;

		System.out.println();

		System.out.print("You rolled " + roll + ". ");
		}
		//
		static void diceroll(int roll,int dice1,int dice2) {


			if(roll == 2 || roll == 3 || roll == 12) {

				System.out.println("You Lose !");

				}

				else if(roll == 7 || roll == 11) {

				System.out.println("You Win !");

				}

				else {

			System.out.println("Point is "+roll+"\n");

			dice1 = (int)(Math.random()* 6) + 1;

			dice2 = (int)(Math.random()* 6) + 1;

			int roll2 = dice1 + dice2;

			System.out.print("You rolled "+ roll2 +". ");

			while(roll2 != 7){

				if(roll == roll2){

				System.out.println("You Win !");

				break;

				}

				else {

				System.out.println("Point is "+roll+"\n");

				}

			dice1 = (int)(Math.random()* 6) + 1;

			dice2 = (int)(Math.random()* 6) + 1;

			roll2 = dice1 + dice2;

			System.out.print("You rolled "+roll2+". ");

			}

			if(roll2 == 7) {

				System.out.println("You Lose !");

			}

		}
	}

}
}
}





   

[Matt Cartwright]

it's all in the format

public class CrapsGame
{

   public static void main( String[] args )
   {
      // establish random number in dice roll
      int dice1 = (int) ( Math.random() * 6 ) + 1;

      int dice2 = (int) ( Math.random() * 6 ) + 1;

      int roll = dice1 + dice2;

      System.out.println();

      System.out.print("You rolled " + roll + ". ");
   }

   //
   static void diceroll( int roll, int dice1, int dice2 )
   {

      if ( roll == 2 || roll == 3 || roll == 12 )
      {

         System.out.println("You Lose !");

      }

      else if ( roll == 7 || roll == 11 )
      {

         System.out.println("You Win !");

      }

      else
      {

         System.out.println("Point is " + roll + "\n");

         dice1 = (int) ( Math.random() * 6 ) + 1;

         dice2 = (int) ( Math.random() * 6 ) + 1;

         int roll2 = dice1 + dice2;

         System.out.print("You rolled " + roll2 + ". ");

         while( roll2 != 7 )
         {

            if ( roll == roll2 )
            {

               System.out.println("You Win !");

               break;

            }

            else
            {

               System.out.println("Point is " + roll + "\n");

            }

            dice1 = (int) ( Math.random() * 6 ) + 1;

            dice2 = (int) ( Math.random() * 6 ) + 1;

            roll2 = dice1 + dice2;

            System.out.print("You rolled " + roll2 + ". ");

         }

         if ( roll2 == 7 )
         {

            System.out.println("You Lose !");

         }

      }
   }
}}}

 

count them curly brackets (open & close), and notice the last line in the reformatted listing

good luck at the tables
M

[Henry Wong]

You should better format your code... it really looks unbalanced. Let me check....

 
public class CrapsGame {
    public static void main(String[] args) {
        //
    }
    //
    static void diceroll(int roll,int dice1,int dice2) {
        if(roll == 2 || roll == 3 || roll == 12) {
            //
        } else if(roll == 7 || roll == 11) {
            //
        } else {
            // 
            while(roll2 != 7){
                if(roll == roll2){
                    //
                } else {
                   //
                }
            }
            if(roll2 == 7) {
                 //
            }
        }
    }
}
}    // Extra close brace
}    // Extra close brace

Yup... you have a few extra close braces.

[EDIT: wow. I got beat by 8 seconds.]

Henry

[Nick Hallloran]

ok so i deleted to of the braces..but now all it says is what i rolled...not if i win or lose.... I thought my code was correct...but somewhere im going wrong and i cant find it

[Henry Wong]

Nick Hallloran wrote:...but now all it says is what i rolled...not if i win or lose....

If you start with the main(), and follow what is it doing, you should quickly figure out why. After all, the main() method is only 5 lines long.

Henry

[Nick Hallloran]

I was thinking maybe because i put a closed brace at the end of the main method..but i removed it and added on at the very end and that didnt work either.

[Campbell Ritchie]

You ought to be indenting your code correctly; that will make it easy to see where your {} are matched and where they aren't.

[Ashish Schottky]

@Nick Hallloran

First of all, you should have a good programing style because of which the code becomes more manageable and eligible.
I saw your code and then, you have two more ending braces than required. Its generally that newbies have habit of opening bracket, then write the code and in the end close it. This can lead to syntax errors and hours of headaches to find the problem.
A simple solution to this is ,once you open a bracket, close it straight away and then start writing the code within the brackets.

Always use proper indentations.
Make sure you write as many comments as you can that will help others to identify how a variable or method behaves and reduces the difficulty of understanding the code.

For now here is the code syntax error free code.

  

public class CrapsGame
    {

    public static void main(String[] args)
      {
        //establish random number in dice roll
        int dice1 = (int) (Math.random() * 6) + 1;

        int dice2 = (int) (Math.random() * 6) + 1;

        int roll = dice1 + dice2;

        System.out.println();

        System.out.print("You rolled " + roll + ". ");
      }
    //

    static void diceroll(int roll, int dice1, int dice2)
      {


        if (roll == 2 || roll == 3 || roll == 12)
          {

            System.out.println("You Lose !");

          } else if (roll == 7 || roll == 11)
          {

            System.out.println("You Win !");

          } else
          {

            System.out.println("Point is " + roll + "\n");

            dice1 = (int) (Math.random() * 6) + 1;

            dice2 = (int) (Math.random() * 6) + 1;

            int roll2 = dice1 + dice2;

            System.out.print("You rolled " + roll2 + ". ");

            while (roll2 != 7)
              {

                if (roll == roll2)
                  {

                    System.out.println("You Win !");

                    break;

                  } else
                  {

                    System.out.println("Point is " + roll + "\n");

                  }

                dice1 = (int) (Math.random() * 6) + 1;

                dice2 = (int) (Math.random() * 6) + 1;

                roll2 = dice1 + dice2;

                System.out.print("You rolled " + roll2 + ". ");

              }

            if (roll2 == 7)
              {

                System.out.println("You Lose !");

              }

          }
      }
    }

 

Also last but not the least, make sure you change the habit of naming methods.
for more info, google for programing standards, choose a style which suites you.

[Nick Hallloran]

yea i can get it to compile now no problem..but my problem is that when i execute the program all it says is what i rolled not if i won or lost.

[Ashish Schottky]

@nick

Well take a proper look at the program.
You have written a method,but you are not invoking it.
I have not tried this, but for sure you are not invoking it in this program.