adding objects to an arraylist.

[Rene Rad]

I can not for the life of me figure out what I'm doing wrong when trying to "load the deck".

When I use " deck.add(new Card("Ace","Hearts",11));" it puts in info but not properly. When I print the output it comes out with...

[0] = [Card@de1b8a, Card@1e232b5, Card@16f144c, Card@19da4fc, Card@baa466, Card@17f409c, Card@16acdd1, Card@ee6681, Card@18bbc5a, Card@facf0b, Card@2f0df1, Card@13c6a22, Card@15c07d8, Card@10721b0, Card@134b07e, Card@2f48d2, Card@55d93d, Card@296f76, Card@54c4ad, Card@13c7378, Card@1c0f2e5, Card@8ab708]

When I try "deck.add("Ace","Spades",11);" i get a compile error of "cannot find symbol - method add(java.lang.String,java.lang.String.int)"

Does anyone have a clue or tip that can point me in the right direction? I've tried googling but a lot of crap is for just arrays or the arraylists only pass in one parameter.

Thanks.

 
import java.util.Random;
import java.util.ArrayList;

/**
 * Deck class. This represents a single deck of cards. This class has
 * several "stub" methods with comments and signatures. Feel free to add other
 * methods as you see fit. Suggestion: private void swap(int fistCard, int secondCard)
 * The suggested swap() method would function as a helper to the shuffle() method.
 * 
 * @author Colleen Penrowley 
 * @version Fall 2005 modified Fall 2006, Winter 2008, Fall 2008, Spring 2009
 */
public class Deck  
{
   /** The number of times to shuffle */
   public static final int TIMES_TO_SHUFFLE = 1000;  

   private ArrayList<Card> deck;                   // a deck of cards

    /**
     * Constructor for objects of class Deck
     */
    public Deck()
    {
       deck = new ArrayList<Card>();
       loadDeck();
    }

    /**
     * Load a deck with all the cards
     */
    public void loadDeck()
    {
        deck.add("Ace","Spades",11);
        deck.add(new Card("Ace","Hearts",11));
        deck.add(new Card("Ace","Clubs",11));
        deck.add(new Card("Ace","Diamonds",11));
        deck.add(new Card("King","Spades",10));
        deck.add(new Card("King","Hearts",10));
        deck.add(new Card("King","Clubs",10));
        deck.add(new Card("King","Diamonds",10));
        deck.add(new Card("Queen","Spades",10));
        deck.add(new Card("Queen","Hearts",10));
        deck.add(new Card("Queen","Clubs",10));
        deck.add(new Card("Queen","Diamonds",10));
//         deck.add("Jack","Spades",10);
//         deck.add("Jack","Hearts",10);
//         deck.add("Jack","Clubs",10);
//         deck.add("Jack","Diamonds",10);
//         deck.add("10","Spades",10);
//         deck.add("10","Hearts",10);
//         deck.add("10","Clubs",10);
//         deck.add("10","Diamonds",10);
//         deck.add("9","Spades",9);
//         deck.add("9","Hearts",9);
//         deck.add("9","Clubs",9);
//         deck.add("9","Diamonds",9);
//         deck.add("8","Spades",8);
//         deck.add("8","Hearts",8);
//         deck.add("8","Clubs",8);
//         deck.add("8","Diamonds",8);
//         deck.add("7","Spades",7);
//         deck.add("7","Hearts",7);
//         deck.add("7","Clubs",7);
//         deck.add("7","Diamonds",7);
//         deck.add("6","Spades",6);
//         deck.add("6","Hearts",6);
//         deck.add("6","Clubs",6);
//         deck.add("6","Diamonds",6);
//         deck.add("5","Spades",5);
//         deck.add("5","Hearts",5);
//         deck.add("5","Clubs",5);
//         deck.add("5","Diamonds",5);
//         deck.add("4","Spades",4);
//         deck.add("4","Hearts",4);
//         deck.add("4","Clubs",4);
//         deck.add("4","Diamonds",4);
//         deck.add("3","Spades",3);
//         deck.add("3","Hearts",3);
//         deck.add("3","Clubs",3);
//         deck.add("3","Diamonds",3);
//         deck.add("2","Spades",2);
//         deck.add("2","Hearts",2);
//         deck.add("2","Clubs",2);
//         deck.add("2","Diamonds",2); 
    }
    
    /**
     * Add a single card to the deck.
     * @param a Card object
     */
    public void addCard(Card cardToAdd)
    {
       // add a card to the deck
    }
    
    /**
     * Shuffle the deck. This involves selecting random pairs of 
     * cards and swapping them, the number of times to swap determined
     * by the constant TIMES_TO_SHUFFLE. Java provides a shuffle method
     * as part of the Collections interface, however for this assignment
     * you must write your own.
     */
    public void shuffle()
    {
        // shuffle the deck
    }
    
    
    /**
     * Display the entire contents of the deck. Not used in the
     * game but useful for debugging.
     */
    public void showDeck()
    {
        for(int i=0; i < deck.size(); i++) {
            System.out.println("[" + i + "] = " + deck);
        }
    } 
    
    /**
     * Remove the top card (the first card) from the deck.
     * @return the Card object removed or null if there is nothing in the deck.
     */
    public Card takeCard()
    {
        // return card or 
        return null;
    }
    

}
   

[pete stein]

Rene Rad wrote:

When I use " deck.add(new Card("Ace","Hearts",11));" it puts in info but not properly. When I print the output it comes out with...

[0] = [Card@de1b8a, Card@1e232b5, Card@16f144c, Card@19da4fc, Card@baa466, Card@17f409c, Card@16acdd1, Card@ee6681, Card@18bbc5a, Card@facf0b, Card@2f0df1, Card@13c6a22, Card@15c07d8, Card@10721b0, Card@134b07e, Card@2f48d2, Card@55d93d, Card@296f76, Card@54c4ad, Card@13c7378, Card@1c0f2e5, Card@8ab708]

This is happening because the Card class doesn't have a proper toString() method. You need to fix that by either giving it a toString method or rather than trying to print the array at once, iterate through it with a for loop and print each Card's fields one at at time.

When I try "deck.add("Ace","Spades",11);" i get a compile error of "cannot find symbol - method add(java.lang.String,java.lang.String.int)"

look carefully at how you're handling this add and you'll see it's quite different (and incorrect) from the others.

[Rene Rad]

pete stein wrote:

Rene Rad wrote:

When I use " deck.add(new Card("Ace","Hearts",11));" it puts in info but not properly. When I print the output it comes out with...

[0] = [Card@de1b8a, Card@1e232b5, Card@16f144c, Card@19da4fc, Card@baa466, Card@17f409c, Card@16acdd1, Card@ee6681, Card@18bbc5a, Card@facf0b, Card@2f0df1, Card@13c6a22, Card@15c07d8, Card@10721b0, Card@134b07e, Card@2f48d2, Card@55d93d, Card@296f76, Card@54c4ad, Card@13c7378, Card@1c0f2e5, Card@8ab708]

This is happening because the Card class doesn't have a proper toString() method. You need to fix that by either giving it a toString method or rather than trying to print the array at once, iterate through it with a for loop and print each Card's fields one at at time.

When I try "deck.add("Ace","Spades",11);" i get a compile error of "cannot find symbol - method add(java.lang.String,java.lang.String.int)"

look carefully at how you're handling this add and you'll see it's quite different (and incorrect) from the others.

I know the second one is different, just something else I was trying. So are you saying that "deck.add(new Card("Ace","Hearts",11));" is in fact putting the correct information into the ArrayList? Cuz when I inspect it I get this... (see attached image)

[Rene Rad]

Nevermind, my Card Class had a logic error in the constructor. The suit parameter wasn't being passed into the instance variable.

Thanks for your help .

[pete stein]

Rene Rad wrote:
I know the second one is different, just something else I was trying. So are you saying that "deck.add(new Card("Ace","Hearts",11));" is in fact putting the correct information into the ArrayList?

I believe so, since deck is an ArrayList of Card type, you must add a Card objects. Your showDeck() method looks wrong:

     public void showDeck()  
     {  
         for(int i=0; i < deck.size(); i++) {  
             System.out.println("[" + i + "] = " + deck);  
         }  
     }

The line:

System.out.println("[" + i + "] = " + deck);

is printing out the whole ArrayList, deck with each iteration. Rather than do that it should print out the i'th item, and ArrayList has a method that should be called here to allow you to do this.

[Rene Rad]

Ya I got this...

   
 public void showDeck()
    {
            for (Card x : deck) {
            System.out.println("Type: "+ x.getDescription() + " Suit: " + x.getSuit()+ " Value: " + x.getValue() );
        
        }
    }