Action problem

[Alvin chew]

Type : ActionForm
Name : TestForm

  
import org.apache.struts.action.*;
public class TestForm extends ActionForm{
    
   private String email="";
   private String password="";
   
      public java.lang.String getEmail() {
       return email;
   }   
   
      public void setEmail(java.lang.String email) {
       this.email = email;
   }   
    
      public java.lang.String getPassword() {
       return password;
   }
   
      public void setPassword(java.lang.String password) {
       this.password = password;
   }
   
}
 

Type : Action
Name : Testing

import javax.servlet.http.*;
import org.apache.struts.action.*;
import actionform.test.TestForm;
 
public class Testing extends Action {
  public ActionForward execute(ActionMapping mapping,
                               ActionForm form,
                               HttpServletRequest request,
                               HttpServletResponse response)
      throws Exception {
    
          TestForm tf = (TestForm)form;         
          
          String form_email = tf.getEmail();
          String form_password = tf.getPassword();
          
          if(form_email==null)
          {
return(mapping.findForward("fail"));
                
  }
          else
          {
       
          return(mapping.findForward("success"));
          }
  }
}

hi, good day, i having a problem in action, which as shown on top source code, my problem is if i do not type any character in email textfield, it still calling the "success", can any GURU here please point out my mistake ? thank you very much !!
[ August 23, 2004: Message edited by: Alvin chew ]

[Marc Peabody]

an empty textfield submission calls setEmail("")

email is then set to ""

so the getEmail is returning ""

your check is for null, not "" (empty String)

[Alvin chew]

thank you marc !!

[Alvin chew]

another problem which now cause actionmapping or actionform collection problem ..

struts-config.xml - formbean part

 <form-bean name="CompanyFormBean" type="formbeans.company.CompanyFormBean" />

struts-config.xml - actionmapping part

<action path="/actions/company" type="actions.company.Testing" name="CompanyFormBean" scope="request" input="/forms/newac.jsp"><forward name="success" path="/results/get.jsp" redirect="false" /></action>

action class

package actions.company;
 
import javax.servlet.http.*;
import org.apache.struts.action.*;
 
public class Testing extends Action {
  public ActionForward execute(ActionMapping mapping,
                               ActionForm form,
                               HttpServletRequest request,
                               HttpServletResponse response)
      throws Exception {
    return(mapping.findForward("success"));
  }
}
 

[Alvin chew]

actionform

package formbeans.company;
 
import org.apache.struts.action.*;
 
public class CompanyFormBean extends ActionForm {
 
  private String comcompany = "";
  private String comindustrial = "";
  private String comstatus = "";
  private String comwebsite = "";
  private String comemail = "";
  private String comtype = "";
  private String comaddress = "";
  private String comcity = "";
  private String comstate = "";
  private String comcountry = "";
 
  private double comrevenue;
 
  private int compostcode;
  private int comemployees;
  private int comphone;
  private int comfax;
 
  public void setComcompany(String company)
  {
  this.comcompany = company;
  }
 
  public String getComcompany()
  {
  return comcompany;
  }
 
  public void setComindustrial(String industrial)
  {
  this.comindustrial = industrial;
  }
 
  public String getComindustrial()
  {
  return comindustrial;
  }
 
  public void setComrevenue(double revenue)
  {
  this.comrevenue = revenue;
  }
 
  public double getComrevenue()
  {
   return comrevenue;
  }
 
  public void setComemployees(int employees)
  {
  this.comemployees = employees;
  }
 
  public int getComemployees()
  {
  return comemployees;
  }
 
  public void setComstatus(String status)
  {
  this.comstatus = status;
  }
 
  public String getComstatus()
  {
  return comstatus;
  }
 
  public void setComphone(int phone)
  {
  this.comphone = phone;
  }
 
  public int getComphone()
  {
  return comphone;
  }
 
  public void setComfax(int fax)
  {
  this.comfax = fax;
  }
 
  public int getComfax()
  {
  return comfax;
  }
 
  public void setComwebsite(String website)
  {
  this.comwebsite = website;
  }
 
  public String getComwebsite()
  {
  return comwebsite;
  }
 
  public void setComemail(String email)
  {
  this.comemail = email;
  }
 
  public String getComemail()
  {
  return comemail;
  }
 
  public void setComtype(String type)
  {
  this.comtype = type;
  }
 
  public String getComtype()
  {
  return comtype;
  }
 
  public void setComaddress(String address)
  {
  this.comaddress = address;
  }
 
  public String getComaddress()
  {
  return comaddress;
  }
 
  public void setComcity(String city)
  {
  this.comcity = city;
  }
 
  public String getComcity()
  {
  return comcity;
  }
 
  public void setComstate(String state)
  {
  this.comstate = state;
  }
 
  public String getComstate()
  {
  return comstate;
  }
 
  public void setCompostcode(int postcode)
  {
  this.compostcode = postcode;
  }
 
  public int getCompostcode()
  {
  return compostcode;
  }
 
  public void setComcountry(String country)
  {
  this.comcountry = country;
  }
 
  public String getComcountry()
  {
  return comcountry;
  }
}
 

html form

<%@ taglib uri="/WEB-INF/struts-html.tld" prefix="html" %>
<HTML>
 
<HEAD>
 
<TITLE>New Account Registration</TITLE>
 
</HEAD>
 
<BODY BGCOLOR="#E5E0C4">
 
<CENTER>
 
<H1>New Account Registration</H1>
 

  
  
 

<html:form action="/actions/company">
  
  Company: <html:text property="comcompany"/><BR>
  Industrial: <html:text property="comindustrial"/><BR>
    Annual Revenue: <html:text property="comrevenue"/><BR>
    Total Employees: <html:text property="comemployees"/><BR>
    Status: <html:text property="comstatus"/><BR>
    Phone: <html:text property="comphone"/><BR>
    Fax: <html:text property="comfax"/><BR>
    Website: <html:text property="comwebsite"/><BR>
    Email: <html:text property="comemail"/><BR>
    
    Type: <html:text property="comtype"/><BR>
  Address: <html:text property="comaddress"/><BR>
    City: <html:text property="comcity"/><BR>
   State: <html:text property="comstate"/><BR>
   Post Code: <html:text property="compostcode"/><BR>
  Country: <html:text property="comcountry"/><BR>
  
 
  
 <html:submit value="Sign Me Up!"/>
 

</html:form>
 
</CENTER>
 
</BODY>
 
</HTML>
 

[Alvin chew]

as mentioned, i found the actionmapping or actionform collection error, i check the error for many times, still can't figure out what problem is it ...as a newbie in struts, i would like to say thank you again for your time and your advice !!

[Andy Deighton]

You haven't actually described what the problem is. What error are you getting?

Andy

[Alvin chew]

hi, andy, thank for viewing, my tomcat show me the "actionmapping or actionform collection error"

[Alvin chew]

to further describe, my problem is actually , the jsp page that suppose to display form but some how it couldn't display out but generate the error