reinitializing a String variable

[Dan Acuff]

Shouldn't the code I have written work so far as the cm_pageName getting reset to HOME or LIST ?
What am I doing wrong in resetting cm_pageName?

  		String cm_ScriptName = request.getServletPath().trim();
		String cm_pageName = new String();
		if (cm_ScriptName == "/store/newshop/home.do"){
			cm_pageName = "HOME";
		}
		if (cm_ScriptName == "/store/newshop/product_list.do"){
			cm_pageName = "LIST";
		}  

I am just getting blank values and I have tested the value of cm_pageName to be one of the 2 strings shown.

Thanks,
Dan

[Rob Spoor]

Never use == for String comparison - use the equals method instead.

[Dan Acuff]

Thanks a lot~

Looks like this for the record.

  		String cm_ScriptName = request.getServletPath().trim();
		String cm_pageName = new String();
		if (cm_ScriptName.equals("/store/newshop/home.do")){
			cm_pageName = "HOME";
		}
		
		if (cm_ScriptName.equals("/store/newshop/product_list.do")){
			cm_pageName = "LIST";
		} 

[Sita Marivada]

== is used to compare the values of primitive typed variables and the memory location of Objects.
equals is used to compare the content of the two objects.

== is normally much faster than equals since it just checks the memory location of two objects.

[Dan Acuff]

Oh I see.. and since String is not a primitive variable type, the equals method is better.

[marc weber]

Dan Acuff wrote:Oh I see.. and since String is not a primitive variable type, the equals method is better.

That's correct. And using == to compare Strings is a little more complicated than with most objects because of the String pool. See Strings Literally.

[David Newton]

On line 2 there is no reason to create a new string.