Need an attribute to be available in different places (SOLVED)

I have a basic site with a login page, a new user registration, a welcome page, and an edit info page.

After logging in, a user gets a page with this:

The username bean is set on a login action

On that same page there is an edit profile link. When the user clicks that link, I need to send him to that page, and I would like that same welcome message to be available.

I have tried just copying and pasting the above to this subsequent page, but I get this: javax.servlet.jsp.JspException: Cannot find bean username in any scope

I have tried setting the scope attribute to "session" on both pages, as well as setting the login action-mapping to session, but it has not worked either. I thought that would be the solution, but apparently not.

The reason I need to do this is because on this edit profile page, I need to tell the java code what the username is, so it can change the database with the new input info based on whatever user is logged in

Here are what i think are the relevant jsp and java code:

LoginSuccess.jsp

<%@ page language="java" pageEncoding="ISO-8859-1"%>

<%@ taglib uri="http://jakarta.apache.org/struts/tags-bean" prefix="bean"%> 
<%@ taglib uri="http://jakarta.apache.org/struts/tags-html" prefix="html"%>

<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<html:html>
 <head>
 <html:base />
 
 <title>Tim Buth Login Success Page</title>

</head>
 
 <body><div align="center"> 
 Tim Buth's ISQS 4361 Project User Login, Registration, and Account Management Using MySQL Database 
 <a href="/buth/login.jsp">Login Page</a> 
 | <a href="/buth/profile.jsp">Edit Profile</a> | <a href="/buth/delete.jsp">Delete Profile</a> </div>
		Hello <bean:write name="username" scope="request" />, you are now logged in You can <a href="/buth/profile.jsp">
		Edit your Profile Info</a> or <a href="/buth/delete.jsp">Delete your Profile</a> with the links along the top. 
		 <a href="/buth/login.jsp">Logout</a> 
		</body>
</html:html>

profile.jsp

<%@ page language="java" pageEncoding="ISO-8859-1"%>
<%@ taglib uri="http://jakarta.apache.org/struts/tags-bean" prefix="bean"%> 
<%@ taglib uri="http://jakarta.apache.org/struts/tags-html" prefix="html"%>
 
<html> 
	<head>
		<title>Tim Buth Edit Profile Page</title>
	</head>
	<body><div align="center"> 
 Tim Buth's ISQS 4361 Project User Login, Registration, and Account Management Using MySQL Database 
 <a href="/buth/login.jsp">Login Page</a> | <a href="/buth/profile.jsp">Edit Profile</a> | <a href="/buth/delete.jsp">Delete Profile</a>
 <div align="left">Profile Edit </div></div>
		<html:form action="/changeProfile"> 
			 
			Password : <html:text property="changedPassword"/><html:errors property="changedPassword"/> 
			Email : <html:text property="changedEmail"/><html:errors property="changedEmail"/> 
			First Name : <html:text property="changedFirstName"/><html:errors property="changedFirstName"/> 
			Last Name : <html:text property="changedLastName"/><html:errors property="changedLastName"/> 
			<html:submit value="Make Changes"/>
		</html:form>
		 <a href="/buth/login.jsp">Logout</a>
	</body>
</html>

loginAction.java

/*
 * Generated by MyEclipse Struts
 * Template path: templates/java/JavaClass.vtl
 */
package com.yourcompany.struts.action;

import java.sql.Connection;
import java.sql.ResultSet;
import java.sql.SQLException;
import java.sql.Statement;

import javax.servlet.ServletRequest;
import javax.servlet.ServletResponse;
import javax.servlet.http.HttpServletRequest;
import javax.servlet.http.HttpServletResponse;
import org.apache.struts.action.Action;
import org.apache.struts.action.ActionForm;
import org.apache.struts.action.ActionForward;
import org.apache.struts.action.ActionMapping;

import ch03.LookupForm;
import code.Constants;

import com.yourcompany.struts.form.LoginForm;

/** 
 * MyEclipse Struts
 * Creation date: 04-21-2010
 * 
 * XDoclet definition:
 * @struts.action path="/login" name="loginForm" input="/login.jsp" scope="request" validate="true"
 * @struts.action-forward name="failure" path="/login.jsp"
 * @struts.action-forward name="success" path="/loginSuccess.jsp"
 */
public class LoginAction extends Action implements Constants {
	/*
	 * Generated Methods
	 */

/** 
	 * Method execute
	 * @param mapping
	 * @param form
	 * @param request
	 * @param response
	 * @return ActionForward
	 * @throws SQLException 
	 */
	
	protected String getPassword (String userName, HttpServletRequest request) throws SQLException{
		String sPassword = null;
		//String sUserName = null;
		Connection con = null;
		
		con = getDataSource(request,"usersDS").getConnection();
		
		Statement stmt = con.createStatement();
		String sQuery = "select pword from users where userID=\'" + userName + "\';";
		ResultSet rs = stmt.executeQuery(sQuery);
		while (rs.next()) {
			sPassword = rs.getString("pword");
			System.out.println("Value of sPassword from getPassword method: "+sPassword+" & username: "+userName );
		}
			
		con.close();
		
		return sPassword; 
		//return sUserName;
	}

public ActionForward execute(ActionMapping mapping, ActionForm form,
			HttpServletRequest request, HttpServletResponse response) {
		// TODO Auto-generated method stub
		
		String sUserName = null;
		String sPassword = null;
		
		String sFwd = new String("failure");
		
		if (form != null) {

LoginForm loginForm = (LoginForm) form;

sUserName = loginForm.getUsername();
			//sPassword = loginForm.getPassword();
			try {
				sPassword = getPassword(sUserName, request);
				System.out.println("Value of password from loginForm: "+loginForm.getPassword()+" & sPassword: "+sPassword );
				if (sPassword.toString().equals(loginForm.getPassword().toString())){
					System.out.println("Success");
					sFwd = "success";
				//request.setAttribute("password", sPassword);
				request.setAttribute("username", sUserName);}
				//else sFwd = "failure";
			} catch (Exception e) {
				request.getSession().setAttribute("error", e);
				sFwd = "failure";	
			}
		}
		
		return (mapping.findForward(sFwd));
	}
}

ChangeProfileAction.java

/*
 * Generated by MyEclipse Struts
 * Template path: templates/java/JavaClass.vtl
 */
package com.yourcompany.struts.action;

import java.sql.Connection;
import java.sql.SQLException;
import java.sql.Statement;

import javax.servlet.http.HttpServletRequest;
import javax.servlet.http.HttpServletResponse;
import org.apache.struts.action.Action;
import org.apache.struts.action.ActionForm;
import org.apache.struts.action.ActionForward;
import org.apache.struts.action.ActionMapping;
import com.yourcompany.struts.form.ChangeProfileForm;
import com.yourcompany.struts.form.LoginForm;
import com.yourcompany.struts.form.RegisterForm;

/** 
 * MyEclipse Struts
 * Creation date: 04-22-2010
 * 
 * XDoclet definition:
 * @struts.action path="/changeProfile" name="changeProfileForm" input="/profile.jsp" scope="request" validate="true"
 * @struts.action-forward name="failure" path="/profile.jsp"
 * @struts.action-forward name="success" path="/profile.jsp"
 */
public class ChangeProfileAction extends Action {
	/*
	 * Generated Methods
	 */

/** 
	 * Method execute
	 * @param mapping
	 * @param form
	 * @param request
	 * @param response
	 * @return ActionForward
	 * @throws SQLException 
	 */
	
	/*public static void main(String[] args) {
	HttpServletRequest request = null;
	// TODO Auto-generated method stub
	try {
		editProfile("currentUser", "user", "password", "email", "first name", "last name");
	} catch (SQLException e) {
		// TODO Auto-generated catch block
		e.printStackTrace();
	}

}*/
	
	protected String editProfile (String currentUsername, String changedPassword, String changedEmail, String changedFirstName, 
			String changedLastName, HttpServletRequest request) throws SQLException{
		String sStatus = "failure";
		
		Connection con = null;
		
		con = getDataSource(request, "usersDS").getConnection();
		
		Statement stmt = con.createStatement();
		String sQuery = "update users set pword = \'"+changedPassword+"\', email = \'"+changedEmail+
			"\', firstName = \'"+changedFirstName+"\', lastName = \'"+changedLastName+"\' where userID = \'"+currentUsername+"\';";
		System.out.println("SQL: update users set pword = \'"+changedPassword+"\', email = \'"+changedEmail+
			"\', firstName = \'"+changedFirstName+"\', lastName = \'"+changedLastName+"\' where userID = \'"+currentUsername+"\';");
		
		int rs = stmt.executeUpdate(sQuery);
		con.commit();
		
		if(rs!=0){
			System.out.println("rs!=0");
			sStatus = "success";
		}else System.out.println("rs=0");
		
		con.close();
		
		return sStatus;
	}
	
	public ActionForward execute(ActionMapping mapping, ActionForm form,
			HttpServletRequest request, HttpServletResponse response) {
		
		String sFwd = new String("failure");
		
		
		//LoginAction loginAction = new LoginAction();
		String sCurrentUserName = null;
		
		
		
		//String sCurrentPassword;
		//String sCurrentEmail;
		//String sCurrentFirstName;
		//String sCurrentLastName;
		
		//ChangeProfileForm profileForm = new ChangeProfileForm();

//String sChangedUserName = null;
		String sChangedPassword = null;
		String sChangedEmail = null;
		String sChangedFirstName = null;
		String sChangedLastName = null;
		
		if (form!=null){
		ChangeProfileForm changeProfileForm = (ChangeProfileForm) form;// TODO Auto-generated method stub
			
		//sCurrentUserName = changeProfileForm.getChangedUsername();
		//sCurrentPassword = changeProfileForm.getChangedPassword();
		//sCurrentEmail = changeProfileForm.getChangedEmail();
		//sCurrentFirstName = changeProfileForm.getChangedFirstName();
		//sCurrentLastName = changeProfileForm.getChangedLastName();

//sChangedUserName = changeProfileForm.getChangedUsername();
		sChangedPassword = changeProfileForm.getChangedPassword();
		sChangedEmail = changeProfileForm.getChangedEmail();
		sChangedFirstName = changeProfileForm.getChangedFirstName();
		sChangedLastName = changeProfileForm.getChangedLastName();
		
		try {
				System.out.println("profile change execute values: "+sCurrentUserName+" "+sChangedPassword+" "+sChangedEmail+" "+sChangedFirstName+" "
						+sChangedLastName);
				sFwd = editProfile(sCurrentUserName, sChangedPassword, sChangedEmail, sChangedFirstName, sChangedLastName, request);
				if (sFwd.equals("success")){
				System.out.println("sFwd changed to success");}
				//request.setAttribute("newUserSuccess", "You can now login ");
			} catch (SQLException e) {
				request.getSession().setAttribute("error", e);
				sFwd = "failure";
			}
		}
		return (mapping.findForward(sFwd));
	}
}

I have tried setting the scope attribute to "session" on both pages, as well as setting the login action-mapping to session

And you also changed your Action to put the username in the session ? Meanning replacing request.setAttribute("username", sUserName);.

Generally , you can put user specific details [very few, not much] into session . so that, when ever you need them, you can take from session.

so ,In *LoginAction* create HttpSession and change this request.setAttribute("username", sUserName); to *session.setAttribute("username", sUserName);*

hth

Oops! Christophe has been beaten me

Christophe Verré wrote:
And you also changed your Action to put the username in the session ? Meanning replacing request.setAttribute("username", sUserName);.

.

I did not do that. I bet that is my problem, I will update the thread once I have a chance to try this out. So instead of request.setAttribute I need to use session.setAttribute. I really think that is the problem

Hmm, no good ><

I changed the login Action to a session scope in the struts-config file.

Then on my loginSuccess page I changed this line :

And in my java code I changed the following code to accommodate session instead of request (code pointed out with <<<<<<<<<<<<<<<<<<<<<<)

package com.yourcompany.struts.action;

public class LoginAction extends Action implements Constants {
	
	/** 
	 * Method execute
	 * @param mapping
	 * @param form
	 * @param request
	 * @param response
	 * @return ActionForward
	 * @throws SQLException 
	 */

public ActionForward execute(ActionMapping mapping, ActionForm form,
			HttpSession request, HttpServletResponse response) { //<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<
		// TODO Auto-generated method stub
		
		String sUserName = null;
		String sPassword = null;
		
		String sFwd = new String("failure");
		
		if (form != null) {

LoginForm loginForm = (LoginForm) form;

sUserName = loginForm.getUsername();
			//sPassword = loginForm.getPassword();
			try {
				System.out.println("Before getPassword is called");
				sPassword = getPassword(sUserName, request); //<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<
				System.out.println("Value of password from loginForm: "+loginForm.getPassword()+" & sPassword: "+sPassword );
				if (sPassword.toString().equals(loginForm.getPassword().toString())){
					System.out.println("Success");
					sFwd = "success";
				//request.setAttribute("password", sPassword);
				request.setAttribute("username", sUserName);}//<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<
				//else sFwd = "failure";
			} catch (Exception e) {
				((HttpServletRequest) request).getSession().setAttribute("error", e);//<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<
				sFwd = "failure";	
			}
		}
		
		return (mapping.findForward(sFwd));
	}

protected String getPassword (String userName, HttpSession request) throws SQLException{//<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<
		String sPassword = null;
		//String sUserName = null;
		Connection con = null;
		
		con = getDataSource((HttpServletRequest) request,"usersDS").getConnection();//<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<
		
		Statement stmt = con.createStatement();
		System.out.println("before query executed "+" select pword from users where userID=\'" + userName + "\';");
		String sQuery = "select pword from users where userID=\'" + userName + "\';";
		ResultSet rs = stmt.executeQuery(sQuery);
		while (rs.next()) {
			sPassword = rs.getString("pword");
			System.out.println("Value of sPassword from getPassword method: "+sPassword+" & username: "+userName );
		}
			
		con.close();
		
		return sPassword; 
		//return sUserName;
	}
}

But when I try to login now I just get a blank white page. It is not even getting as far as line 33, because nothing is being printed to the console. Any idea where I am going wrong?

OK, well that did not work, but it did spark my brain and I found a different solution. This may have been what you guys meant this entire time.

When the user logs in, within that login code I added:

where sUserName is that request attribute assigned upon login.

Them when I need to use this value in a different Class, I used

This worked just fine

I do have another question now however.

Can I use this ServletContext attribute "username" on a jsp page, and if yes how do I do so?

edit - nevermind, found the answer to this one myself: <%=application.getAttribute("username")%>

Thanks for the help

Is there any reason you're not using EL?

Because I have not used that tag library and don't know it's capabilities

It's not a tag library, it's JSP.