Spring Transaction Management doesn't roll back my transaction

[Duffman Be]

Hi,

I'm implementing Spring Transaction Management into one of my webapplications, but it seems like it isn't working.
I have used this (http://static.springsource.org/spring/docs/2.0.4/reference/transaction.html) documentation to implement it.

<?xml version="1.0" encoding="UTF-8"?>
<beans xmlns="http://www.springframework.org/schema/beans"
       xmlns:aop="http://www.springframework.org/schema/aop"
       xmlns:tx="http://www.springframework.org/schema/tx"
       xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
       xsi:schemaLocation="http://www.springframework.org/schema/beans http://www.springframework.org/schema/beans/spring-beans-3.0.xsd
                        http://www.springframework.org/schema/tx http://www.springframework.org/schema/tx/spring-tx-3.0.xsd
                        http://www.springframework.org/schema/aop http://www.springframework.org/schema/aop/spring-aop-3.0.xsd">

    <!-- transaction management -->


    <tx:advice id="txAdvice" transaction-manager="db_transactionManager">
        <tx:attributes>
            <tx:method name="get*" read-only="true"/>
            <tx:method name="*" rollback-for="java.lang.Exception"/>
        </tx:attributes>
    </tx:advice>

    <aop:config>
        <aop:pointcut id="daoOperation"
                      expression="execution(* com.comp.projn.webconsole.dao.*.*(..))"/>
        <aop:advisor pointcut-ref="daoOperation" advice-ref="txAdvice"/>
    </aop:config>

    <!-- db_database properties -->
    <bean id="db_database"
          class="org.apache.commons.dbcp.BasicDataSource">
        <property name="driverClassName" value="com.mysql.jdbc.Driver"/>
        <property name="url" value="jdbc:mysql://localhost:3306/projn_dev"/>
        <property name="username" value="dummy"/>
        <property name="password" value="dummy"/>
    </bean>

    <bean id="db_sessionFactory"
          class="org.springframework.orm.hibernate3.LocalSessionFactoryBean">
        <property name="dataSource" ref="db_database"/>
        <property name="hibernateProperties">
            <props>
                <prop key="hibernate.dialect">
                    org.hibernate.dialect.MySQLDialect
                </prop>
                <prop key="hibernate.show_sql">true</prop>
            </props>
        </property>

        <property name="mappingDirectoryLocations">
            <list>
                <value>classpath:*db_hibernate</value>
            </list>
        </property>

    </bean>

    <tx:annotation-driven transaction-manager="db_transactionManager"/>

    <bean id="db_transactionManager" class="org.springframework.orm.hibernate3.HibernateTransactionManager">
        <property name="sessionFactory" ref="db_sessionFactory"/>
    </bean>

    <bean id="db_hibernateTemplate"
          class="org.springframework.orm.hibernate3.HibernateTemplate">
        <property name="sessionFactory" ref="db_sessionFactory"/>
    </bean>

    <!-- db_DAO's -->

    <bean id="db_userDao" class="com.comp.projn.webconsole.dao.Db_UserDaoImpl" scope="singleton">
        <property name="hibernateTemplate" ref="db_hibernateTemplate"/>
    </bean>

    <bean id="db_practiceDao" class="com.comp.projn.webconsole.dao.Db_PracticeDaoImpl" scope="singleton">
        <property name="hibernateTemplate" ref="db_hibernateTemplate"/>
        <property name="dbFactory" ref="db_hibernateTemplate"/>
    </bean>
</beans>

I think this XML should make sure that a transaction should be rolled back whenever an exception occurs in one of my dao-classes.
However when I run this code:

package com.comp.projn.webconsole.dao;


public class Tf_PracticeDaoImpl extends HibernateDaoSupport implements Tf_PracticeDao{
    HibernateTemplate dbFactory;

    public HibernateTemplate getDbFactory() {
        return dbFactory;
    }

    public void setDbFactory(HibernateTemplate dbFactory) {
        this.dbFactory = dbFactory;
    }

    public Boolean createPractice(TfPracticeDetails tfPracticeDetails) {
        try{
            dbFactory.save(tfPracticeDetails);
            dbFactory.find("SELECT wrong_column FROM wrong_db");
            return true;
        }catch(DataAccessException dae){
            return false;
        }catch(Exception e){
            e.printStackTrace();
            return false;
        }
    }

    public Boolean practiceNameExists(String practiceName) {
        return (Integer) dbFactory.find("FROM TfPracticeDetails  p WHERE p.practiceName = ?",practiceName).size()>0  ;
    }
}

When I run the "createPractice" method (which generates an error), it doesn't rollback the record I added in the first line of this method. Does anyone know what I'm doing wrong here?

Thanks,
Duffman-

[Mark Spritzler]

Well, based on looking at your code, your DAO is catching all the exceptions instead of them being thrown. So in the end, there is no exception thrown.

Also by default all RuntimeExceptions thrown will cause a rollback, in most cases you won't need the "rollbackFor="Exception.class"

So in your DAO catch code, rethrow the exception up the stack.

Mark