aspose file tools*
The moose likes Java in General and the fly likes Linked List Operations adding node after intervals. Big Moose Saloon
  Search | Java FAQ | Recent Topics | Flagged Topics | Hot Topics | Zero Replies
Register / Login
JavaRanch » Java Forums » Java » Java in General
Bookmark "Linked List Operations adding node after intervals." Watch "Linked List Operations adding node after intervals." New topic
Author

Linked List Operations adding node after intervals.

akash negi
Greenhorn

Joined: Feb 24, 2010
Posts: 27
Hi all. I have my final exams coming up and I am struck on one of the practice problems..
Suppose we are given a linked list of Integers. we have to add a value after given interval..


For example, if the list is currently

9 -> 4 -> 3 -> 12 -> 4 -> 1 -> 4

and we call addAtIntervals(list, 2, 10), the list should then become

9 -> 4 -> 10 -> 3 -> 12 -> 10 -> 4 -> 1 -> 10 -> 4

because the interval is 2, we have to add 10 after every 2 nodes.


we are also given an IntNode class in which head.next represents the next element to head and head.data is equal to the value stored in the element.

Here is the code I have so far for this.. It is not working as intended.
Please have a look and let me know what looks wrong.



Thanks!!


***EDIT***
The length() function i have is as follows..

Campbell Ritchie
Sheriff

Joined: Oct 13, 2005
Posts: 39869
    
  28
Have you allowed for the fact that adding a node will alter the length of each node following? Also, recalculating the length after each iteration will make your method run in quadratic time.
akash negi
Greenhorn

Joined: Feb 24, 2010
Posts: 27
Thanks for replying!
Ok so I changed my algorithm to get rid of the length() completely.


I am currently getting a MemoryOut error Java heap, but lets assume i will fix my memory issues, do you think it should work after that?

Thanks!!
Campbell Ritchie
Sheriff

Joined: Oct 13, 2005
Posts: 39869
    
  28
No. Pencil and paper, as I told you earlier.
akash negi
Greenhorn

Joined: Feb 24, 2010
Posts: 27
done sir.. now working fine..

Thanks!
Campbell Ritchie
Sheriff

Joined: Oct 13, 2005
Posts: 39869
    
  28
well done Please tell us how you managed it.
akash negi
Greenhorn

Joined: Feb 24, 2010
Posts: 27
Campbell Ritchie wrote:well done Please tell us how you managed it.


its basically the same code but I just added



inside the while loop. I was getting an Memory out of Bound Java heap error because it was not traversing through the list. As a result it was executing


infinite number of times and as a result the insufficient memory error..

when I added the line to the code. It works like a charm now!


thanks!
 
I agree. Here's the link: http://aspose.com/file-tools
 
subject: Linked List Operations adding node after intervals.