This week's book giveaway is in the Clojure forum.
We're giving away four copies of Clojure in Action and have Amit Rathore and Francis Avila on-line!
See this thread for details.
Win a copy of Clojure in Action this week in the Clojure forum!
  • Post Reply
  • Bookmark Topic Watch Topic
  • New Topic

Pattern to replace switch case with different funtionality in the case block

 
Joshua Antony
Ranch Hand
Posts: 254
  • 0
  • Mark post as helpful
  • send pies
  • Quote
  • Report post to moderator
I have a situation here, below is the extract


I want to get rid of the switch statement, reading through one of Martin Fowler's book found that this can be replaced by adding appropriate subclass (for each case condition) and using the same polymorphically in this method.

However, as can be seen by the method getting invoked, they dont seem to be doing similar work, so subclassing them with a common parent would not yeild a common behavior(method) to be abstracted out in the parent class.

Is there any way to get around this situation, or am I better off creating different methods for each case statement?

Cheers-
Joshua
 
David Newton
Author
Rancher
Posts: 12617
IntelliJ IDE Ruby
  • 0
  • Mark post as helpful
  • send pies
  • Quote
  • Report post to moderator
Command pattern.
 
Tim Holloway
Saloon Keeper
Pie
Posts: 17625
39
Android Eclipse IDE Linux
  • 0
  • Mark post as helpful
  • send pies
  • Quote
  • Report post to moderator
Subclassing using overloaded ("virtual") functions is an effective, efficient and powerful technique, but your sample code doesn't look like a good fit, since it looks more like you're interested in extracting different selections of data from a SINGLE object than in getting different data from different instances of an object. The fact that the destination data is always of the same type is immaterial.

In practical terms, I would probably keep the switch statement. It's simple, easy to read and unambiguous. And as a plus, most compilers contain extensive functions to optimize switch statements to a bare minimum of overhead.

I might change my mind if things got more complicated, but for the example given, I'd probably not lose sleep over it.
 
Jimmy Clark
Ranch Hand
Posts: 2187
  • 0
  • Mark post as helpful
  • send pies
  • Quote
  • Report post to moderator
I would move the conditional logic into the storeManager class and have a common fetch method. For example,



In my opinion, it would best to keep this type of logic outside of a Servlet class, and would be more appropriate inside the storeManager.
 
I agree. Here's the link: http://aspose.com/file-tools
  • Post Reply
  • Bookmark Topic Watch Topic
  • New Topic