Very basic question regarding example on p135/136 of the GIA book

[Craig Treptow]

Hi. I'm going through the book "Groovy In Action" using Eclipse. On page, 135,136, I wanted to see the benchmark run. So, I have this:

The caller:

	def ch5 = new Chapter5();
		ch5.runBenchmark()

and the class:

class Chapter5 {
	
	public void runBenchmark() {
		
		def benchmark(repeat, Closure worker) {
			start = System.currentTimeMillis()
			repeat.times{worker(it)}
			stop = System.currentTimeMillis()
			return stop - start
		}
		
		def slow = benchmark(10000) { (int) it / 2 }
		def fast = benchmark(10000) { it.intdiv(2) }
		
		assert fast * 15 < slow
		println "Slow: $slow"
		println "Fast: $fast"
	}
}

However, the error I see is:

    

Caught: groovy.lang.MissingMethodException: No signature of method: com.principal.teamsite.Chapter5.benchmark() 
    is applicable for argument types: (java.lang.Integer, com.principal.teamsite.Chapter5$_runBenchmark_closure1) values: [10000, 
   com.principal.teamsite.Chapter5$_runBenchmark_closure1@3e97df]
Possible solutions: runBenchmark()
	at com.principal.teamsite.Chapter5.runBenchmark(Chapter5.groovy:14)
	at com.principal.teamsite.StartHere.main(StartHere.groovy:30)

I'm at a loss. I believe I am passing an Integer and a closure.

What am I missing?

Thanks in advance!

Craig

[David Newton]

Unfortunately, you're also declaring methods in essentially random places.

class Chapter5 {
	def benchmark(repeat, Closure worker) {
		def start = System.currentTimeMillis()
		repeat.times{worker(it)}
		def stop = System.currentTimeMillis()
		return stop - start
	}
	
    public void runBenchmark() {
        def slow = benchmark(10000) { (int) it / 2 }
        def fast = benchmark(10000) { it.intdiv(2) }
        
        assert fast * 15 < slow
        println "Slow: $slow"
        println "Fast: $fast"
    }
}

def ch5 = new Chapter5();  
ch5.runBenchmark()

[Craig Treptow]

David Newton wrote:Unfortunately, you're also declaring methods in essentially random places.

class Chapter5 {
	def benchmark(repeat, Closure worker) {
		def start = System.currentTimeMillis()
		repeat.times{worker(it)}
		def stop = System.currentTimeMillis()
		return stop - start
	}
	
    public void runBenchmark() {
        def slow = benchmark(10000) { (int) it / 2 }
        def fast = benchmark(10000) { it.intdiv(2) }
        
        assert fast * 15 < slow
        println "Slow: $slow"
        println "Fast: $fast"
    }
}

def ch5 = new Chapter5();  
ch5.runBenchmark()

Sorry, I'm not following. This is the full content of what I am referring to as the caller:

Aha! I think I see what you mean now.

Caller:

		println 'Chapter5 - BEGIN'
		def ch5 = new Chapter5();
		
		def slow = ch5.benchmark(10000) { (int) it / 2 }
		def fast = ch5.benchmark(10000) { it.intdiv(2) }
		
		assert fast * 15 < slow
		println "Slow: $slow"
		println "Fast: $fast"
		
		println 'END\n'

And the class:

    

class Chapter5 {
	
	public benchmark(repeat, Closure worker) {
		def start = System.currentTimeMillis()
		repeat.times{worker(it)}
		def stop = System.currentTimeMillis()
		return stop - start
	}
}

Success!

Thanks for making me step away and take another look!

Craig

[David Newton]

And what I'm saying is that your Chapter5 class is wrong, and the code I posted above isn't. The calling code isn't relevant.