Convert 1d array to 2D boolean

[Nattakan Lukkanapinit]

I have a set of String and would like to convert to 2d array of boolean
I have an error at line 38 and 32.
This is my String

  public class test
{
   public static void main(String[] args)
   {
     int MAX_HEIGHT = 30;
     int MAX_WIDTH = 65;
     String[] str_data = 
     { 
           "                                      ",
           "                                      ",
           "                                      ",
           "* * * * * * * * * * * * * * * * *     ",
           "*                                *    ",
           "**** * ****** ** ****** *** ****      ",
           "* ********************************    ",
           "*    *   *  * *  *   *  *   *  *      ",
           "* **    *      *   **    *       *    ",
           "****** ** *** **  ***** * * *         ",
           "* ***  ****    * *  **        ** *    ",
           "* * *   * **   *  *** *   *  * **     ",
           "**********************************    "
        };
     
     boolean image_data[][] = new boolean[MAX_HEIGHT][MAX_WIDTH];
     for (int x=0;x<MAX_HEIGHT;x++)
     {
        for (int y=0;y<MAX_WIDTH;y++)
        {
           image_data[x][y] = false;
        }
     }
      for (int z=0;z < str_data[z].length();z++)
      {
         for (int x=0;x<MAX_HEIGHT;x++)
         {
            for (int y=0;y<MAX_WIDTH;y++)
            {
               char a = str_data[z].charAt(z);
               if ( a == '*')
               {
                  image_data[x][y] = true;
               }
               else
               {
                  image_data[x][y] = false;
               }
            }
         }
      }
      for (int x=0;x<MAX_HEIGHT;x++)
      {
         for (int y=0;y<MAX_WIDTH;y++)
         {
            System.out.println(image_data[x][y]);
         }
      }
   }
}

   

[Jeanne Boyarsky]

Nattakan Lukkanapinit wrote:I have an error at line 38 and 32.

What is the error?

[Nattakan Lukkanapinit]

Jeanne Boyarsky wrote:

Nattakan Lukkanapinit wrote:I have an error at line 38 and 32.

What is the error?

Exception in thread "main" java.lang.ArrayIndexOutOfBoundsException: 13
at test.main(test.java:34)

[Sunil Kumar]

You have quiet a few problems here
Line 32 : You are iterating on the string array(of length 13) using the length of corresponding element of the array(38). Clearly, when you reach at 13 on str_data[z], it will throw ArrayIndexOutOfBounds
You can fix the above by using str_data.length, but your code piece wouldnt return the desired results. You need to work more on it. I wouldnt want to mention the problems until you give it a try.

[Nattakan Lukkanapinit]

Sunil Kumar wrote:You have quiet a few problems here
Line 32 : You are iterating on the string array(of length 13) using the length of corresponding element of the array(38). Clearly, when you reach at 13 on str_data[z], it will throw ArrayIndexOutOfBounds
You can fix the above by using str_data.length, but your code piece wouldnt return the desired results. You need to work more on it. I wouldnt want to mention the problems until you give it a try.

thanks for everyone who help me.
ok i fixed all the problem and the program can run without error

 public class test
{
   public static void main(String[] args)
   {
     int MAX_HEIGHT = 30;
     int MAX_WIDTH = 65;
     String[] str_data = 
     { 
          
           "                                      ",
           "                                      ",
           "                                      ",
           "* * * * * * * * * * * * * * * * *     ",
           "*                                *    ",
           "**** * ****** ** ****** *** ****      ",
           "* ********************************    ",
           "*    *   *  * *  *   *  *   *  *      ",
           "* **    *      *   **    *       *    ",
           "****** ** *** **  ***** * * *         ",
           "* ***  ****    * *  **        ** *    ",
           "* * *   * **   *  *** *   *  * **     ",
           "**********************************    "
        };
     boolean image_data[][] = new boolean[MAX_HEIGHT][MAX_WIDTH];
     for (int x=0;x<MAX_HEIGHT;x++)
     {
        for (int y=0;y<MAX_WIDTH;y++)
        {
           image_data[x][y] = false;
        }
     }
     
     int row = 0;
     int col = 0;
     int BotRight = MAX_HEIGHT - str_data.length;
     for (int s=0; s >< str_data.length;s++)
     {

        for (int z=0; z < str_data[s].length();z++)
        {
           if ( str_data[row].charAt(col) == ' ')
           {
              image_data[BotRight+row][col] = false;
              col++;
           }
           else if ( str_data[row].charAt(col) == '*')
           {
              image_data[BotRight+row][col] = true;
              col++;
           }
        }
        row++;
        col=0;
     }
     
     
      System.out.println(image_data[0][0]);
      System.out.println(image_data[1][0]);
      System.out.println(image_data[9][0]);
      System.out.println();
      System.out.println();

      for ( row = 0; row < image_data.length; row++)
      {
         for ( col = 0; col < image_data[row].length; col ++)
         {
            
            if (image_data[row][col] == true)
            {
            System.out.print("*");
            }
            else
               System.out.print(" ");
         
         }
         System.out.println("|");
      }
   }
}   

this is output of my test program just in main

                                                                   |
                                                                 |
                                                                 |
                                                                 |
                                                                 |
                                                                 |
                                                                 |
                                                                 |
                                                                 |
                                                                 |
                                                                 |
                                                                 |
                                                                 |
                                                                 |
                                                                 |
                                                                 |
                                                                 |
                                                                 |
                                                                 |
                                                                 |
* * * * * * * * * * * * * * * * *                                |
*                                *                               |
**** * ****** ** ****** *** ****                                 |
* ********************************                               |
*    *   *  * *  *   *  *   *  *                                 |
* **    *      *   **    *       *                               |
****** ** *** **  ***** * * *                                    |
* ***  ****    * *  **        ** *                               |
* * *   * **   *  *** *   *  * **                                |
**********************************                               |