problem with action

[Davie Lin]

I have a button like

<h:commandButton id="delete"
													 value="Delete" 
													 immediate="true"
													 onclick="confirm('Are you sure about deleting this record')"
													 action="#{MyBean.delete}" >    

I just notice that when I click "Cancel" from the Confirm() JavaScript dialog window, my action still got fired so it deleted my record even if I click "cancel"

what should I do?

[Davie Lin]

problem solved

  onclick= return confirm('Are you sure about deleting this record')  

Thanks to Eric on the JS forum

[Tim Holloway]

Yep. DEFINITELY don't forget the "return"!