Feedback request on jsp / struts code

[Billy Vandory]

Here's some code I wrote, can I get some feedback. I dont like the fact struts 2 is being mixed with html and css. Any ideas on how to tighten this up? Note that the site is really CSS intensive and the client wants it to look a certain way without exception. Thanks alot.

 
      <div id="leftcol" class="col">
		<ul>
			<s:iterator var="group" value="groups">
				<div class="caticon">
					<img class="caticon" src="icon.gif" /> 
					<a href=""> 
						<span class="cattext"> 
							<s:property value="#group.name" /> 
						</span> 
					</a>
				</div>

				<s:iterator var="category" value="#group.categories">
					<li>
						<a href="a">
							<s:property value="#category.name" /> 
						</a>
					</li>
				</s:iterator>
			</s:iterator>
		</ul>
	</div>  
 

[Ankit Garg]

I don't see any problems with putting struts tags inside of the HTML apart from the fact that you are generating div tags inside of an unordered list which is not a good thing...

[Billy Vandory]

Ankit Garg wrote:I don't see any problems with putting struts tags inside of the HTML apart from the fact that you are generating div tags inside of an unordered list which is not a good thing...

Thanks Ankit, can you tell me why that is bad, or an alternative? Can I use span?

[David Newton]

It's bad because it's not valid HTML. The alternative would be to make it valid, like by putting the stuff you're trying to put in a misplaced DIV into an LI of the appropriate class.

And what do you mean by you don't like that "S2 is being mixed with HTML and CSS"? That's what a JSP page is--a template used to generate (usually) HTML, with custom tags being used to perform various non-HTML type things.