spring AOP doesn't work

[Samanthi perera]

Edited to correct spelling of AOP in subject. Proofreading the subject, at least, is a good idea.

this is my Audiance.java class

package com.aruna;

public class Audience {

	public Audience() {
	}

	public void takeSeats() {
		System.out.println("The audience is taking their seats.");
	}

	public void turnOffCellPhones() {
		System.out.println("The audience is turning off " + "their cellphones");
	}

	public void applaud() {
		System.out.println("CLAP CLAP CLAP CLAP CLAP");
	}

	public void demandRefund() {
		System.out.println("Boo! We want our money back!");
	}

}

this is my AudianceAdvice.java class

package com.aruna;

import java.lang.reflect.Method;

import org.springframework.aop.AfterReturningAdvice;
import org.springframework.aop.MethodBeforeAdvice;
import org.springframework.aop.ThrowsAdvice;

public class AudienceAdvice implements MethodBeforeAdvice,
		AfterReturningAdvice, ThrowsAdvice {

	public AudienceAdvice() {
	}

	public void before(Method method, Object[] args, Object target)
			throws Throwable {
		audience.takeSeats();
		audience.turnOffCellPhones();
	}

	public void afterReturning(Object returnValue, Method method,
			Object[] args, Object target) throws Throwable {
		audience.applaud();
	}

	public void afterThrowing(Throwable throwable) {
		audience.demandRefund();
	}

	private Audience audience;

	public void setAudience(Audience audience) {
		this.audience = audience;
	}

}

this is main.xml class
code]
<?xml version="1.0" encoding="UTF-8"?>
<beans xmlns="http://www.springframework.org/schema/beans"
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:schemaLocation="http://www.springframework.org/schema/beans
http://www.springframework.org/schema/beans/spring-beans-2.0.xsd">

<bean id="FoodService" class="com.aruna.Dog">
<property name="food" value="Chickenn" />
</bean>

<bean id="audiance" class="com.aruna.Audience"></bean>

<bean id="audienceAdvice" class="com.aruna.AudienceAdvice">
<property name="audience" ref="audience" />
</bean>

<bean id="performancePointcut" class="org.springframework.aop.support.JdkRegexpMethodPointcut">
<property name="pattern" value=".*perform" />
</bean>

<bean id="audienceAdvisor" class="org.springframework.aop.support.DefaultPointcutAdvisor">
<property name="advice" ref="audienceAdvice" />
<property name="pointcut" ref="performancePointcut" />
</bean>

</beans>[/code]

this is main class

package com.aruna;

import org.springframework.beans.factory.BeanFactory;
import org.springframework.beans.factory.xml.XmlBeanFactory;
import org.springframework.core.io.FileSystemResource;

public class MyApp {

	public static void main(String[] args) throws Exception {
		BeanFactory factory =new XmlBeanFactory(new FileSystemResource("main.xml"));
		Audience greetingService =(Audience) factory.getBean("audiance");
		greetingService.applaud();
		}
	
}

but it gives me only
CLAP CLAP CLAP CLAP CLAP as a output.
why the AOP doesn't working??

[David Newton]

Because the regex "*.perform" appears nowhere but in your regex?

[Samanthi perera]

I don't understand what are you saying.Can you explaing little bit more?
Actually i am new to Spring AOP .I am try to run this example.
can you please tell me the error ?

[David Newton]

<bean id="performancePointcut" class="org.springframework.aop.support.JdkRegexpMethodPointcut"> 
    <property name="pattern" value=".*perform" /> 
</bean> 

What does the "pattern" property mean in a JdkRegexpMethodPointcut?

[Samanthi perera]

ok
which class i need to include perform method?

[Samanthi perera]

I change my classes.
now main class is here

package com.aruna;

import org.springframework.beans.factory.BeanFactory;
import org.springframework.beans.factory.xml.XmlBeanFactory;
import org.springframework.core.io.FileSystemResource;

public class MyApp {

	public static void main(String[] args) throws Exception {
		BeanFactory factory =new XmlBeanFactory(new FileSystemResource("main.xml"));
		Performer performer = (Performer) factory.getBean("duke");
		performer.perform();
		}
	
}

main.xml is here

<?xml version="1.0" encoding="UTF-8"?>
<beans xmlns="http://www.springframework.org/schema/beans"
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:schemaLocation="http://www.springframework.org/schema/beans
http://www.springframework.org/schema/beans/spring-beans-2.0.xsd">

<bean id="FoodService" class="com.aruna.Dog">
<property name="food" value="Chickenn" />
</bean>

<bean id="duke" class="com.aruna.Juggler" />

<bean id="audiance" class="com.aruna.Audience"></bean>

<bean id="audienceAdvice" class="com.aruna.AudienceAdvice">
<property name="audience" ref="audience" />
</bean>

<bean id="performancePointcut" class="org.springframework.aop.support.JdkRegexpMethodPointcut">
<property name="pattern" value=".*perform" />
</bean>

<bean id="audienceAdvisor" class="org.springframework.aop.support.DefaultPointcutAdvisor">
<property name="advice" ref="audienceAdvice" />
<property name="pointcut" ref="performancePointcut" />
</bean>

</beans>

juggler class here

package com.aruna;

public class Juggler implements Performer{
	
	private int beanBags = 3;

	public Juggler() {
	}

	public Juggler(int beanBags) {
		this.beanBags = beanBags;
	}

	public void perform(){
		System.out.println("JUGGLING " + beanBags + " BEANBAGS");
	}

}

Audience class here

package com.aruna;

public class Audience {

	public Audience() {
	}

	public void takeSeats() {
		System.out.println("The audience is taking their seats.");
	}

	public void turnOffCellPhones() {
		System.out.println("The audience is turning off " + "their cellphones");
	}

	public void applaud() {
		System.out.println("CLAP CLAP CLAP CLAP CLAP");
	}

	public void demandRefund() {
		System.out.println("Boo! We want our money back!");
	}

}

AudienceAdvice is here

package com.aruna;

import java.lang.reflect.Method;

import org.springframework.aop.AfterReturningAdvice;
import org.springframework.aop.MethodBeforeAdvice;
import org.springframework.aop.ThrowsAdvice;

public class AudienceAdvice implements MethodBeforeAdvice,
		AfterReturningAdvice, ThrowsAdvice {

	public AudienceAdvice() {
	}

	public void before(Method method, Object[] args, Object target)
			throws Throwable {
		audience.takeSeats();
		audience.turnOffCellPhones();
	}

	public void afterReturning(Object returnValue, Method method,
			Object[] args, Object target) throws Throwable {
		audience.applaud();
	}

	public void afterThrowing(Throwable throwable) {
		audience.demandRefund();
	}

	private Audience audience;

	public void setAudience(Audience audience) {
		this.audience = audience;
	}

}

now when i run main class it just gives
JUGGLING 3 BEANBAGS
why still not running AOP ?

[David Newton]

I think you're focusing too narrowly here: take a step back. What's the difference between what you're doing and what the configuration you're using is doing? Can you think of a way to make it work without adding a method matching ".*perform"? Or, if you're dead-set on using that regex, where do *you* think you'd need to add a method ending with "perform"?

[Samanthi perera]

I change the classes as above.Still No good results.

[David Newton]

Please, *please* try to work through what's happening here.

Answer these questions (here, in the forum):

- What are you attempting to use AOP on?
- What objects do you instantiate?
- What methods do you call on which objects?