refresh table doesn't work

[Lia Mihaela]

i have a table wich extends DefaultTableModel
I made a button "Salveaza produs" for add new data,

 b1 = new JButton("Salveaza produs");
		pane.add(b1, c);
		b1.addActionListener(new ActionListener() {

			public void actionPerformed(ActionEvent e) {
				PreparedStatement ps = null;
				conectare_baza cb = new conectare_baza();
				cb.conectare();
				StocIntrari st = new StocIntrari();

				try {
					String qry = "INSERT INTO produse ([Denumire categorie],[Denumire produs], "
							+ "Ambalare, UM, Intrari,[Pret achizitie]) VALUES (?,?,?,?,?,?)";
					ps = cb.con.prepareStatement(qry);
					ps.setString(1, (String) lista.getSelectedItem());
					ps.setString(2, tl2.getText());
					ps.setString(3, tl3.getText());
					ps.setString(4, tl4.getText());
					ps.setDouble(5, Double.parseDouble(tl5.getText()));
					ps.setDouble(6, Double.parseDouble(tl6.getText()));
					
					int i = ps.executeUpdate();
					
					st.mtm.addRow(new Object[] { lista.getSelectedItem(),
							tl2.getText(), tl3.getText(), tl4.getText(),
							tl5.getText(), tl6.getText() });
					
					if (i != 0) {
						System.out.println(" ok");
					} else {
						System.out.println("failed to insert data");
					}
				} catch (Exception e1) {
					
				}
				try {
					if (ps != null)
						ps.close();

					if (cb.con != null)
						cb.con.close();
				} catch (SQLException e1) {
									}
			}
		});   

and a button "Refresh" for refresh table,

  bref = new JButton("Refresh");
		pane.add(bref, c);
		bref.addActionListener(new ActionListener() {

			public void actionPerformed(ActionEvent e) {

				try {
					conectare_baza cb1 = new conectare_baza();
					cb1.conectare();
					PreparedStatement ps;
					ResultSet rs;
					ps = cb1.con
							.prepareStatement("SELECT  [Denumire categorie],[Denumire produs],"
									+ "Ambalare, UM, Intrari, [Pret achizitie],Valoare  from produse");

					ps.executeQuery();
					ps.close();
					cb1.con.close();
				} catch (Exception e1) {
					e1.printStackTrace();

				}

				try {

					StocIntrari st = new StocIntrari();
					String col1 = (String) ProdusNou.lista.getSelectedItem();
					String col2 = ProdusNou.tl2.getText();
					String col3 = ProdusNou.tl3.getText();
					String col4 = ProdusNou.tl4.getText();
					String col5 = ProdusNou.tl5.getText();
					String col6 = ProdusNou.tl6.getText();
					double col7 = Double.parseDouble(col5)* Double.parseDouble(col6);
					String[] rand = { col1, col2, col3, col4, col5, col6,"" + col7 };
					st.mtm.addRow(rand);
					st.mtm.fireTableDataChanged();
					st.t.repaint();

					ProdusNou.lista.setSelectedItem("");
					ProdusNou.tl2.setText("");
					ProdusNou.tl3.setText("");
					ProdusNou.tl4.setText("");
					ProdusNou.tl5.setText("");
					ProdusNou.tl6.setText("");

				} catch (Exception e1) {
					e1.printStackTrace();

				}
			}
		});  

but my refresh button doesn't work. my new row doesn't appear in the table

The buttons are in diferent classes. Where did i wrong, how can i refresh my table

[Peter Taucher]

I can only assume that a class called 'conectare_baza' has something to do with JDBC, I don't know for sure, because I don't speak that language. English would seem a perfect choice for naming classes and variables, so that the code becomes more readable for all us out there...

In your ActionListener implementation for the refresh button you execute a query. You close the ResultSet before reading any data. I don't think that is what you intended to do?

[Lia Mihaela]

this is the class conectare_baza

 public class conectare_baza {
	Connection con;
	Statement stm;
	int count = 0;
	static Vector v;

	public conectare_baza() {
	}
	void conectare() {
		try {
			Class.forName("sun.jdbc.odbc.JdbcOdbcDriver");
			con = DriverManager.getConnection("jdbc:odbc:Liuta");
			stm = con.createStatement();

		} catch (Exception e) {
			e.printStackTrace();
		}
	}
	public static void main(String[] args) throws SQLException {
		conectare_baza cb = new conectare_baza();

		if (cb != null)
			System.out.println("Conectat");
		else
			System.out.println("Neconectat");
	}
}   

[Peter Taucher]

Did you read / comprehend my second paragraph? I'm sure you'd wanted to read some fields from the ResultSet before closing it.

[Lia Mihaela]

Yes i read / comprehend your second paragraph. I agree with you, but tell me where can i close it.
I tried to close it after second "try" and still not working please help me

[Peter Taucher]

Here's a small example for using a prepared statement:

    public void actionPerformed( ActionEvent e )
    {
        // Get jdbc connection from somewhere (maybe don't create a connection for each event)
        Connection con = getConnection();
        
        // Get the prepared statement from somewhere (no use in prepared statement, if it's created for each event)
        PreparedStatement ps = getStatement();

        ResultSet rs = null;
        try
        {
            // Set parameters for the prepared statement
            ps.setInt( 1, 4711 );
            ps.setString( 2, "foobar" );
        
            // Execute query
            rs = ps.executeQuery();
            
            // Get data from result set
            String foo = rs.getString( 1 );
            int    bar = rs.getInt( "Column2" );
            Time   far = rs.getTime( 3 );
            
            // Display queried data in GUI
            someGuiComponent.setText( foo );
            someDataModel.addItem( bar );
            // ...
        }
        catch ( SQLException ex )
        {
            // TODO Auto-generated catch block
            ex.printStackTrace();
        }
        finally
        {
            // Always close result set in finally block
            if ( rs != null )
            {
                try
                {
                    rs.close();
                }
                catch ( SQLException ex )
                {
                    // TODO Auto-generated catch block
                    ex.printStackTrace();
                }
            }   
        }
    }

And here's the example with a 'normal' statement (because, you were using PreparedStatement but I think you meant not to):

    public void actionPerformed( ActionEvent e )
    {
        // Get jdbc connection from somewhere (maybe don't create a connection for each event)
        Connection con = getConnection();

        ResultSet rs = null;
        try
        {
            // Create a statement
            Statement stmt = con.createStatement();
        
            // Execute query
            rs = stmt.executeQuery( "SELECT * FROM HEAVEN" );
            
            // Get data from result set
            String foo = rs.getString( 1 );
            int    bar = rs.getInt( "Column2" );
            Time   far = rs.getTime( 3 );
            
            // Display queried data in GUI
            someGuiComponent.setText( foo );
            someDataModel.addItem( bar );
            // ...
        }
        catch ( SQLException ex )
        {
            // TODO Auto-generated catch block
            ex.printStackTrace();
        }
        finally
        {
            // Always close result set in finally block
            if ( rs != null )
            {
                try
                {
                    rs.close();
                }
                catch ( SQLException ex )
                {
                    // TODO Auto-generated catch block
                    ex.printStackTrace();
                }
            }   
        }
    }

You may also look into the JdbcFaq -> http://faq.javaranch.com/java/JdbcUsageQuestions