Win a copy of Learn Spring Security (video course) this week in the Spring forum!
  • Post Reply
  • Bookmark Topic Watch Topic
  • New Topic

Dynamic images in jsp

 
jagmeet singh
Greenhorn
Posts: 6
  • Mark post as helpful
  • send pies
  • Quote
  • Report post to moderator
Hello
I want to dynamically out image. The page queries the database. Code is here


Error: the pictures are not added when the page returns "User Deleted"
 
Bear Bibeault
Author and ninkuma
Marshal
Pie
Posts: 64613
86
IntelliJ IDE Java jQuery Mac Mac OS X
  • Mark post as helpful
  • send pies
  • Quote
  • Report post to moderator
Please be sure to use code tags when posting code to the forums. Unformatted or unindented code is extremely hard to read and many people that might be able to help you will just move along to posts that are easier to read. Please click this link ⇒ UseCodeTags ⇐ for more information.

Properly indented and formatted code greatly increases the probability that your question will get quicker, better answers.
 
jagmeet singh
Greenhorn
Posts: 6
  • Mark post as helpful
  • send pies
  • Quote
  • Report post to moderator
Hi Bear Bibeault
I have edited my topic. Thanks for guidance!


Bear Bibeault wrote:Please be sure to use code tags when posting code to the forums. Unformatted or unindented code is extremely hard to read and many people that might be able to help you will just move along to posts that are easier to read. Please click this link ⇒ UseCodeTags ⇐ for more information.

Properly indented and formatted code greatly increases the probability that your question will get quicker, better answers.
 
Bear Bibeault
Author and ninkuma
Marshal
Pie
Posts: 64613
86
IntelliJ IDE Java jQuery Mac Mac OS X
  • Mark post as helpful
  • send pies
  • Quote
  • Report post to moderator
But you didn't add the code tags. That will preserve the formatting.

Also, why are you still using scriptlets in JSPs? They have been discredited for over 8 years now. You should really be using JSTL and EL by now. And that would make all of this much much easier.
 
jagmeet singh
Greenhorn
Posts: 6
  • Mark post as helpful
  • send pies
  • Quote
  • Report post to moderator
Actually this was a ready made project i am editing. I was persuing OCP training. And in india , thouse scriplets are still being taught.
I have no choice.
I didnt visited the use tag form. now i have. next time i will use these tags.
 
Bear Bibeault
Author and ninkuma
Marshal
Pie
Posts: 64613
86
IntelliJ IDE Java jQuery Mac Mac OS X
  • Mark post as helpful
  • send pies
  • Quote
  • Report post to moderator
Understood. As long as your are aware that this is old technology that should not be used in new code...

Please add code tags as suggested. It will make the code more readable. Also, what is the specific error message that you are getting? Please include it in code tags as well to preserve the formatting.
 
jagmeet singh
Greenhorn
Posts: 6
  • Mark post as helpful
  • send pies
  • Quote
  • Report post to moderator
edited the code with error.
 
David Newton
Author
Rancher
Posts: 12617
IntelliJ IDE Ruby
  • Mark post as helpful
  • send pies
  • Quote
  • Report post to moderator
Look where the quotes are on the fail image tag.
 
Paul Clapham
Sheriff
Pie
Posts: 20719
30
Eclipse IDE Firefox Browser MySQL Database
  • Mark post as helpful
  • send pies
  • Quote
  • Report post to moderator
This may also not be relevant, but using a query which is built from a string is liable to have problems. If the user's name contained an apostrophe (which some people's names do) then the SQL query will be malformed and an exception will be thrown. Building a query that way also exposes your system to SQL injection attacks. A better-designed system wouldn't do that; it would use PreparedStatement objects for queries with parameters.
 
David Newton
Author
Rancher
Posts: 12617
IntelliJ IDE Ruby
  • Mark post as helpful
  • send pies
  • Quote
  • Report post to moderator
See also: Little Bobby Tables.
 
Paul Clapham
Sheriff
Pie
Posts: 20719
30
Eclipse IDE Firefox Browser MySQL Database
  • Mark post as helpful
  • send pies
  • Quote
  • Report post to moderator
David Newton wrote:Look where the quotes are on the fail image tag.


It took me a long time to see that, even when it was pointed out. The quotes are in the wrong place in the success image tag too. That's what you get when you have JSP scriptlets generating HTML; too much quote-escaping, hard to read.
 
Bear Bibeault
Author and ninkuma
Marshal
Pie
Posts: 64613
86
IntelliJ IDE Java jQuery Mac Mac OS X
  • Mark post as helpful
  • send pies
  • Quote
  • Report post to moderator
David Newton wrote:Look where the quotes are on the fail image tag.

Building up HTML inside a Java string, inside a JSP, is pretty much a FAIL in and of itself. The whole purpose of a JSP is so that HTML markup can be entered directly as template text.

You might want to refactor to remove the HTML from strings where silly syntax errors are hard to avoid.
 
David Newton
Author
Rancher
Posts: 12617
IntelliJ IDE Ruby
  • Mark post as helpful
  • send pies
  • Quote
  • Report post to moderator
Bear Bibeault wrote:FAIL
 
jagmeet singh
Greenhorn
Posts: 6
  • Mark post as helpful
  • send pies
  • Quote
  • Report post to moderator
I got it:
1. The code is buggy, prone to sql injections.
2. It's using old tech

But i have no choice guys. Need to submit the project. I will give live demo and through it away.
the code did not worked :banghead: :--

David Newton wrote:
Bear Bibeault wrote:FAIL

 
David Newton
Author
Rancher
Posts: 12617
IntelliJ IDE Ruby
  • Mark post as helpful
  • send pies
  • Quote
  • Report post to moderator
Really? You tried my code?!

In any case: FIX THE QUOTES.
 
jagmeet singh
Greenhorn
Posts: 6
  • Mark post as helpful
  • send pies
  • Quote
  • Report post to moderator

Earlier net beans was not even allowing me to write the same code. Now its working.
Thanks DAVID NEWTON.
 
Paul Clapham
Sheriff
Pie
Posts: 20719
30
Eclipse IDE Firefox Browser MySQL Database
  • Mark post as helpful
  • send pies
  • Quote
  • Report post to moderator
jagmeet singh wrote:Earlier net beans was not even allowing me to write the same code. Now its working.
Thanks DAVID NEWTON.


But now we can add "Generates malformed HTML" to its list of sins. (Although probably it was already doing that too, right?)

To put the attribute value quotes in the right place:

 
  • Post Reply
  • Bookmark Topic Watch Topic
  • New Topic