may you guess where error I get: script: stop/start animation image

[Leonidas Savvides]

may you guess where error I get stop/start animation

 C:\Users\User\Documents\TextBooksDataFiles\RexPractice\JAVA\ZIPs\jhtp7_SSM_ch21solutions\te
st\EXA21-3>javac LogoAnimator.java
LogoAnimator.java:26: illegal start of expression
           public JButton playJButton, loopJButton;
           ^
LogoAnimator.java:27: illegal start of expression
       public JPanel buttonJPanel;
       ^
2 errors

   

  // Fig. 21.3: LogoAnimator.java
// Animation of a series of images.
import javax.swing.JFrame;
 import java.awt.event.ActionListener;
 import java.awt.event.ActionEvent;
 import java.awt.Graphics;
 import javax.swing.ImageIcon;
 import javax.swing.JApplet;
 import javax.swing.JButton;
 import javax.swing.JPanel;
  import java.awt.BorderLayout;
 
 
public class LogoAnimator 
{

   
   public static void main( String args[] )
   {
   

      // execute animation in a JFrame
       LogoAnimatorJPanel animation = new LogoAnimatorJPanel(); 

   	   public JButton playJButton, loopJButton;
       public JPanel buttonJPanel;  
   
/*
C:\Users\User\Documents\TextBooksDataFiles\RexPractice\JAVA\ZIPs\jhtp7_SSM_ch21solutions\te
st\EXA21-3>javac LogoAnimator.java
LogoAnimator.java:26: illegal start of expression
           public JButton playJButton, loopJButton;
           ^
LogoAnimator.java:27: illegal start of expression
       public JPanel buttonJPanel;
       ^
2 errors


*/

      buttonJPanel = new JPanel();


      ButtonHandler handler = new ButtonHandler();
	  
      // create Play JButton
      playJButton = new JButton( "Play" );
      playJButton.addActionListener( handler );
      buttonJPanel.add( playJButton );

      // create Loop JButton
      loopJButton = new JButton( "STOP" );
      loopJButton.addActionListener( handler );
      buttonJPanel.add( loopJButton );	  
	  
	           JFrame window = new JFrame( "Animator test" ); // set up window

      window.setDefaultCloseOperation( JFrame.EXIT_ON_CLOSE );
      window.add( animation, BorderLayout.CENTER ); // add panel to frame
      window.add( buttonJPanel , BorderLayout.SOUTH  );
      window.pack();  // make window just large enough for its GUI
      window.setVisible( true );   // display window

      animation.startAnimation();  // begin animation
   } // end main
   
   public class ButtonHandler implements ActionListener 
   {
      // process play, loop and stop button events
      public void actionPerformed( ActionEvent actionEvent )
      {
         if ( actionEvent.getSource() == playJButton ) 
            animation.startAnimation(); // play AudioClip once
         else if ( actionEvent.getSource() == loopJButton ) 
            animation.stopAnimation(); // play AudioClip continuously
         //else if ( actionEvent.getSource() == stopJButton ) 
           // currentSound.stop(); // stop AudioClip
      } // end method actionPerformed
   } // end class ButtonHandler      
   
} // end class LogoAnimator  

  // Fig. 21.2: LogoAnimatorJPanel.java
// Animation of a series of images.
import java.awt.Dimension;
import java.awt.event.ActionEvent;
import java.awt.event.ActionListener;
import java.awt.Graphics;
import javax.swing.ImageIcon;
import javax.swing.JPanel;
import javax.swing.Timer;

public class LogoAnimatorJPanel extends JPanel 
{
   private final static String IMAGE_NAME = "deitel"; // base image name
   protected ImageIcon images[]; // array of images
   private final int TOTAL_IMAGES = 30;  // number of images
   private int currentImage = 0; // current image index
   private final int ANIMATION_DELAY = 50; // millisecond delay
   private int width; // image width
   private int height; // image height

   private Timer animationTimer; // Timer drives animation

   // constructor initializes LogoAnimatorJPanel by loading images
   public LogoAnimatorJPanel()
   {
      images = new ImageIcon[ TOTAL_IMAGES ];

      // load 30 images
      for ( int count = 0; count < images.length; count++ )
         images[ count ] = new ImageIcon( getClass().getResource(
            "images/" + IMAGE_NAME + count + ".gif" ) );
 
      // this example assumes all images have the same width and height
      width = images[ 0 ].getIconWidth();   // get icon width
      height = images[ 0 ].getIconHeight(); // get icon height
   } // end LogoAnimatorJPanel constructor

   // display current image 
   public void paintComponent( Graphics g )
   {
      super.paintComponent( g ); // call superclass paintComponent

      images[ currentImage ].paintIcon( this, g, 0, 0 );
      
      // set next image to be drawn only if Timer is running
      if ( animationTimer.isRunning() )  
         currentImage = ( currentImage + 1 ) % TOTAL_IMAGES;
   } // end method paintComponent

   // start animation, or restart if window is redisplayed
   public void startAnimation()
   {
      if ( animationTimer == null ) 
      {
         currentImage = 0; // display first image

         // create timer
         animationTimer = 
            new Timer( ANIMATION_DELAY, new TimerHandler() );

         animationTimer.start(); // start Timer
      } // end if
      else // animationTimer already exists, restart animation
      {
         if ( ! animationTimer.isRunning() )
            animationTimer.restart();
      } // end else
   } // end method startAnimation

   // stop animation Timer
   public void stopAnimation()
   {
      animationTimer.stop();
   } // end method stopAnimation

   // return minimum size of animation
   public Dimension getMinimumSize()
   { 
      return getPreferredSize(); 
   } // end method getMinimumSize

   // return preferred size of animation
   public Dimension getPreferredSize()
   {
      return new Dimension( width, height );
   } // end method getPreferredSize

   // inner class to handle action events from Timer
   private class TimerHandler implements ActionListener 
   {
      // respond to Timer's event
      public void actionPerformed( ActionEvent actionEvent )
      {
         repaint(); // repaint animator
      } // end method actionPerformed
   } // end class TimerHandler
   

   
} // end class LogoAnimatorJPanel  

[Hunter McMillen]

I don't think you are allowed to have access modifiers inside the main method. I am not completely sure about that. But I just did a small test:

    
public class TestAccess
{
	public static void main(String[] args)
	{
		public int FIVE = 5;
		private int SIX = 6;
		protected int SEVEN = 7;
	}
}

And got these compile errors:
TestPublic.java:5: illegal start of expression
public int FIVE = 5;
^
TestPublic.java:6: illegal start of expression
private int SIX = 6;
^
TestPublic.java:7: illegal start of expression
protected int SEVEN = 7;


Based off that id say the access modifiers are a no-no in the main method.

Hunter

[fred rosenberger]

My guess is you don't want that 'public' before you declare those method variables. Or, you want to move the declaration outside of the main() method.

[Campbell Ritchie]

As well as public private and protected being prohibited inside methods, why are you not marking all your fields private?

[Leonidas Savvides]

I post a new ver here: http://www.coderanch.com/t/503190/java/java/well-did-as-below-but

but I get no errors[run or compile] but no appear the stop/start buttons ONLY the ani img well?