getter not running

[Antony Amicone]

my class Recipes has a getter to take various data, in a window i create an instance of Recipes and i try to get the "name", but if i create the file with those value, there is no value. the file is created, but empty

  /*
 * To change this template, choose Tools | Templates
 * and open the template in the editor.
 */

package desktopapplication1;

/**
 *
 * @author Antonio
 */
public class Recipes {
private String recipeName = "";
private String recipeHowTo = "";
private String ingredients[];
private int servings;
private int level;
private int timeToEat;
private String imgPath = "";

public Recipes(String a,String a1,String[] a2,int a3, int a4, int a5){
    recipeName = a;
    recipeHowTo = a1;
    ingredients = a2;
    servings = a3;
    level = a4;
    timeToEat = a5;
}

public String getRecipeName(){
    return recipeName;
}

public void setRecipeName(String x){
    recipeName = x;
}

public String getRecipeHowTo(){
    return recipeHowTo;
}

public void setRecipeHowTo(String x){
    recipeHowTo = x;
}

public String[] getIngredients(){
    return ingredients;
}

public void setIngredients(String[] x){
    ingredients = x;
}

public int getServings(){
    return servings;
}

public void setServings(int x){
    servings = x;
}

public int getLevel(){
    return level;
}

public void setLevel(int x){
    level = x;
}

public int getTimeToEat(){
    return timeToEat;
}

public void setTimeToEat(int x){
    timeToEat = x;
}

}
  

  /*
 * To change this template, choose Tools | Templates
 * and open the template in the editor.
 */

/*
 * NewJDialog.java
 *
 * Created on 15-lug-2010, 22.42.35
 */

package desktopapplication1;

import java.awt.event.*;
import javax.swing.*;
import java.io.*;

/**
 *
 * @author Antonio
 */
public class NewJDialog extends javax.swing.JDialog {

    /** Creates new form NewJDialog */
    public NewJDialog(java.awt.Frame parent, boolean modal) {
        super(parent, modal);
        initComponents();
    }
    public NewJDialog(String recipeName1,int level1,int servings1,int timeToEat1,String dish1) {
        recipeName = recipeName1;
        level = level1;
        servings = servings1;
        timeToEat = timeToEat1;
        dish = dish1;
    }
    /** This method is called from within the constructor to
     * initialize the form.
     * WARNING: Do NOT modify this code. The content of this method is
     * always regenerated by the Form Editor.
     */
    @SuppressWarnings("unchecked")
    // <editor-fold defaultstate="collapsed" desc="Generated Code">
    private void initComponents() {

        jScrollPane1 = new javax.swing.JScrollPane();
        jTextArea1 = new javax.swing.JTextArea();
        jScrollPane2 = new javax.swing.JScrollPane();
        jList1 = new javax.swing.JList();
        jButton1 = new javax.swing.JButton();
        jButton2_add = new javax.swing.JButton();
        jButton3_rem = new javax.swing.JButton();

        setDefaultCloseOperation(javax.swing.WindowConstants.DISPOSE_ON_CLOSE);
        setName("Form"); // NOI18N

        jScrollPane1.setName("jScrollPane1"); // NOI18N

        jTextArea1.setColumns(20);
        jTextArea1.setRows(5);
        org.jdesktop.application.ResourceMap resourceMap = org.jdesktop.application.Application.getInstance(
               desktopapplication1.DesktopApplication1.class).getContext().getResourceMap(NewJDialog.class);
        jTextArea1.setText(resourceMap.getString("jTextArea1.text")); // NOI18N
        jTextArea1.setName("jTextArea1"); // NOI18N
        jScrollPane1.setViewportView(jTextArea1);

        jScrollPane2.setName("jScrollPane2"); // NOI18N

        jList1.setModel(dlm);
        jList1.setName("jList1"); // NOI18N
        jScrollPane2.setViewportView(jList1);

        jButton1.setText(resourceMap.getString("jButton1.text")); // NOI18N
        jButton1.setName("jButton1"); // NOI18N
        jButton1.addActionListener(new java.awt.event.ActionListener() {
            public void actionPerformed(java.awt.event.ActionEvent evt) {
                jButton1ActionPerformed(evt);
            }
        });

        jButton2_add.setText(resourceMap.getString("jButton2_add.text")); // NOI18N
        jButton2_add.setName("jButton2_add"); // NOI18N
        jButton2_add.addActionListener(new java.awt.event.ActionListener() {
            public void actionPerformed(java.awt.event.ActionEvent evt) {
                jButton2_addActionPerformed(evt);
            }
        });

        jButton3_rem.setText(resourceMap.getString("jButton3_rem.text")); // NOI18N
        jButton3_rem.setName("jButton3_rem"); // NOI18N
        jButton3_rem.addActionListener(new java.awt.event.ActionListener() {
            public void actionPerformed(java.awt.event.ActionEvent evt) {
                jButton3_remActionPerformed(evt);
            }
        });

        javax.swing.GroupLayout layout = new javax.swing.GroupLayout(getContentPane());
        getContentPane().setLayout(layout);
        layout.setHorizontalGroup(
            layout.createParallelGroup(javax.swing.GroupLayout.Alignment.LEADING)
            .addGroup(layout.createSequentialGroup()
                .addContainerGap()
                .addComponent(jScrollPane1, javax.swing.GroupLayout.PREFERRED_SIZE, 345, javax.swing.GroupLayout.PREFERRED_SIZE)
                .addPreferredGap(javax.swing.LayoutStyle.ComponentPlacement.UNRELATED)
                .addGroup(layout.createParallelGroup(javax.swing.GroupLayout.Alignment.LEADING)
                    .addComponent(jScrollPane2, javax.swing.GroupLayout.DEFAULT_SIZE, 99, Short.MAX_VALUE)
                    .addComponent(jButton1, javax.swing.GroupLayout.DEFAULT_SIZE, 99, Short.MAX_VALUE)
                    .addComponent(jButton3_rem, javax.swing.GroupLayout.DEFAULT_SIZE, 99, Short.MAX_VALUE)
                    .addComponent(jButton2_add, javax.swing.GroupLayout.DEFAULT_SIZE, 99, Short.MAX_VALUE))
                .addContainerGap())
        );
        layout.setVerticalGroup(
            layout.createParallelGroup(javax.swing.GroupLayout.Alignment.LEADING)
            .addGroup(layout.createSequentialGroup()
                .addContainerGap()
                .addGroup(layout.createParallelGroup(javax.swing.GroupLayout.Alignment.LEADING)
                    .addGroup(javax.swing.GroupLayout.Alignment.TRAILING, layout.createSequentialGroup()
                        .addComponent(jScrollPane2, javax.swing.GroupLayout.PREFERRED_SIZE, 143, javax.swing.GroupLayout.PREFERRED_SIZE)
                        .addPreferredGap(javax.swing.LayoutStyle.ComponentPlacement.RELATED)
                        .addComponent(jButton2_add, javax.swing.GroupLayout.PREFERRED_SIZE, 23, javax.swing.GroupLayout.PREFERRED_SIZE)
                        .addPreferredGap(javax.swing.LayoutStyle.ComponentPlacement.RELATED)
                        .addComponent(jButton3_rem)
                        .addPreferredGap(javax.swing.LayoutStyle.ComponentPlacement.RELATED, 54, Short.MAX_VALUE)
                        .addComponent(jButton1))
                    .addComponent(jScrollPane1, javax.swing.GroupLayout.DEFAULT_SIZE, 278, Short.MAX_VALUE))
                .addContainerGap())
        );

        pack();
    }// </editor-fold>

    private void jButton2_addActionPerformed(java.awt.event.ActionEvent evt) {
        // TODO add your handling code here:
         ingredient = JOptionPane.showInputDialog("Insert the name of the ingredient","");
         Object[] possibilities = {"gr","lt","oz","tablespoon","glass","liquid ounces","few"};
         String x = (String)JOptionPane.showInputDialog(rootPane, "Chose the measure unit" , "",JOptionPane.PLAIN_MESSAGE,null,possibilities,"gr");
         grouncesValue = Double.parseDouble(JOptionPane.showInputDialog("Insert the value in "+x,"use the . for decimal"));
         String xx = "";
         if ( x.equalsIgnoreCase("oz")) {
             xx = grouncesValue*28.35+"";
             xx.substring(0,xx.indexOf(".")+2 );
             x = grouncesValue+"oz "+xx+"gr";
         }
         else if ( x.equalsIgnoreCase("gr")) {
             xx = grouncesValue/28.35+"";
             xx = xx.substring(0,xx.indexOf(".")+2 );
             x = xx+"oz "+grouncesValue+"gr";
         }
         else if ( x.equalsIgnoreCase("lt")) {
             xx = grouncesValue+33.81+"";
             xx = xx.substring(0,xx.indexOf(".")+2 );
             x = xx+"oz "+grouncesValue+"lt";
         }
         else if ( x.equalsIgnoreCase("tablespoon")) { x = grouncesValue+"tablespoon"; }
         else if ( x.equalsIgnoreCase("glass")) { x = grouncesValue+"glass"; }
         else if ( x.equalsIgnoreCase("liquid ounces")) { 
             xx = grouncesValue/33.81+"";
             xx = xx.substring(0,xx.indexOf(".")+2 );
             x = grouncesValue+"oz "+xx+"lt";
         }
         else if ( x.equalsIgnoreCase("few")) { x = grouncesValue+"few"; }
         int pos = jList1.getModel().getSize();
         ingredient = ingredient.concat(" "+x);
         dlm.add(pos, ingredient);
    }

    private void jButton3_remActionPerformed(java.awt.event.ActionEvent evt) {
        // TODO add your handling code here:
         dlm.remove(jList1.getSelectedIndex());
    }

    private void jButton1ActionPerformed(java.awt.event.ActionEvent evt) {
        // TODO add your handling code here:
        try{
           [b] r = new Recipes(recipeName,recipeHowTo,ingredients,level,servings,timeToEat);

            File f = new File("c:\\ricetta.rcp");
            BufferedWriter ff = new BufferedWriter(new FileWriter(f));
            System.out.println(r.getRecipeName());// HERE I STAMP
            ff.write(r.getRecipeName());
            ff.write(r.getRecipeHowTo());
            int c = 0;
            String rr[] = r.getIngredients();
            while (c<=r.getIngredients().length) {
            ff.write(rr[c]);
            }
            ff.close();[/b]
        }catch(Exception e){

        }
    }

    /**
    * @param args the command line arguments
    */
    public static void main(String args[]) {
        java.awt.EventQueue.invokeLater(new Runnable() {
            public void run() {
                NewJDialog dialog = new NewJDialog(new javax.swing.JFrame(), true);
                dialog.addWindowListener(new java.awt.event.WindowAdapter() {
                    public void windowClosing(java.awt.event.WindowEvent e) {
                        System.exit(0);
                    }
                });
                dialog.setVisible(true);
            }
        });
    }

    // Variables declaration - do not modify
    private javax.swing.JButton jButton1;
    private javax.swing.JButton jButton2_add;
    private javax.swing.JButton jButton3_rem;
    private javax.swing.JList jList1;
    private javax.swing.JScrollPane jScrollPane1;
    private javax.swing.JScrollPane jScrollPane2;
    private javax.swing.JTextArea jTextArea1;
    // End of variables declaration

    private String recipeHowTo;
    private String ingredients[];
    private String ingredient;
    private String recipeName,dish,image;
    private int level,servings,timeToEat;
    private double grouncesValue;


    private Recipes r;


    DefaultListModel dlm = new DefaultListModel();
    

    public String getHowTo(){
        recipeHowTo = jTextArea1.getText();
        return recipeHowTo;
    }
    /*public String ingredients(){

        return ingredients;
    }*/

}

  

[Ernest Friedman-Hill]

When a recipe is created, the recipeName passed to the constructor comes from the member variable recipeName in NewJDialog. I don't see where anything ever sets that value to a non-empty String. the NewJDialog class has a constructor that accepts a recipeName argument, but (1) nothing ever calls it, and (2) the constructor ignores the arguments anyway. Therefore the Recipe is created with "" as a recipeName, and that's what you get back when you call getRecipeName().

Where do you expect the name to be coming from?

[deepak kushwaha]

private String ingredients[]; <<isnt this giving you an error!!!how can you
make a String of an object !!!

[Antony Amicone]

Ernest Friedman-Hill wrote:When a recipe is created, the recipeName passed to the constructor comes from the member variable recipeName in NewJDialog. I don't see where anything ever sets that value to a non-empty String. the NewJDialog class has a constructor that accepts a recipeName argument, but (1) nothing ever calls it, and (2) the constructor ignores the arguments anyway. Therefore the Recipe is created with "" as a recipeName, and that's what you get back when you call getRecipeName().

Where do you expect the name to be coming from?

i forgot to add :P i added now but the file created is empty

[Antony Amicone]

deepak kushwaha wrote:private String ingredients[]; <<isnt this giving you an error!!!how can you
make a String of an object !!!

is a simple string array

[Ernest Friedman-Hill]

deepak kushwaha wrote:private String ingredients[]; <<isnt this giving you an error!!!how can you
make a String of an object !!!

This is a perfectly valid declaration for a variable that holds an array of Strings. You can write it as either

private String[] ingredients;

or

private String ingredients[];

Both mean exactly the same thing.

[Antony Amicone]

yes i have no error now, but the file i try to create, is created but empty

[Ernest Friedman-Hill]

Well, as I said, the recipeName is never getting set to a non-empty value; the same holds for the other members, I would guess.

[Antony Amicone]

Ernest Friedman-Hill wrote:Well, as I said, the recipeName is never getting set to a non-empty value; the same holds for the other members, I would guess.

no read again, i fixed that,

before to create the file i made a print of value to put in file, and the value are ok, but the file is the same empty

[Ernest Friedman-Hill]

Well, there's an empty catch block in the "try" around the file writing code. That means if something fails, you won't hear about it. Empty catch blocks are murderous evil -- always at least include a printStackTrace() so you can see what happened! Add this, and see if you get an error message.

[Antony Amicone]

solved that thing

now i get this error while working on some number value

     private void jButton2_addActionPerformed(java.awt.event.ActionEvent evt) {
        // TODO add your handling code here:
         ingredient = JOptionPane.showInputDialog("Insert the name of the ingredient","");
         Object[] possibilities = {"gr","lt","oz","tablespoon","glass","liquid ounces","few"};
         String x = (String)JOptionPane.showInputDialog(rootPane, "Chose the measure unit" , "",JOptionPane.PLAIN_MESSAGE,null,possibilities,"gr");
         grouncesValue = Double.parseDouble(JOptionPane.showInputDialog("Insert the value in "+x,"use the . for decimal"));
         String xx = "";
         if ( x.equalsIgnoreCase("oz")) {
             xx = grouncesValue*28.35+"";
             xx.substring(0,xx.indexOf(".")+2 );
             x = grouncesValue+"oz "+xx+"gr";
         }
         else if ( x.equalsIgnoreCase("gr")) {
             xx = grouncesValue/28.35+"";
             xx = xx.substring(0,xx.indexOf(".")+2 );
             x = xx+"oz "+grouncesValue+"gr";
         }
         else if ( x.equalsIgnoreCase("lt")) {
             xx = grouncesValue+33.81+"";
             xx = xx.substring(0,xx.indexOf(".")+2 );
             x = xx+"oz "+grouncesValue+"lt";
         }
         else if ( x.equalsIgnoreCase("tablespoon")) { x = grouncesValue+"tablespoon"; }
         else if ( x.equalsIgnoreCase("glass")) { x = grouncesValue+"glass"; }
         else if ( x.equalsIgnoreCase("liquid ounces")) { 
             xx = grouncesValue/33.81+"";
             xx = xx.substring(0,xx.indexOf(".")+2 );
             x = grouncesValue+"oz "+xx+"lt";
         }
         else if ( x.equalsIgnoreCase("few")) { x = grouncesValue+"few"; }
         int pos = jList1.getModel().getSize();
         ingredient = ingredient.concat(" "+x);
         dlm.add(pos, ingredient);
         int c = 0;
         while ( c <= jList1.getModel().getSize() ) {
             System.out.println(jList1.getModel().getElementAt(c));
             c++;
         }
}   

Exception in thread "AWT-EventQueue-0" java.lang.ArrayIndexOutOfBoundsException: 1 >= 1
at java.util.Vector.elementAt(Vector.java:427)
at javax.swing.DefaultListModel.getElementAt(DefaultListModel.java:70)
at desktopapplication1.NewJDialog.jButton2_addActionPerformed(NewJDialog.java:168)
at desktopapplication1.NewJDialog.access$100(NewJDialog.java:22)
at desktopapplication1.NewJDialog$2.actionPerformed(NewJDialog.java:86)
at javax.swing.AbstractButton.fireActionPerformed(AbstractButton.java:1995)
at javax.swing.AbstractButton$Handler.actionPerformed(AbstractButton.java:2318)
at javax.swing.DefaultButtonModel.fireActionPerformed(DefaultButtonModel.java:387)
at javax.swing.DefaultButtonModel.setPressed(DefaultButtonModel.java:242)
at javax.swing.plaf.basic.BasicButtonListener.mouseReleased(BasicButtonListener.java:236)
at java.awt.Component.processMouseEvent(Component.java:6263)
at javax.swing.JComponent.processMouseEvent(JComponent.java:3267)
at java.awt.Component.processEvent(Component.java:6028)
at java.awt.Container.processEvent(Container.java:2041)
at java.awt.Component.dispatchEventImpl(Component.java:4630)
at java.awt.Container.dispatchEventImpl(Container.java:2099)
at java.awt.Component.dispatchEvent(Component.java:4460)
at java.awt.LightweightDispatcher.retargetMouseEvent(Container.java:4574)
at java.awt.LightweightDispatcher.processMouseEvent(Container.java:4238)
at java.awt.LightweightDispatcher.dispatchEvent(Container.java:4168)
at java.awt.Container.dispatchEventImpl(Container.java:2085)
at java.awt.Window.dispatchEventImpl(Window.java:2475)
at java.awt.Component.dispatchEvent(Component.java:4460)
at java.awt.EventQueue.dispatchEvent(EventQueue.java:599)
at java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:269)
at java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:184)
at java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java:174)
at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:169)
at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:161)
at java.awt.EventDispatchThread.run(EventDispatchThread.java:122)

what is it?

[Michael Montean]

your loop is going out of bounds on the index.

Java index starts at 0 in an array. Therefore an array of size 10 would have a maximum index of 9.

Your code says

while (c<=r.getIngredients().length) {

c will be greater than the maximum index in the array on the last iteration. You need to say,

while (c < r.getIngredients().length)

[Campbell Ritchie]

Welcome to the Ranch Michael Montean

[Antony Amicone]

ty i corrected the index but still an error

while ( c < jList1.getModel().getSize() ) {
System.out.println(c+"<"+jList1.getModel().getSize());
System.out.println(jList1.getModel().getElementAt(c));
ingredients[c] = (String)jList1.getModel().getElementAt(c);
c++;
}

this code, stamp just the first value of the list

[Antony Amicone]

ty i corrected the index but still an error

while ( c < jList1.getModel().getSize() ) {
System.out.println(c+"<"+jList1.getModel().getSize());
System.out.println(jList1.getModel().getElementAt(c));
ingredients[c] = (String)jList1.getModel().getElementAt(c);
c++;
}

this code, stamp just the first value of the list

 
 r = new Recipes(recipeName,recipeHowTo,ingredients,level,servings,timeToEat);
            int c = 0;
            while ( c < jList1.getModel().getSize() ) {
             System.out.println(c+"<"+jList1.getModel().getSize());
             System.out.println(jList1.getModel().getElementAt(c));
             //ingredients[c] = (String)jList1.getModel().getElementAt(c);
             r.setIngredient((String)jList1.getModel().getElementAt(c),c);
             c++;
            } 
 

this is how i edited, but still doesnt work, just stamp the first raw of jList, if i put setingredient((string= string under comment, it works,why???'

[Jan Hoppmann]

I don't see a method setIngredient(String, int) in your Recipes class - perhaps you forgot to write it?

[Antony Amicone]

sorry i edited the class and didnt updated on here, this is the class Recipes

 /*
 * To change this template, choose Tools | Templates
 * and open the template in the editor.
 */

package desktopapplication1;

/**
 *
 * @author Antonio
 */
public class Recipes {
private String recipeName = "";
private String recipeHowTo = "";
private String ingredients[];
private int servings;
private int level;
private int timeToEat;
private String imgPath = "";

public Recipes(String a,String a1,String[] a2,int a3, int a4, int a5){
    recipeName = a;
    recipeHowTo = a1;
    ingredients = a2;
    servings = a3;
    level = a4;
    timeToEat = a5;
}

public String getRecipeName(){
    return recipeName;
}

public void setRecipeName(String x){
    recipeName = x;
}

public String getRecipeHowTo(){
    return recipeHowTo;
}

public void setRecipeHowTo(String x){
    recipeHowTo = x;
}

public String[] getIngredients(){
    return ingredients;
}

public void setIngredients(String[] x){
    ingredients = x;
}

public int getServings(){
    return servings;
}

public void setServings(int x){
    servings = x;
}

public int getLevel(){
    return level;
}

public void setLevel(int x){
    level = x;
}

public int getTimeToEat(){
    return timeToEat;
}

public void setTimeToEat(int x){
    timeToEat = x;
}

public String getIngredient(int x){
    return ingredients[x];
}

public void setIngredient(String x,int xx){
    ingredients[xx] = x;
}

}
   

[Jan Hoppmann]

I can't see anything wrong. Do you get any runtime errors or warnings during compilation?

[Antony Amicone]

Jan Hoppmann wrote:I can't see anything wrong. Do you get any runtime errors or warnings during compilation?

no is really strange

when i made the stamp of the while, the while run just the first iteration if i have the command that assign the value of the list to the array

[Antony Amicone]

please helppppppppp i need to finish soon this program and this thing is blocking me