validation problem in struts

[shankhas sanyal]

hi all
i am new to struts and i am facing a problem. i hope to find a solution from all you guys ...
i have a simple user name and password login screen that checks the entered information from a mysql database. without validation framework this works. when i added the validation framework, supposed to show "name is required."

in my Actionbean i have added a validate(); when i comment this. i cannot login. but i can validate. when i uncomment this i can login but cant validate.

here are:

1. struts-config.xml
2. validator.xml
3. DBStrutsAction.java (action class)
4.DBStrutsLoginValidatorBean.java (my actionbean)
5. index.jsp (input file)
6. ApplicationResources.properties

thanks
please help me!!!
Shankha

struts-config.xml

   
<?xml version="1.0" encoding="UTF-8" ?>

<!DOCTYPE struts-config PUBLIC
          "-//Apache Software Foundation//DTD Struts Configuration 1.3//EN"
          "http://jakarta.apache.org/struts/dtds/struts-config_1_3.dtd">


<struts-config>
    <form-beans>
        <form-bean name="DBStrutsLoginValidatorBean" type="mybean.DBStrutsLoginValidatorBean"/>
    
    </form-beans>
    
    <global-exceptions>
    
    </global-exceptions>

    <global-forwards>
        <forward name="welcome"  path="/Welcome.do"/>
    </global-forwards>

    <action-mappings>
        <action input="/index.jsp"
                name="DBStrutsLoginValidatorBean"
                path="/abc"
                scope="session"
                type="myaction.DBStrutsAction"
                validate="true">
                    <forward name="success" path="/success.jsp"/>
                    <forward name="fail" path= "/index.jsp"/>
        </action>
        <action path="/Welcome" forward="/welcomeStruts.jsp"/>
    </action-mappings>
    
    <controller processorClass="org.apache.struts.tiles.TilesRequestProcessor"/>

    <message-resources parameter="com/myapp/struts/ApplicationResource"/>    
    
    <!-- ========================= Tiles plugin ===============================-->
    <!--
    This plugin initialize Tiles definition factory. This later can takes some
    parameters explained here after. The plugin first read parameters from
    web.xml, thenoverload them with parameters defined here. All parameters
    are optional.
    The plugin should be declared in each struts-config file.
    - definitions-config: (optional)
    Specify configuration file names. There can be several comma
    separated file names (default: ?? )
    - moduleAware: (optional - struts1.1)
    Specify if the Tiles definition factory is module aware. If true
    (default), there will be one factory for each Struts module.
    If false, there will be one common factory for all module. In this
    later case, it is still needed to declare one plugin per module.
    The factory will be initialized with parameters found in the first
    initialized plugin (generally the one associated with the default
    module).
    true : One factory per module. (default)
    false : one single shared factory for all modules
    - definitions-parser-validate: (optional)
    Specify if xml parser should validate the Tiles configuration file.
    true : validate. DTD should be specified in file header (default)
    false : no validation

    Paths found in Tiles definitions are relative to the main context.
    -->
    <plug-in className="org.apache.struts.tiles.TilesPlugin" >
        <set-property property="definitions-config" value="/WEB-INF/tiles-defs.xml" />      
        <set-property property="moduleAware" value="true" />
    </plug-in>
    
    <!-- ========================= Validator plugin ================================= -->
    <plug-in className="org.apache.struts.validator.ValidatorPlugIn">
        <set-property
            property="pathnames"
            value="/WEB-INF/validator-rules.xml,/WEB-INF/validation.xml"/>
    </plug-in>
  
</struts-config>

 

validator.xml

   
<?xml version="1.0" encoding="UTF-8" ?>

<!DOCTYPE form-validation PUBLIC
          "-//Apache Software Foundation//DTD Commons Validator Rules Configuration 1.1.3//EN"
          "http://jakarta.apache.org/commons/dtds/validator_1_1_3.dtd">

<form-validation>

<!--
     This is a minimal Validator form file with a couple of examples.
-->


<formset>
    <form name="DBStrutsLoginValidatorBean">
        <field property="username" depends="required">
            <arg0 key="prompt.username"/>
        </field>
    </form>
</formset>

    

</form-validation>


 

DBStrutsAction.java (action class)

  
/*
 * To change this template, choose Tools | Templates
 * and open the template in the editor.
 */

package myaction;

//for servlet
import javax.servlet.http.HttpServletRequest;
import javax.servlet.http.HttpServletResponse;
//for struts
import org.apache.struts.action.ActionForm;
import org.apache.struts.action.ActionForward;
import org.apache.struts.action.ActionMapping;
//user defined
import mybean.DBStrutsLoginValidatorBean;
import db.DbConnection;


public class DBStrutsAction extends org.apache.struts.action.Action {
    
    /* forward name="success" path="" */
    private static final String SUCCESS = "success";
    
    /**
     * This is the action called from the Struts framework.
     * @param mapping The ActionMapping used to select this instance.
     * @param form The optional ActionForm bean for this request.
     * @param request The HTTP Request we are processing.
     * @param response The HTTP Response we are processing.
     * @throws java.lang.Exception
     * @return
     */
    @Override
    public ActionForward execute(ActionMapping mapping, ActionForm form,
            HttpServletRequest request, HttpServletResponse response)
            throws Exception {

        DBStrutsLoginValidatorBean bean = (DBStrutsLoginValidatorBean) form;
        String userLogin = bean.getName();
        String password = bean.getPassword();
        ActionForward af = null;

        //database
        DbConnection dbconn= new DbConnection();
        dbconn.getConn();
        String result= (String)dbconn.getCheck(userLogin, password);

        if(result.equals("success")){
            af = mapping.findForward("success");
        }
        if(result.equals("fail")){
            af = mapping.findForward("fail");
        }
        return af;

       // return mapping.findForward(SUCCESS);
    }
}

  

DBStrutsLoginValidatorBean.java (my actionbean)

   
/*
 * To change this template, choose Tools | Templates
 * and open the template in the editor.
 */

package mybean;

import javax.servlet.http.HttpServletRequest;

import org.apache.struts.action.ActionErrors;
import org.apache.struts.action.ActionMapping;
import org.apache.struts.action.ActionMessage;

//


public class DBStrutsLoginValidatorBean extends org.apache.struts.validator.ValidatorForm {
    
    private String name;
    private String password;


    public DBStrutsLoginValidatorBean() {
        super();
        // TODO Auto-generated constructor stub
    }

    /**
     * This is the action called from the Struts framework.
     * @param mapping The ActionMapping used to select this instance.
     * @param request The HTTP Request we are processing.
   
     * @return the name
     */
    public String getName() {
        return name;
    }

    /**
     * @param name the name to set
     */
    public void setName(String name) {
        this.name = name;
    }

    /**
     * @return the password
     */
    public String getPassword() {
        return password;
    }

    /**
     * @param password the password to set
     */
    public void setPassword(String password) {
        this.password = password;
    }

    @Override
    public ActionErrors validate(ActionMapping mapping, HttpServletRequest request){ //this method is giving problems

        ActionErrors errors = new ActionErrors();
      
        if(getName()==null && getName().length()<1){
            errors.add("name", new ActionMessage("errors.name"));
        }
        if(getPassword()==null && getPassword().length()<1){
            errors.add("password", new ActionMessage("error.password"));
        }
      
        
        return errors;
        
    }

    
}

 

index.jsp

   
<%@page contentType="text/html"%>
<%@page pageEncoding="UTF-8"%>


<%@ taglib uri="http://struts.apache.org/tags-bean" prefix="bean" %>
<%@ taglib uri="http://struts.apache.org/tags-html" prefix="html" %>
<%@ taglib uri="http://struts.apache.org/tags-logic" prefix="logic" %>


<html>
    <head>
        <title>
            Finance Login
        </title>
    </head>

    <body>
        
        <font color="blue"><html:errors /></font><br/>

        <html:form action="abc" method="post">
            Name: <html:text property="name"/> <br>
            Password:<html:password property="password"/><br>
            <html:submit>Login</html:submit><br>
        </html:form>


    </body>
</html>
 

ApplicationResources.properties

 

# -- standard errors --
errors.header=<UL>
errors.prefix=<LI>
errors.suffix=</LI>
errors.footer=</UL>
# -- validator --
errors.invalid={0} is invalid.
errors.maxlength={0} can not be greater than {1} characters.
errors.minlength={0} can not be less than {1} characters.
errors.range={0} is not in the range {1} through {2}.
errors.required={0} is required.
errors.byte={0} must be an byte.
errors.date={0} is not a date.
errors.double={0} must be an double.
errors.float={0} must be an float.
errors.integer={0} must be an integer.
errors.long={0} must be an long.
errors.short={0} must be an short.
errors.creditcard={0} is not a valid credit card number.
errors.email={0} is an invalid e-mail address.

# -- other --
errors.cancel=Operation cancelled.
errors.detail={0}
errors.general=The process did not complete. Details should follow.
errors.token=Request could not be completed. Operation is not in sequence.
# -- welcome --
welcome.title=Struts Application
welcome.heading=Struts Applications in Netbeans!
welcome.message=It's easy to create Struts applications with NetBeans.


#--
enter.login= Please enter your login details below...
enter.user=  Enter User:
enter.pass = Enter Password:




#--
Login.user=Name
Login.pass=Password


#--
errors.name= name is required
errors.pass= password is required

prompt.username= name is required

   

[udaykumar maddigatla]

Hi

You are extending ValidatorForm, that means, no need to write validate() method. Validation will be done from validation.xml file.

whatever the validations you want to write... you have to specify in the validation.xml. That is the main funda of extending the ValidatorForm.

If you still want to use both validation.xml as well as validate() method. You have to write the below line of code

ActionErrors errors = super.validate(mapping, request); 

instead of

ActionErrors errors = new ActionErrors();   

Try to change the code as shown above. it will work

[shankha sanyal]

udaykumar maddigatla wrote:Hi

You are extending ValidatorForm, that means, no need to write validate() method. Validation will be done from validation.xml file.

whatever the validations you want to write... you have to specify in the validation.xml. That is the main funda of extending the ValidatorForm.

If you still want to use both validation.xml as well as validate() method. You have to write the below line of code

ActionErrors errors = super.validate(mapping, request); 

instead of

ActionErrors errors = new ActionErrors();   

Try to change the code as shown above. it will work

thank you very much it works now!!
Your the best ever!!!