Good design or should I try something else

[David Patrzeba]

Is this a good way of creating the window or is there a different design I should try. I like breaking everything up for organization but that means that I need to create all the containers as static variables.

   
import org.eclipse.swt.*;
import org.eclipse.swt.widgets.*;

public class Snippet29 {
	
	static Display display = new Display();
	static Shell shell = new Shell(display);
	static Menu bar = new Menu (shell, SWT.BAR);
	

	public static void main (String [] args) {
		Snippet29.CreateFile();
		Snippet29.CreateEdit();
		
		shell.setMenuBar (bar);
		shell.setSize (200, 200);
		shell.open ();
		while (!shell.isDisposed()) {
			if (!display.readAndDispatch ()) display.sleep ();
		}
		display.dispose ();
	}

	public static void CreateFile(){
			//creates an empty menu 
			MenuItem fileItem = new MenuItem (bar, SWT.CASCADE);
			//sets the menu to File
			fileItem.setText ("&File");
			//creates a drop down menu
			Menu submenu = new Menu (shell, SWT.DROP_DOWN);
			//adds the submenu to the File Menu
			fileItem.setMenu (submenu);
			//creates a new empty menu
			MenuItem item = new MenuItem (submenu, SWT.PUSH);
			//listens for the mouse click prints select all to the CLI
			item.addListener (SWT.Selection, new Listener () {
				public void handleEvent (Event e) {
					System.out.println ("Select All");
				}
			});
		
			item.setText ("Select &All\tCtrl+A");
			item.setAccelerator (SWT.MOD1 + 'A');
		
		
	}
	
	public static void CreateEdit(){
		//creates an empty menu 
		MenuItem fileItem = new MenuItem (bar, SWT.CASCADE);
		//sets the menu to File
		fileItem.setText ("&Edit");
		//creates a drop down menu
		Menu submenu = new Menu (shell, SWT.DROP_DOWN);
		//adds the submenu to the File Menu
		fileItem.setMenu (submenu);
		//creates a new empty menu
		MenuItem item = new MenuItem (submenu, SWT.PUSH);
		//listens for the mouse click prints select all to the CLI
		item.addListener (SWT.Selection, new Listener () {
			public void handleEvent (Event e) {
				System.out.println ("Undo");
			}
		});
	
		item.setText ("Undo\tCtrl+Z");
		item.setAccelerator (SWT.MOD1 + 'Z');
	
		shell.setMenuBar (bar);
	}
}
 

[David Newton]

It only means that because that's how you've coded it; you could also be returning a menu, or returning menu items, etc.

[Paul Clapham]

As far as everything having to be static, I would recommend rewriting your code to look like this:

public static void main (String [] args) {
   Snippet29 snippet = new Snippet29();
   snippet.run();
}

private void run() {
  // move everything from the original main() method here
}

Now that you have an object of the Snippet29 class, you can call its methods (which are the formerly static methods of the class) and use its variables (which are the formerly static variables).