take in file from client machine

[Azrael Noor]

i am trying to take file from client machine in server
What to do is?

1) in text box take file path
2) send file path to servlet
3) now?


am i getting wrong or not?

[Jan Cumps]

We have a FileUpload faq on the JavaRanch.

[Azrael Noor]

i am not getting where to make the directory

private static final String DESTINATION_DIR_PATH ="/files";

now where should i make this folder?

[subhash kumar]

i am not getting where to make the directory

private static final String DESTINATION_DIR_PATH ="/files";

now where should i make this folder?

save the uploaded file(from client) at some central location for example can be file server
or
make some folder on server machine that will always be available and can be treated as file repository with read write permission.

[Azrael Noor]

ok now

i have make folder in c: drive

C:\files


Now i have changed that portion of code accordingly

private static final String DESTINATION_DIR_PATH ="c:\\files";

When i try to upload the file
i get beautiful error again and i.e

javax.servlet.ServletException: c:\files is not a directory
	com.CommonsFileUploadServlet.init(CommonsFileUploadServlet.java:41)
	org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:102)
	org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:286)
	org.apache.coyote.http11.Http11Processor.process(Http11Processor.java:845)
	org.apache.coyote.http11.Http11Protocol$Http11ConnectionHandler.process(Http11Protocol.java:583)
	org.apache.tomcat.util.net.JIoEndpoint$Worker.run(JIoEndpoint.java:447)
	java.lang.Thread.run(Thread.java:619)

[subhash kumar]

make sure that folder c:\files directory should exist
and this directory also should have the writing permission


can you post your code how are you accessing this directory.

[Azrael Noor]

private static final String TMP_DIR_PATH = "c:\\tmp";
	private File tmpDir;
	private static final String DESTINATION_DIR_PATH ="c:\\files";
	private File destinationDir;

    
	public void init(ServletConfig config) throws ServletException
        {
		super.init(config);
		tmpDir = new File(TMP_DIR_PATH);

		if(!tmpDir.isDirectory())
                {
			throw new ServletException(TMP_DIR_PATH + " is not a directory");
		}

		String realPath = getServletContext().getRealPath(DESTINATION_DIR_PATH);
		destinationDir = new File(realpath);

		if(!destinationDir.isDirectory())
                {
			throw new ServletException(DESTINATION_DIR_PATH+" is not a directory");
		}

	}

this way i am using code

[subhash kumar]

try using other drives like f:\\files

[Azrael Noor]

javax.servlet.ServletException: f:\files is not a directory
com.CommonsFileUploadServlet.init(CommonsFileUploadServlet.java:43)
org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:102)
org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:286)
org.apache.coyote.http11.Http11Processor.process(Http11Processor.java:845)
org.apache.coyote.http11.Http11Protocol$Http11ConnectionHandler.process(Http11Protocol.java:583)
org.apache.tomcat.util.net.JIoEndpoint$Worker.run(JIoEndpoint.java:447)
java.lang.Thread.run(Thread.java:619

)

[Seetharaman Venkatasamy]

could *jnlp* help you?

[subhash kumar]

   String realPath = getServletContext().getRealPath(DESTINATION_DIR_PATH);  
         destinationDir = new File(realpath);  
   
         if(!destinationDir.isDirectory())  
                 {  
             throw new ServletException(DESTINATION_DIR_PATH+" is not a directory");  
         }   

you are not throwing the real path which you are using check it first.

[subhash kumar]

throw new ServletException(DESTINATION_DIR_PATH+" is not a directory");

use here realPath in place of DESTINATION_DIR_PATH

your exception is misleading you because file object is created by realPath but ServletException is thrown by DESTINATION_DIR_PATH

[Azrael Noor]

exception 

javax.servlet.ServletException: Servlet execution threw an exception
	org.netbeans.modules.web.monitor.server.MonitorFilter.doFilter(MonitorFilter.java:390)


root cause 

java.lang.NoClassDefFoundError: org/apache/commons/io/output/DeferredFileOutputStream
	org.apache.commons.fileupload.disk.DiskFileItemFactory.createItem(DiskFileItemFactory.java:199)
	org.apache.commons.fileupload.FileUploadBase.parseRequest(FileUploadBase.java:361)
	org.apache.commons.fileupload.servlet.ServletFileUpload.parseRequest(ServletFileUpload.java:126)
	com.CommonsFileUploadServlet.doPost(CommonsFileUploadServlet.java:71)
	javax.servlet.http.HttpServlet.service(HttpServlet.java:637)
	javax.servlet.http.HttpServlet.service(HttpServlet.java:717)
	org.netbeans.modules.web.monitor.server.MonitorFilter.doFilter(MonitorFilter.java:390)


root cause 

java.lang.ClassNotFoundException: org.apache.commons.io.output.DeferredFileOutputStream
	org.apache.catalina.loader.WebappClassLoader.loadClass(WebappClassLoader.java:1387)
	org.apache.catalina.loader.WebappClassLoader.loadClass(WebappClassLoader.java:1233)
	org.apache.commons.fileupload.disk.DiskFileItemFactory.createItem(DiskFileItemFactory.java:199)
	org.apache.commons.fileupload.FileUploadBase.parseRequest(FileUploadBase.java:361)
	org.apache.commons.fileupload.servlet.ServletFileUpload.parseRequest(ServletFileUpload.java:126)
	com.CommonsFileUploadServlet.doPost(CommonsFileUploadServlet.java:71)
	javax.servlet.http.HttpServlet.service(HttpServlet.java:637)
	javax.servlet.http.HttpServlet.service(HttpServlet.java:717)
	org.netbeans.modules.web.monitor.server.MonitorFilter.doFilter(MonitorFilter.java:390)

1 Error is much better than more than one

[Azrael Noor]

giving whole code

Code in Servlet

package com;

import java.io.File;
import java.io.IOException;
import java.io.PrintWriter;
import java.util.Iterator;
import java.util.List;

import javax.servlet.ServletConfig;
import javax.servlet.ServletException;
import javax.servlet.http.HttpServlet;
import javax.servlet.http.HttpServletRequest;
import javax.servlet.http.HttpServletResponse;

import org.apache.commons.fileupload.FileItem;
import org.apache.commons.fileupload.FileUploadException;
import org.apache.commons.fileupload.disk.DiskFileItemFactory;
import org.apache.commons.fileupload.servlet.ServletFileUpload;


public class CommonsFileUploadServlet extends HttpServlet
{
	private static final String TMP_DIR_PATH = "c:\\tmp";
	private File tmpDir;
	private static final String DESTINATION_DIR_PATH ="/files";
	private File destinationDir;

    
    @Override
	public void init(ServletConfig config) throws ServletException
        {
		super.init(config);
		tmpDir = new File(TMP_DIR_PATH);
		if(!tmpDir.isDirectory())
                {
			throw new ServletException(TMP_DIR_PATH + " is not a directory");
		}
                
		String realPath = getServletContext().getRealPath(DESTINATION_DIR_PATH);
                destinationDir = new File(realPath);

		if(!destinationDir.isDirectory())
                {
			throw new ServletException(realPath +" is not a directory");
		}

	}

    @Override
	protected void doPost(HttpServletRequest request, HttpServletResponse response) throws ServletException, IOException
        {
	    PrintWriter out = response.getWriter();
	    response.setContentType("text/plain");
	    out.println("<h1>Servlet File Upload Example using Commons File Upload</h1>");
	    out.println();

		DiskFileItemFactory  fileItemFactory = new DiskFileItemFactory ();
		
		fileItemFactory.setSizeThreshold(1*1024*1024); //1 MB
		
		fileItemFactory.setRepository(tmpDir);

		ServletFileUpload uploadHandler = new ServletFileUpload(fileItemFactory);
		try
                {
			List items = uploadHandler.parseRequest(request);
			Iterator itr = items.iterator();
			while(itr.hasNext())
                        {
				FileItem item = (FileItem) itr.next();
				
				if(item.isFormField())
                                {
					out.println("File Name = "+item.getFieldName()+", Value = "+item.getString());
				} 
                                else
                                {
				
					out.println("Field Name = "+item.getFieldName()+
						", File Name = "+item.getName()+
						", Content type = "+item.getContentType()+
						", File Size = "+item.getSize());
				
					File file = new File(destinationDir,item.getName());
					item.write(file);
				}
				out.close();
			}
		}
                catch(FileUploadException ex)
                {
			log("Error encountered while parsing the request",ex);
		}
                catch(Exception ex) {
			log("Error encountered while uploading file",ex);
		}

	}

}

in html

<html>
	<head>

        </head>
	<body>
		<p>File Upload Check</p>
		<form action="CommonsFileUploadServlet" enctype="multipart/form-data" method="POST">
			<input type="file" name="file1"><br>
			<input type="Submit" value="Upload File"><br>
		</form>
	</body>
</html>

[subhash kumar]

java.lang.ClassNotFoundException: org.apache.commons.io.output.DeferredFileOutputStream

provide your application this class any how.

[Tom Thomas]

The call uploadHandler.parseRequest(request) fails - I get the error that my request is not multipart/form-data.

My jsp:
<form action="attachments" method="post" name="files" enctype="multipart/form-data" >
.....
<input type="file" id="dataFile" name="datafile" size="80" accept="image/gif, image/jpeg, image/png, image/jpg">
....

</form>

When I call request.getContentType, null is returned. It doesn't seem that the header is being set by the enctype parameter.

Any ideas?