problem in getting values using EL

[madhuri kunchala]

hi,
in my application...i m facing problem with 'modify.jsp' page....i m using EL for getting the existing values.....im 'modify.jsp' page im getting values...the problem arises at 'Type' and 'No' check boxes...the problem is i used checkboxes and textboxes...here is my 'modify.jsp' code

modify.jsp

 
<td> <b>Auto-Renewal</b>
<td><input type="checkbox" name="autoRenewal" value="YES:TYPE," id="yesType" onclick="autoType()"
         ${packDetails.packDetails.autoRenewal.autoRenew.autoType ? 'checked' :''}
         ${packDetails.packDetails.autoRenewal.autoRenew.autoType ? '' :'disabled'}>Type
<input type="text" name="autoRenewal" size="1" id="txtyesType" value="${packDetails.packDetails.autoRenewal.autoRenew.txtautoType}"
         ${packDetails.packDetails.autoRenewal.autoRenew.autoType ? '' :'disabled'}/>  
<input type="checkbox" name="autoRenewal" value="TIME," id="time" onclick="autoTime()"
         ${packDetails.packDetails.autoRenewal.autoRenew.autoTime ? 'checked' :''}
         ${packDetails.packDetails.autoRenewal.autoRenew.autoTime ? '' :'disabled'}>Time
<input type="text" name="autoRenewal" size="1" id="txtTime" value="${packDetails.packDetails.autoRenewal.autoRenew.txtautoTime}"
         ${packDetails.packDetails.autoRenewal.autoRenew.autoTime ? '' :'disabled'}/>
<input type="checkbox" name="autoRenewal" value="MIGR_STATUS," id="migrStatus" onclick="autoMigr()"
         ${packDetails.packDetails.autoRenewal.autoRenew.autoMigr ? 'checked' :''}
         ${packDetails.packDetails.autoRenewal.autoRenew.autoMigr ? '' :'disabled'}>Migr_Status
<input type="text" name="autoRenewal" size="1" id="txtmigrStatus" value="${packDetails.packDetails.autoRenewal.autoRenew.txtautoMigr}"
         ${packDetails.packDetails.autoRenewal.autoRenew.autoMigr ? '' :'disabled'}/>
<input type="checkbox" name="autoRenewal" value="NO:TYPE," id="noType" onclick="autoNo()"
         ${packDetails.packDetails.autoRenewal.autoRenew.autoNo ? 'checked' :''}
         ${packDetails.packDetails.autoRenewal.autoRenew.autoNo ? '' :'disabled'}>No
<input type="text" name="autoRenewal" size="1" id="txtNo" value="${packDetails.packDetails.autoRenewal.autoRenew.txtautoNo}"
         ${packDetails.packDetails.autoRenewal.autoRenew.autoNo ? '' : 'disabled'}/>   </td>

in my file...if 'TIME' values exists means it is showing correctly that means 'check box for TIME is selected and in text box the value is showing' same for 'MIGR_STATUS'
the problem im facing problem at 'YES:TYPE' checkbox and 'NO:TYPE'....checkboxes...if 'YES:TYPE' value already presents..it is not showing anything...can any one suggest me how to do...

[madhuri kunchala]

any help regarding my post

[David Newton]

PatienceIsAVirtue -- 45 minutes is not long enough to wait for something to answer your question.

[David Newton]

I'm not sure what the problem is (and wow, I'd really set some temporary variables). Could you describe it again, or produce a simplified test case that reproduces the problem?

[madhuri kunchala]

in my form....if for 'Type' checkbox...it is not showing values...it is getting disabled..eventhough it is having values ....the same problem im getting for 'No' checkbox also..

Auto-Renewal : (checkbox)Type(textbox) (checkbox)Time(textbox) (checkbox)Migr_Status(textbox) (checkbox)No(textbox)

the above is my form...

if i open 'modify.jsp' page...im getting the already existing values in the (checkbox)Time(textbox) (checkbox)Migr_Status(textbox)
that means for example......
1) the checkbox is selected for 'Time' and corresponding value for 'Time' is displaying....same for 'Migr_Status'
2) im not getting for 'Type' and 'No'...


here is my bean program....

import java.io.Serializable;

public class autoRenew implements Serializable {
    private boolean autoType;
    private String txtType;
    private boolean autoTime;
    private String txtTime;
    private boolean autoMigr;
    private String txtMigr;
    private boolean no;
    public autoRenew(String autoRen) {
        String[] autoRens = autoRen.split(":");
        for (int i = 0; i < autoRens.length; i++) {
            String string = autoRens[i];
            System.out.println("Auto Renewals :: " + string);
            int index = string.indexOf(",") + 1;
            if (string.toUpperCase().startsWith("YES:TYPE")) {
                autoType = true;
                txtType = string.substring(index);
            } else if (string.toUpperCase().startsWith("TIME")) {
                autoTime = true;
                txtTime = string.substring(index);
            } else if (string.toUpperCase().startsWith("MIGR_STATUS")) {
                autoMigr = true;
                txtMigr = string.substring(index);
            } else if (string.toUpperCase().startsWith("NO:TYPE")) {
                no = true;
            }
        }
}
    public boolean isAutoType() {
        return autoType;
    }
    public void setAutoType(boolean autoType) {
        this.autoType = autoType;
    }
    public String getTxtType() {
        return txtType;
    }
    public void setTxtType(String txtType) {
        this.txtType = txtType;
    }
....same for remaining functions...

[madhuri kunchala]

hi,
i tried it is printing correctly in console but not in the form...can anyone suggest me where the code gets wrong...

[madhuri kunchala]

problem in getting values for 'YES:TYPE' and 'NO:TYPE'....any help regarding my post....

[David Newton]

I'd make sure the values you think are in the bean are actually what's in the bean.

S2 will first create the bean then call the setters for individual properties (via OGNL). You're setting bean properties in a parameterized constructor: have you checked to see if the code is doing what you think it is?

[madhuri kunchala]

hi David,
i checked each and every line...its working fine for check boxes 'TIME' and 'MIGR_STATUS' with their corresponding text boxes values....i m unable to get the values for 'YES:TYPE' and 'NO:TYPE'....can you once check my code...here im providing.....
1) modify.jsp

<table>
<tr>
<td></td>
<td><b>Auto-Renewal</b>
<td><input type="checkbox" name="autoRenewal" value="YES:TYPE," id="yesType" onclick="autoType()"
         ${packDetails.packDetails.autoRenewal.autoRen.autoType ? 'checked' :''}
         ${packDetails.packDetails.autoRenewal.autoRen.autoType ? '' :'disabled'}>Type
<input type="text" name="autoRenewal" size="1" id="txtyesType" value="${packDetails.packDetails.autoRenewal.autoRen.txtType}"
         ${packDetails.packDetails.autoRenewal.autoRen.autoType ? '' :'disabled'}/>
<input type="checkbox" name="autoRenewal" value="TIME," id="time" onclick="autoTime()"
         ${packDetails.packDetails.autoRenewal.autoRen.autoTime ? 'checked' :''}
         ${packDetails.packDetails.autoRenewal.autoRen.autoTime ? '' :'disabled'}>Time
<input type="text" name="autoRenewal" size="1" id="txtTime" value="${packDetails.packDetails.autoRenewal.autoRen.txtTime}"
         ${packDetails.packDetails.autoRenewal.autoRen.autoTime ? '' :'disabled'}/>
<input type="checkbox" name="autoRenewal" value="MIGR_STATUS," id="migrStatus" onclick="autoMigr()"
         ${packDetails.packDetails.autoRenewal.autoRen.autoMigr ? 'checked' :''}
         ${packDetails.packDetails.autoRenewal.autoRen.autoMigr ? '' :'disabled'}>Migr_Status
<input type="text" name="autoRenewal" size="1" id="txtmigrStatus" value="${packDetails.packDetails.autoRenewal.autoRen.txtMigr}"
         ${packDetails.packDetails.autoRenewal.autoRen.autoMigr ? '' :'disabled'}/>
<input type="checkbox" name="autoRenewal" value="NO:TYPE," id="noType" onclick="autoNo()"
         ${packDetails.packDetails.autoRenewal.autoRen.no ? 'checked' :''}
         ${packDetails.packDetails.autoRenewal.autoRen.no ? '' :'disabled'}>No
<input type="text" name="autoRenewal" size="1" id="txtNo"  value="${packDetails.packDetails.autoRenewal.autoRen.txtNo}"
         ${packDetails.packDetails.autoRenewal.autoRen.no ? '' : 'disabled'}/>
</tr>
</table>

2)modify.js

var chkyesTypedays = document.getElementsByName('autoRenewal');
    var hasyesTypeChecked = false;
    for (var j1 = 0; j1 < chkyesTypedays.length; j1++)
    {
        if (chkyesTypedays[j1].checked)
        {
            if(document.getElementById('yesType').checked)
            {
                var txtyesTypeDays = document.getElementById('txtyesType');
                if(txtyesTypeDays.value.length == 0)
                {
                    window.alert("Enter Type for Auto-Renewal Days");
                    txtyesTypeDays.focus();
                    return false;
                }
                var chkyesTypeDays = "0123456789";
                var chkyesTypeDaysStr = document.frm.txtyesType.value;
                var allchkyesTypeDaysValid = true;
                for (i = 0;  i < chkyesTypeDaysStr.length;  i++)
                {
                    ch = chkyesTypeDaysStr.charAt(i);
                    for (j = 0;  j < chkyesTypeDays.length;  j++)
                        if (ch == chkyesTypeDays.charAt(j))
                            break;
                    if (j == chkyesTypeDays.length)
                    {
                        allchkyesTypeDaysValid = false;
                        break;
                    }
                }
                if (!allchkyesTypeDaysValid)
                {
                    alert("Enter only numeric in the \" Type of Auto-Renewal \" field");
                    document.frm.txtyesType.focus();
                    return (false);
                }
            }
            hasyesTypeChecked = true;
            break;
        }
    }
    if (!hasyesTypeChecked)
    {
        alert("Select at least one Auto-Renewals");
        return false;
    }
    var chktimedays = document.getElementsByName('autoRenewal');
    var hastimedaysChecked = false;
    for (var k1 = 0; k1 < chktimedays.length; k1++)
    {
        if (chktimedays[k1].checked)
        {
            if(document.getElementById('time').checked)
            {
                var txttimeDays = document.getElementById('txtTime');
                if(txttimeDays.value.length < 1)
                {
                    window.alert("Enter Time for Auto-Renewal Days");
                    txttimeDays.focus();
                    return false;
                }
                var chktimeDays = "0123456789";
                var chktimeDaysStr = document.frm.txtTime.value;
                var allchktimeDaysValid = true;
                for (i = 0;  i < chktimeDaysStr.length;  i++)
                {
                    ch = chktimeDaysStr.charAt(i);
                    for (j = 0;  j < chktimeDays.length;  j++)
                        if (ch == chktimeDays.charAt(j))
                            break;
                    if (j == chktimeDays.length)
                    {
                        allchktimeDaysValid = false;
                        break;
                    }
                }
                if (!allchktimeDaysValid)
                {
                    alert("Enter only numeric in the \" Time for Auto-Renewal \" field");
                    document.frm.txtTime.focus();
                    return (false);
                }
            }
            hastimedaysChecked = true;
            break;
        }
    }
    if (!hastimedaysChecked)
    {
        alert("Select at least one Auto-Renewals");
        return false;
    }
    var chkmigrStatusdays = document.getElementsByName('autoRenewal');
    var hasmigrStatusdaysChecked = false;
    for (var l = 0; l < chkmigrStatusdays.length; l++)
    {
        if (chkmigrStatusdays[l].checked)
        {
            if(document.getElementById('migrStatus').checked)
            {
                var txtmigrStatusDays = document.getElementById('txtmigrStatus');
                if(txtmigrStatusDays.value.length < 1)
                {
                    window.alert("Enter Migr-Status for Auto-Renewal Days");
                    txtmigrStatusDays.focus();
                    return false;
                }
                chkMigrDays=/^JA$/;
                if (chkMigrDays.test(document.frm.txtmigrStatus.value))
                {}
                else
                {
                    alert('Invalid \" Migration Status of Auto-Renewal \" Entry');
                    return false;
                }
            }
            hasmigrStatusdaysChecked = true;
            break;
        }
    }
    if (!hasmigrStatusdaysChecked)
    {
        alert("Select at least one Auto-Renewals");
        return false;
    }
    var chkNodays = document.getElementsByName('autoRenewal');
    var hasNoChecked = false;
    for (var l1 = 0; l1 < chkNodays.length; l1++)
    {
        if (chkNodays[l].checked)
        {
            if(document.getElementById('noType').checked)
            {
                var txtNoDays = document.getElementById('txtNo');
                if(txtNoDays.value.length < 1)
                {
                    window.alert("Enter No. of days for Auto-Renewal Days");
                    txtNoDays.focus();
                    return false;
                }
                var chkNoDays = "0123456789";
                var chkNoDaysStr = document.frm.txtNo.value;
                var allchkNoDaysValid = true;
                for (i = 0;  i < chkNoDaysStr.length;  i++)
                {
                    ch = chkNoDaysStr.charAt(i);
                    for (j = 0;  j < chkNoDays.length;  j++)
                        if (ch == chkNoDays.charAt(j))
                            break;
                    if (j == chkNoDays.length)
                    {
                        allchkNoDaysValid = false;
                        break;
                    }
                }
                if (!allchkNoDaysValid)
                {
                    alert("Enter only numeric in the \" No for Auto-Renewal \" field");
                    document.frm.txtNo.focus();
                    return (false);
                }
            }
            hasNoChecked = true;
            break;
        }
    }
    if (!hasNoChecked)
    {
        alert("Select at least one Auto-Renewals");
        return false;
    }    

3)modify.java

 String[] autoRenewal = request.getParameterValues("autoRenewal");
        String autoRenewalStr = "";
        for (int i = 0; i < autoRenewal.length; i++) {
            autoRenewalStr += autoRenewal[i];
            //if ((i + 1) % 2 == 0 &&i!=autoRenewal.length-1) {
            if ((i + 1) % 2 == 0) {
                autoRenewalStr += ":";
            }
        }   

4)autoRenew.java

public class autoRenew implements Serializable {

    private boolean autoType;
    private String txtType;
    private boolean autoTime;
    private String txtTime;
    private boolean autoMigr;
    private String txtMigr;
    private boolean no;
    private String txtNo;

    public autoRenew(String autoRen) {
        String[] autoRens = autoRen.split(":");
        for (int i = 0; i < autoRens.length; i++) {
            String string = autoRens[i];
            System.out.println("Auto Renewals :: " + string);
            int index = string.indexOf(",") + 1;
            if (string.toUpperCase().startsWith("YES:TYPE")) {
                autoType = true;
                txtType = string.substring(index);
            } else if (string.toUpperCase().startsWith("TIME")) {
                autoTime = true;
                txtTime = string.substring(index);
            } else if (string.toUpperCase().startsWith("MIGR_STATUS")) {
                autoMigr = true;
                txtMigr = string.substring(index);
            } else if (string.toUpperCase().startsWith("NO:TYPE")) {
                no = true;
                txtNo = string.substring(index);
            }
        }
    }
    public boolean isAutoType() {
        return autoType;
    }
    public void setAutoType(boolean autoType) {
        this.autoType = autoType;
    }
    public String getTxtType() {
        return txtType;
    }
    public void setTxtType(String txtType) {
        this.txtType = txtType;
    }
    public boolean isAutoTime() {
        return autoTime;
    }
    public void setAutoTime(boolean autoTime) {
        this.autoTime = autoTime;
    }
    public String getTxtTime() {
        return txtTime;
    }
    public void setTxtTime(String txtTime) {
        this.txtTime = txtTime;
    }
    public boolean isAutoMigr() {
        return autoMigr;
    }
    public void setAutoMigr(boolean autoMigr) {
        this.autoMigr = autoMigr;
    }
    public String getTxtMigr() {
        return txtMigr;
    }
    public void setTxtMigr(String txtMigr) {
        this.txtMigr = txtMigr;
    }
    public boolean isNo() {
        return no;
    }
    public void setNo(boolean no) {
        this.no = no;
    }
    public String getTxtNo() {
       return txtNo;
    }
    public void setTxtNo(String txtNo) {
        this.txtNo = txtNo;
    }
}

help me out regarding this issue.....

thanks,
madhu.

[David Newton]

I think you're missing my point. I don't think the boolean values are ever getting set on your bean; you're not giving a true/false or yes/no (or whatever else OGNL will accept; I don't recall) on form submission. That's why I'm asking you to check to see that the boolean values are what you think they are.

That JavaScript is essentially illegible, by the way--I'd consider refactoring. But it has nothing to do with the problem, as far as I can tell.

[madhuri kunchala]

hi,
i tried the following bean code...its working if i had given only 'YES' and 'NO'..but if im giving 'YES:TYPE' and 'NO:TYPE' it is not get selected in my modify page...can any one help me out..im unable to get out my problem...

package nxl.util.pack.auto;
import java.io.Serializable;
public class autoRenewal implements Serializable{
    private boolean autoType;
    private String txtautoType;
    private boolean autoTime;
    private String txtautoTime;
    private boolean autoMigr;
    private String txtautoMigr;
    private boolean autoNo;
    //private String txtautoNo;
    public autoRenewal(String autoRenew) {
        String[] autoRenews = autoRenew.split(":");
        for (int i = 0; i < autoRenews.length; i++) {
            String string = autoRenews[i];
            System.out.println("Auto-Renewals :: " + string);
            int index = string.indexOf(",")+1;
            if (string.toUpperCase().startsWith("YES:TYPE")) {
                autoType = true;
                txtautoType = string.substring(index);
            } else if (string.toUpperCase().startsWith("TIME")) {
                autoTime = true;
                txtautoTime = string.substring(index);
            } else if (string.toUpperCase().startsWith("MIGR_STATUS")) {
                autoMigr = true;
                txtautoMigr = string.substring(index);
            } else if (string.equalsIgnoreCase("NO")) {
                autoNo = true;
                //txtautoNo = string.substring(index);
            }
        }
    }
    public boolean isAutoType() {
        return autoType;
    }
    public void setAutoType(boolean autoType) {
        this.autoType = autoType;
    }
    public String getTxtautoType() {
        return txtautoType;
    }
    public void setTxtautoType(String txtautoType) {
        this.txtautoType = txtautoType;
    }
    public boolean isAutoTime() {
        return autoTime;
    }
    public void setAutoTime(boolean autoTime) {
        this.autoTime = autoTime;
    }
    public String getTxtautoTime() {
        return txtautoTime;
    }
    public void setTxtautoTime(String txtautoTime) {
        this.txtautoTime = txtautoTime;
    }
    public boolean isAutoMigr() {
        return autoMigr;
    }
    public void setAutoMigr(boolean autoMigr) {
        this.autoMigr = autoMigr;
    }
    public String getTxtautoMigr() {
        return txtautoMigr;
    }
    public void setTxtautoMigr(String txtautoMigr) {
        this.txtautoMigr = txtautoMigr;
    }
    public boolean isAutoNo() {
        return autoNo;
    }
    public void setAutoNo(boolean autoNo) {
        this.autoNo = autoNo;
    }
}

and my modify.jsp is as follows

<fieldset><legend>Auto-Renewal</legend>
<table>
<tr>
<td></td>
<td><b>Auto-Renewal</b>
<td><input type="checkbox" name="autoRenewal" value="YES:TYPE," id="yesType" onclick="autoType()"
                 ${packDetails.packDetails.autoRenewal.autoRenew.autoType ? 'checked' :''}
                 ${packDetails.packDetails.autoRenewal.autoRenew.autoType ? '' :'disabled'}>Type
       <input type="text" name="autoRenewal" size="1" id="txtyesType" value="${packDetails.packDetails.autoRenewal.autoRenew.txtautoType}"
                 ${packDetails.packDetails.autoRenewal.autoRenew.autoType ? '' :'disabled'}/>  
       <input type="checkbox" name="autoRenewal" value="TIME," id="time" onclick="autoTime()"
                 ${packDetails.packDetails.autoRenewal.autoRenew.autoTime ? 'checked' :''}
                 ${packDetails.packDetails.autoRenewal.autoRenew.autoTime ? '' :'disabled'}>Time
       <input type="text" name="autoRenewal" size="1" id="txtTime" value="${packDetails.packDetails.autoRenewal.autoRenew.txtautoTime}"
                 ${packDetails.packDetails.autoRenewal.autoRenew.autoTime ? '' :'disabled'}/>
       <input type="checkbox" name="autoRenewal" value="MIGR_STATUS," id="migrStatus" onclick="autoMigr()"
                 ${packDetails.packDetails.autoRenewal.autoRenew.autoMigr ? 'checked' :''}
                 ${packDetails.packDetails.autoRenewal.autoRenew.autoMigr ? '' :'disabled'}>Migr_Status
       <input type="text" name="autoRenewal" size="1" id="txtmigrStatus" value="${packDetails.packDetails.autoRenewal.autoRenew.txtautoMigr}"
                 ${packDetails.packDetails.autoRenewal.autoRenew.autoMigr ? '' :'disabled'}/>
       <input type="checkbox" name="autoRenewal" value="NO:TYPE," id="noType" onclick="autoNo()"
                 ${packDetails.packDetails.autoRenewal.autoRenew.autoNo ? 'checked' :''}
                 ${packDetails.packDetails.autoRenewal.autoRenew.autoNo ? '' :'disabled'}>No</td>
</tr>
</table>
</fieldset>

any help...where to get changed..inorder to get selected in modify page...

thanks,
madhu.

[madhuri kunchala]

any help regarding my post

[David Newton]

David Newton wrote:I think you're missing my point. I don't think the boolean values are ever getting set on your bean; you're not giving a true/false or yes/no (or whatever else OGNL will accept; I don't recall) on form submission. That's why I'm asking you to check to see that the boolean values are what you think they are.

What more help do you want? I told you the problem, you verified it by saying that with just "yes" or "no" it works. I don't know *why* you need the extra stuff in the checkbox value, but if you truly do, you'll have to do your own type conversion.

[madhuri kunchala]

hi David,
in my form...for 'yes' and 'no' it should enter the value in textbox...im not getting it...if i provide..without textbox it is working..but i need with textbox....or suggest me what to do...

[Bear Bibeault]

Here's another tip: making your posts harder to read than they need to be is not a good way to try and get help. In English, sentences end with a period character followed by a space character. The first letter of the next sentences is capitalized. Using three periods and running your sentences together makes your posts much harder to read than they need to be, and less likely to get responses.