JUnit Test Query

[Karthik Sanghvi]

Hello, I have a Implementation Class AccountServiceImpl.java

package com.apress.springrecipes.bank;

public class AccountServiceImpl implements AccountService {

    private AccountDao accountDao;

    public AccountServiceImpl(AccountDao accountDao) {
        this.accountDao = accountDao;
    }

    public void createAccount(String accountNo) {
        accountDao.createAccount(new Account(accountNo, 0));
    }

    public void removeAccount(String accountNo) {
        Account account = accountDao.findAccount(accountNo);
        accountDao.removeAccount(account);
    }

    public void deposit(String accountNo, double amount) {
    	
    	
        Account account = accountDao.findAccount(accountNo);
        account.setBalance(account.getBalance() + amount);
        accountDao.updateAccount(account);
    	
    }

   public double creditLimit (String accountNo, double amount) {
    	Account account = accountDao.findAccount(accountNo);
    	double  balance=account.getBalance();
    	return balance;
    }
    
    
    public void withdraw(String accountNo, double amount) {
        Account account = accountDao.findAccount(accountNo);
        
        double availableBalace=account.getBalance();
        if(account.getBalance() < amount)
        {
        	account.setCreditLimit(500); /* We give the creditLimit here*/
        	  
        }
        
        if ((availableBalace+account.getCreditLimit()) < amount) {//Here I am checking the credit limit and balance
            throw new InsufficientBalanceException();
        }
        account.setBalance(account.getBalance() - (amount+500)); //Here 500 is credit limit.
        accountDao.updateAccount(account);
    }

    public double getBalance(String accountNo) {
        return accountDao.findAccount(accountNo).getBalance();
    }
    
    
}

that implements accountService interface.

package com.apress.springrecipes.bank;

public interface AccountService {

    public void createAccount(String accountNo);
    public void removeAccount(String accountNo);
    public void deposit(String accountNo, double amount);
    public double creditLimit (String accountNo, double amount);
    public void withdraw(String accountNo, double amount);
    public double getBalance(String accountNo);
}

I want to write a JUnit test to test the credit limit at the time of withdrawal for any account.


Please help

[David Newton]

What's stopping you? What do you have so far?

Because you've coded to an implementation, the DAO isn't injectable. If you want to make the service testable, the DAO should be mockable such that you can test *just* the logic in the withdraw() method.

(I know it's just an example, or at least I assume it is, but the credit limit logic is (a) hardcoded, and (b) likely in the wrong place.)