Struts1: queryString with indexed properties not parsed correctly

[Tim Kernan]

I am unable to get() the indexed properties contained in a query string from a submitted page.

It appears that the Bean parser (or some parsing function) is skipping over or is confused by the % sign. Non indexed properties are parsed just fine.
I am using Struts 1.3.8, Netbeans 6.7.1, jdk1.6.0_16 on a Linux OS, Browser = FireFox 1.5.0.7

1. HTML form has input fields of this format:
<input type="text" name="lines[0].town" value="dilton"></td>

2. The query string is: (as obtained by request.getQueryString() :
"test=5&testb=6&lines%5B0%5D.name=tim&test=4&lines%5B0%5D.town=milton&lines%5B1%5D.name=tom&test=4&lines%5B1%5D.town=wilton&lines%5B2%5D.name=todd&test=4&lines%5B2%5D.town=dilton&lines%5B3%5D.name=ted&test=4&lines%5B3%5D.town=hilton&operation=Submit&ams=1258

3. All properties which do not contain the % sign are parsed properly by the ActionForm.

4. It seems to me that Struts must be able to deal with these or have a way to convert the %5B to { and %5D to ].

You assistance is much appreciated.
Thanks
Tim

[Sriram Ture]

Hi,


You can do it in a better way. Just go through the link below.

Data Retention



Regards,
Sriram

[Tim Kernan]

Sriram
Thanks for refering me to that article. Unless I am missing something, the article presented a "typical" indexed property example of both JSP code and the bean ActionForm getters and setters.Altho, it avoided the use of <html:test .../> to construct the page.
This is indeed the model I am using. The problem is that the % signs used in the query string returning to the ActionForm are preventing the indexed objects from being parsed. Thus the setter methods are not invoked.


Here is the JSP code

<logic:iterate id="lines" name="NestedIndexPropActionForm" property="lines_list" indexId="index" >
                <html:hidden name="lines" property="name" indexed="true"/>
                <html:text property="test" value="4" />
                <tr>
                    <td width="15%">
                    <bean:write name="lines" property="name" /></td>
                    <td width="15%">
                    
                    <input type="text" name="lines[<%=index %>].town" value="<bean:write name='lines' property='town' />" />

                </tr>
            </logic:iterate>

Here is the resulting query string:
test=5&testb=6&lines%5B0%5D.name=tim&test=4&lines%5B0%5D.town=milton&lines%5B1%5D.name=tom&test=4&lines%5B1%5D.town=wilton&lines%5B2%5D.name=todd&test=4&lines%5B2%5D.town=dilton&lines%5B3%5D.name=ted&test=4&lines%5B3%5D.town=hilton&operation=Submit&ams=1258

The indexed properties (ie ines%5B0%5D.name=tim )are not being parsed, I presume because of the % sign. The following method is never invoked:

public void setLines(Integer index, Line line){
       this.lines.set(index,line);
   }

Question:
1) Do I need to set a <form-property > in struts-config.xml to handle indexed propertiesin the ActionForm?

2) How do I tell my browser (Firefox) ont to encode the brackets [ and ]? I presume that is the source of the problem.

3) How do I tell Struts to decode the %5d %5b characters before the request is parsed?

4) Am I making the wrong assumptions as to where the problem is?

Thanks again for your help on this problem.
Tim

[Sriram Ture]

Tim,


There is no problem with the parsing stuff. Can you paste your form class.

[Tim Kernan]

Sriram
Thanks for you help on this, it is driving me nuts.
Here is my ActionForm class:

-Tim

package NestedIndexTest;

import java.util.ArrayList;

public class NestedIndexPropActionForm extends org.apache.struts.action.ActionForm {

    private String test = "abcd";
    private String ams = "";
    private ArrayList lines;
    private String operation = "";

    public ArrayList getLines_list() {
        return lines;
    }

    public Line getLines(Integer index) {

        return (Line) this.lines.get(index);
    }

    public void setLines(String s) {
        this.test = s;

    }

    public void setLines(Integer index, Line line) {
        this.lines.set(index, line);
    }

    public NestedIndexPropActionForm() {
        super();
        lines = new ArrayList();
        lines.add(new Line("tim", "milton"));
        lines.add(new Line("tom", "wilton"));
        lines.add(new Line("todd", "dilton"));
        lines.add(new Line("ted", "hilton"));


    }

    public String getAms() {
        return ams;
    }

    public void setTest(String s) {
        this.test = s;
    }

    public void setTestb(String s) {
        this.test = s;
    }

    public String getOperation() {
        return operation;
    }

    public void setOperation(String operation) {
        this.operation = operation;
    }
}

Also here is a copy of simple Line

package NestedIndexTest;

import java.io.Serializable;

/*
 * To change this template, choose Tools | Templates
 * and open the template in the editor.
 */

/**
 *
 * @author tim
 */
public class Line implements Serializable {
    private String name="";
    private String town="";



    public String getName() {
        return name;
    }

    public void setName(String name) {
        this.name = name;
    }

    public String getTown() {
        return town;
    }

    public void setTown(String town) {
        this.town = town;
    }

    public Line(){

    }
    public Line(String name,String town){
        this.name = name;
        this.town = town;

    }

[Sriram Ture]

Hi,

This will work fine for you.

public class NestedIndexPropActionForm extends org.apache.struts.action.ActionForm {  
	   
	     private String test = "abcd";  
	     private String ams = "";  
             // Changes
	     private ArrayList lines = new ArrayList();  
	     private String operation = "";  
	   
	     public ArrayList getLines_list() {  
	         return lines;  
	     }  
	   
             // Changes
	     public Line getLines(int index) 
	     { 
                int lineSize = lines.size();
			
	     	if ((index + 1) > lineSize)
			{
				//add objects to arrayList
				for (int j = lineSize; j < index + 1; j++)
				{
					Line line =
						new Line();
					lines.add(j, line);
				}
			}
	        return (Line) this.lines.get(index);  
	     }  
	   
	     public void setLines(String s) {  
	         this.test = s;  
	   
	     }  
	   
	     public void setLines(int index, Line line) {  
	         this.lines.set(index, line);  
	     }  
	   
	     public String getAms() {  
	         return ams;  
	     }  
	   
	     public void setTest(String s) {  
	         this.test = s;  
	     }  
	   
	     public void setTestb(String s) {  
	         this.test = s;  
	     }  
	   
	     public String getOperation() {  
	         return operation;  
	     }  
	   
	     public void setOperation(String operation) {  
	         this.operation = operation;  
	     }  
	 }  

Regards,
Sriram

[Tim Kernan]

Sriram
javascript:emoticon('');
IT worked!!!
I understand the code, but not why it worked. It seem that the key was:
public Line getLines(int index) VS public Line getLines(Integer index)

I persume that without this the BeanUtils parser could not identify the signature of the method to call??

THANKS A TON!!!

-TIm