Rounding BigDecimal Number

[Eshwar Prasad]

I have a requirement where the input number is 30.5 and break up scale is 10. so the out put should be as 10+10+10+0.5

Here,

a) In line 28, I am trying to add the values in variable totalIncome. But it is not getting populated.
b) Each time while rounding the number, I am dividing it with 1 and setting the scale as 2. Is there any other way to do this.
c) Is there any other best way to write this program for the given requirement.

Please give your suggestions and let me know.

Code below.

 	package income;
	
	import java.math.*;
	
	public class BreakupIncome{
		public static void main(String[] args) {
			BigDecimal income = new BigDecimal(75256412.25);
			BigDecimal breakupLimit = new BigDecimal(8888888.88);
			new BreakupIncome().breakupIncome(income,breakupLimit);
		}
	
		/**
		 * @param income
		 * @param breakupLimit
		 */
		public void breakupIncome(BigDecimal income,BigDecimal breakupLimit) {
					income.divide(breakupLimit, BigDecimal.ROUND_UP);
			BigDecimal breakupDivisions = income
					.divideToIntegralValue(breakupLimit);
			
			System.out.println("breakupDivisions::" + breakupDivisions);
			
			BigDecimal breakupRemainder = income.remainder(breakupLimit);
			breakupRemainder = breakupRemainder.divide(new BigDecimal(1), 2,
					BigDecimal.ROUND_UP);	//line 25
			BigDecimal totalIncome=new BigDecimal(0);
			for(int x=0;x<breakupDivisions.intValue();x++){
				totalIncome.add(breakupLimit.divide(new BigDecimal(1), 2,BigDecimal.ROUND_FLOOR)); //line 28
				System.out.println("Total Income:"+" "+totalIncome); // Here I am not getting value populated in totalIncome variable
			}
			totalIncome.add(breakupRemainder);
			
			//BigDecimal totalIncome=breakupDivisions.multiply(breakupLimit).add(breakupRemainder);
			
			System.out.println("Total return income::"+totalIncome.divide(new BigDecimal(1), 2, BigDecimal.ROUND_FLOOR));//line 35
		}
	}
   

>

[Campbell Ritchie]

You really are making things difficult for yourself. Read the API documentation for BigDecimal and you find it mas methods for rounding, and constant ONE which you could use. You should never pass a fractional double to the BigDecimal constructor, because the imprecision in 888888.88 will be perpetuated and immortalised; you should use Strings eg "888888.88".

[Wouter Oet]

BigDecimals are immutable thus the first method call in breakUpIncome is unnecessary.

[Campbell Ritchie]

Wouter Oet wrote:BigDecimals are immutable thus the first method call in breakUpIncome is unnecessary.

. . . and, not being on the right of a = sign, ineffectual.