please correct the code

[akash shrimali]

   void login()
    {
        char password[]=new char[15];
        System.out.println("ONLINE IT HELP DESK\n\n\n\n");
        System.out.println("USER NAME \n\n");
        String j=sc.next();
        System.out.println("PASSWORD \n");
         for(int i=0;i<15;i++)
	
	{
		System.out.print("*");
                
                
		if(password[i]==13)
			break;
                 password[i]='\0';
	}
        
        
    }  

[Rob Spoor]

Correct what? What should it do? What does it do instead? What doesn't it do what it should do? TellTheDetails!

[fred rosenberger]

I'd change it to this

   
void login()
{
   char password[]=new char[15];
   System.out.println("ONLINE IT HELP DESK\n\n\n\n");
   System.out.println("USER NAME \n\n");
   String j=sc.next();
   System.out.println("PASSWORD \n");
   for(int i=0;i<15;i++)
   {
      System.out.print("*");
      if(password[i]==13)
      {
         break;
      }
      password[i]='\0';
   }
}

unless there is some specific problem you are trying to solve.

[David Newton]

I don't get it; password is an array of nothing chars. Are you trying to do something with the input?

[akash shrimali]

i just want that when user inputs password it must be taken in the form
password ********


and want to store those entered characters in array !!!as well how to store the user input in array of character
thats what i need to ask in the code

 
    for(int i=0;i<15;i++)
	
	{
		System.out.println("*");
                password[i]=getch();//what will come in  place of this one 
		if(password[i]==13)
			break;
	}
           

[Shanky Sohar]

have a look at here how to do it..
is simple

Console console = System.console();

char[] pasword;
pasword=console.readPassword(...........);//readPassword return char array

try to implement above line in between your code

[akash shrimali]

its still showing


Exception in thread "main" java.lang.NullPointerException
at javaapplication5.login.login(Main.java:20)
at javaapplication5.login.main(Main.java:34)
Java Result: 1

[Wouter Oet]

System.console() can return null is no console is available. For instance in the netbeans console.

[Shanky Sohar]

could you please show us your new code

[Shanky Sohar]

check out this code.it may contain errors because i have not run it,

import java.io.Console;
import java.util.*;
	public class MainClass {
	  public static void main(String[] args) {
		    Console console = System.console();

		    if (console != null) {
		      System.out.println("Console is not available");
		      System.exit(1);
		    }
		     System.out.println("PASSWORD \n");   
   		    char[] passw; 
		     passw= console.readPassword("[%s]", "Password:") ;
		     for(int i=0;i<=passw.length;i++)   
		     {   
		        System.out.print("*");   
		        if(passw[i]==13)   
		        {   
		           break;   
		        }   
		        passw[i]='\0';   
		     }   
		  }  

		  }
				  
		

[Rob Spoor]

Shanky is right - System.console() is the only way to do this on the console. And Wouter is right too, the console is only available if you launched your application from a real console; IDEs don't have a real console.

Note that you will not get stars; instead nothing is printed at all.

[akash shrimali]

Console console = System.console();

if (console != null) {
System.out.println("Console is not available");
System.exit(1);
}
System.out.println("PASSWORD \n");
char[] passw;
passw= console.readPassword("[%s]", "Password:") ;
for(int i=0;i<=passw.length;i++)
{
System.out.print("*");
if(passw[i]==13)
{
break;
}
passw[i]='\0';
}
}

}
USER NAME


akash
PASSWORD

Exception in thread "main" java.lang.NullPointerException

PASSWORD
at javaapplication5.login.login(Main.java:23)

at javaapplication5.login.main(Main.java:40)
Java Result: 1
BUILD SUCCESSFUL (total time: 2 seconds)

[Campbell Ritchie]

Please use the code tags. You start off with a test if (console != null) . . . and crash if the console is not null. Maybe you meant to use ==

[Raymond Tong]

akash shrimali wrote:

Console console = System.console();  
if (console != null) {  // this is really what you want ?
    System.out.println("Console is not available");  
    System.exit(1);  
}  

[Rene Larsen]

Have you tried the sample listed in the Console API ?? (it works...)

http://download.oracle.com/javase/6/docs/api/java/io/Console.html

[akash shrimali]

Raymond Tong wrote:

akash shrimali wrote:

Console console = System.console();  
if (console != null) {  // this is really what you want ?
    System.out.println("Console is not available");  
    System.exit(1);  
}  

its still giving error in netbeans as null pointer exception , please check in the code

[Wouter Oet]

Shanky Sohar wrote:

for(int i=0;i<=passw.length;i++)    // I would take one less iteration
{   
   System.out.print("*");   
   if(passw[i]==13) {   
      break;   
   }   
   passw[i]='\0';   
}

[Rene Larsen]

akash shrimali wrote:

Raymond Tong wrote:

akash shrimali wrote:

Console console = System.console();  
if (console != null) {  // this is really what you want ?
    System.out.println("Console is not available");  
    System.exit(1);  
}  

its still giving error in netbeans as null pointer exception , please check in the code

It will not work from inside netbeans - you need to run it from terminal (command prompt) where you can get the required console.

[akash shrimali]

Wouter Oet wrote:

Shanky Sohar wrote:

for(int i=0;i<=passw.length;i++)    // I would take one less iteration
{   
   System.out.print("*");   
   if(passw[i]==13) {   
      break;   
   }   
   passw[i]='\0';   
}

passw= console.readPassword() ;
this line is giving the actual problem

[Rene Larsen]

With the sample in the Console API you'll come up with this code:

import java.io.Console;
import java.util.Arrays;

public class MainClass {
    public static void main(String[] args) {
        Console cons;
        char[] passwd = null;
        if ((cons = System.console()) != null
            && (passwd = cons.readPassword("[%s] ", "Password:")) != null) {
            System.out.println(passwd);
            Arrays.fill(passwd, '*');
            System.out.println(passwd);
        }
    }
}