OpenEJB, DI Overriding annotation with deployment descriptor

[Markus Schmider]

I have learned that xml deployment descriptors override annotations.
So I am trying to use that feature to inject a mock implemantion into an EJB for testing:

I am using OpenEJB 3.1.2.

@Stateless
public class TravelAgentBean implements TravelAgentLocal, TravelAgentRemote {

        @EJB(beanName="CreditCardServiceBean")
        CreditCardService creditCardService;
       
        @Override
        public boolean bookHotel(String name, Date begin, Date end, float price, CreditCard creditCard) {

                boolean succesful = false;
               
                succesful = creditCardService.processCreditCard(creditCard, price);
               
                return succesful;

        }

}

@Stateless
public class CreditCardServiceBean implements CreditCardService {

        @Override
        public boolean processCreditCard(CreditCard creditCard,
                        double amount) {
                // TODO The Real Thing
                // Unfortunately not available yet
                throw new NotImplementedException("CreditCardServic is not yet implemented, use the CreditCardServiceMock instead");
        }

}

@Stateless
public class CreditCardServiceMock implements CreditCardService {

        @Override
        /**
         * Mock method, returns simply true to indicate the credit card has been charged
         */
        public boolean processCreditCard(CreditCard creditCard,
                        double amount) {
                return true;
        }

}

The CreditCardServiceBean gets injected into the TravelAgentBean

I try to override this in the ejb-jar.xml:

<ejb-jar version="3.0" xmlns="http://java.sun.com/xml/ns/javaee" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://java.sun.com/xml/ns/javaee http://java.sun.com/xml/ns/javaee/ejb-jar_3_0.xsd">
   <!--  -->
        <enterprise-beans>
                <session>
                        <ejb-name>TravelAgentBean</ejb-name>
                        <ejb-local-ref>
                                <ejb-ref-name>CreditCardServiceMock</ejb-ref-name>
                                <ejb-ref-type>Session</ejb-ref-type>
                                <local>control.CreditCardService</local>
                                <ejb-link>CreditCardServiceMock</ejb-link>
                                <injection-target>
                                        <injection-target-class>boundary.TravelAgentBean</injection-target-class>
                                        <injection-target-name>creditCardService</injection-target-name>
                                </injection-target>
                        </ejb-local-ref>
                </session>
        </enterprise-beans>
       
</ejb-jar>

however testing the whole setup I see that still the CreditCardServiceBean
is injected.
Only when I remove the @EJB(beanName="CreditCardServiceBean") annotation the CreditCardServiceMock is injected.
I don't think thats the expected behavior.
Is something wrong with my deployment desprictor?
Any help would be appreciated.

[Jaikiran Pai]

Your ejb-ref-name should match the "name" of the @EJB (which by default is classname.fieldname). Try this:

@Stateless  
public class TravelAgentBean implements TravelAgentLocal, TravelAgentRemote {  
...
 @EJB(name="ccService" beanName="CreditCardServiceBean")  
 CreditCardService creditCardService;  
 ...
 }

ejb-jar.xml (note the ejb-ref-name now matches the name attribute of @EJB)

...
 <session>
		<ejb-name>TravelAgentBean</ejb-name>
		<ejb-local-ref>
				<ejb-ref-name>ccService</ejb-ref-name>
				<ejb-ref-type>Session</ejb-ref-type>
				<local>control.CreditCardService</local>
				<ejb-link>CreditCardServiceMock</ejb-link>
				<injection-target>
						<injection-target-class>boundary.TravelAgentBean</injection-target-class>
						<injection-target-name>creditCardService</injection-target-name>
				</injection-target>
		</ejb-local-ref>
 </session>
 ...

[David Blevins]

Good catch, Jaikiran!

A nice override/debug option is to set 'openejb.descriptors.output' to 'true'. With that on the effective runtime descriptor is saved to the temp directory. Then you can take a look to see what your xml and annotations look like combined into the final "one true" descriptor.