Menu Items are not appearing.

[Moguluri Ravi Kiran]

Hello Friends , i got a small problem, below is the code. Thanks in advance.
My OS is windows 7.

import javax.swing.*;
import javax.swing.border.*;
import java.awt.*;
import java.awt.event.*;

public class ToolBar extends JFrame
{
  JToolBar toolbar;
  JLabel   statusbar;

  public ToolBar()
  {
    setSize(350,250);
    setTitle("Tool Bar - 1");
    setDefaultCloseOperation(EXIT_ON_CLOSE);
   
    Toolkit tk = getToolkit();
    Dimension d= tk.getScreenSize();

    setLocation(d.width/2-getWidth()/2,d.height/2-getHeight());
    setLocationRelativeTo(null);

    JMenuBar menubar = new JMenuBar();
    
    JMenu file = new JMenu("File");
    JMenu view = new JMenu("View");

    file.setMnemonic(KeyEvent.VK_F);
    view.setMnemonic(KeyEvent.VK_V);

    JMenuItem exit = new JMenuItem("exit");
    final JCheckBoxMenuItem sbar = new JCheckBoxMenuItem("Staus Bar");

    exit.setMnemonic(KeyEvent.VK_X);
    sbar.setMnemonic(KeyEvent.VK_T);sbar.setState(true);

    exit.setAccelerator(KeyStroke.getKeyStroke(KeyEvent.VK_W,ActionEvent.CTRL_MASK));
    sbar.setAccelerator(KeyStroke.getKeyStroke(KeyEvent.VK_S,ActionEvent.CTRL_MASK));

    exit.addActionListener(new ActionListener(){
                            public void actionPerformed(ActionEvent ae){
                            System.exit(0);
                             }});

    sbar.addActionListener(new ActionListener() {
                     public void actionPerformed(ActionEvent ae) {
                     if(statusbar.isVisible())
                     statusbar.setVisible(false);
                     else
                     statusbar.setVisible(true);
                     }});

    file.add(exit);
    view.add(sbar);

    menubar.add(file);
    menubar.add(view);

    statusbar = new JLabel("STATUS BAR");
    statusbar.setBorder(BorderFactory.createEtchedBorder(EtchedBorder.RAISED));
    add(statusbar,BorderLayout.SOUTH);

   setJMenuBar(menubar);
   toolbar = new JToolBar();
   toolbar.add(exit);
   toolbar.add(sbar);

   add(toolbar,BorderLayout.NORTH);

  }
   
   public static void main(String a[])
   {

     new ToolBar().setVisible(true);
   }
}

        

[Michael Dunn]

a component can have only one parent,
so, add 'exit'/'sbar' to the menu or the toolbar, not both

[Moguluri Ravi Kiran]

Thanks for your speedy response. i undestood.

but what if i want a common choice like "SAVE" on File Menu & Tool bar simultaneously..do i need to write extra object(toolbar item that represents same menu item). & do i need to write redundently the Listeners..?

[Michael Dunn]

just add another button to the toolbar (also with e.g. "Exit"),
then set the button's model to that of the exitmenu's model

[Rob Camick]

Moguluri Ravi Kiran wrote:but what if i want a common choice like "SAVE" on File Menu & Tool bar simultaneously..do i need to write extra object(toolbar item that represents same menu item). & do i need to write redundently the Listeners..?

You need to create an Action that can be used by both components:

Action saveAction = new SaveAction();
JMenuItem menuItem = new JMenuItem( saveAction );
JButton button = new JButton( saveAction );

Read the section from the Swing tutorial on How to Use Actions for more information and examples.

[Moguluri Ravi Kiran]

Thanks.
Thank you very much.