# Please critic, rate or give some helpful advice

Dondon Tan

Greenhorn

Posts: 2

posted 5 years ago

Hi, i'm new to this forum. I'm not a programmer by trade in fact i'm still a newbie but can you please rate or critic the way i write codes.

Problem #1 Create a program which will accept integers between 0 - 1000. The program will then add each integer.

Example

Given = 932 Result = 14

Given = 432 Result = 9

This is my answer

Problem #1 Create a program which will accept integers between 0 - 1000. The program will then add each integer.

Example

Given = 932 Result = 14

Given = 432 Result = 9

This is my answer

posted 5 years ago

- 2

Welcome to the Ranch!

This will work as long as you get numbers between 0 and 1000. What will you do if your requirements change, and you should do the same with numbers between 0 and 10.000? And then with numbers between 0 and 100.000? And so on?

One tip: you can do this with a loop and solve it for all kinds of numbers. I'll show you how with your example.

Start: number left = 432, sum = 0

Iteration 1: number left = 43, sum = 2

Iteration 2: number left = 4, sum = 2 + 3

Iteration 3: number left = 0, sum = 2 + 3 + 4

Nothing more to add so stop the loop.

Let's now use a larger number:

Start: number left = 987654321, sum = 0

Iteration 1: number left = 98765432, sum = 1

Iteration 2: number left = 9876543, sum = 1 + 2

...

Iteration 8: number left = 9, sum = 1 + 2 + 3 + 4 + 5 + 6 + 7 + 8

Iteration 9: number left = 0, sum = 1 + 2 + 3 + 4 + 5 + 6 + 7 + 8 + 9

Nothing more to add so stop the loop.

Now I'm sure you can translate this into code.

This will work as long as you get numbers between 0 and 1000. What will you do if your requirements change, and you should do the same with numbers between 0 and 10.000? And then with numbers between 0 and 100.000? And so on?

One tip: you can do this with a loop and solve it for all kinds of numbers. I'll show you how with your example.

Start: number left = 432, sum = 0

Iteration 1: number left = 43, sum = 2

Iteration 2: number left = 4, sum = 2 + 3

Iteration 3: number left = 0, sum = 2 + 3 + 4

Nothing more to add so stop the loop.

Let's now use a larger number:

Start: number left = 987654321, sum = 0

Iteration 1: number left = 98765432, sum = 1

Iteration 2: number left = 9876543, sum = 1 + 2

...

Iteration 8: number left = 9, sum = 1 + 2 + 3 + 4 + 5 + 6 + 7 + 8

Iteration 9: number left = 0, sum = 1 + 2 + 3 + 4 + 5 + 6 + 7 + 8 + 9

Nothing more to add so stop the loop.

Now I'm sure you can translate this into code.

SCJP 1.4 - SCJP 6 - SCWCD 5 - OCEEJBD 6 - OCEJPAD 6

How To Ask Questions How To Answer Questions

posted 5 years ago

- 1

Dondon,

Welcome to CodeRanch!

While your code is fine, you asked for a code review - so two tips:

1) You don't appear to use x3 and x4 so I would recommend removing them. If this were a real program that someone had to maintain, it would be clearer.

2) I would name x1 "firstDigit" or something that made it clearer what it is.

Welcome to CodeRanch!

While your code is fine, you asked for a code review - so two tips:

1) You don't appear to use x3 and x4 so I would recommend removing them. If this were a real program that someone had to maintain, it would be clearer.

2) I would name x1 "firstDigit" or something that made it clearer what it is.

[OCA 8 book] [OCP 8 book] [Blog] [JavaRanch FAQ] [How To Ask Questions The Smart Way] [Book Promos]

Other Certs: SCEA Part 1, Part 2 & 3, Core Spring 3, TOGAF part 1 and part 2

Dondon Tan

Greenhorn

Posts: 2

It is sorta covered in the JavaRanch Style Guide. |