NumberFormatException while inserting data into database

[Kunal Lakhani]

In my project, I have created a functionality which registers Editors.
For this, I have used bean class, jsp, Servlet and a Dao class.

EditorBean.java

package org.Cmtes.Imm.Bean;

import java.io.Serializable;
import java.util.Date;


public class EditorBean implements Serializable {
	
	private Long id;
	private String username;
	private String password;
	private String address;
	private Long contact;
	private String email;
	private String area;
	private String date;
	
	public EditorBean() {}

	public Long getId() {
		return id;
	}

	public void setId(Long id) {
		this.id = id;
	}

	public String getUsername() {
		return username;
	}

	public void setUsername(String username) {
		this.username = username;
	}

	public String getPassword() {
		return password;
	}

	public void setPassword(String password) {
		this.password = password;
	}

	public String getAddress() {
		return address;
	}

	public void setAddress(String address) {
		this.address = address;
	}

	public Long getContact() {
		return contact;
	}

	public void setContact(Long contact) {
		this.contact = contact;
	}

	public String getEmail() {
		return email;
	}

	public void setEmail(String email) {
		this.email = email;
	}

	public String getArea() {
		return area;
	}

	public void setArea(String area) {
		this.area = area;
	}

	public String getDate() {
		return date;
	}

	public void setDate(String date) {
		this.date = date;
	}
}

EditorServlet

package org.Cmtes.Imm.Servlet;

import java.io.IOException;
import javax.servlet.*;
import javax.servlet.http.HttpServlet;
import javax.servlet.http.HttpServletRequest;
import javax.servlet.http.HttpServletResponse;

import org.Cmtes.Imm.Bean.EditorBean;
import org.Cmtes.Imm.Dao.EditorDao;

public class EditorServlet extends HttpServlet {
	public void doPost(HttpServletRequest request ,HttpServletResponse response ) 
	throws ServletException, IOException {
		
		String Id = request.getParameter("t1");
		
		Long id = Long.parseLong(Id);
		String username = request.getParameter("t2");
		System.out.println(username);
		//String password = request.getParameter("t3");
		String address = request.getParameter("t4");
		String cont = request.getParameter("t5");
		long contact = Long.parseLong(cont);
		String email = request.getParameter("t6");
		String area = request.getParameter("t7");
		String date = request.getParameter("t8");

		EditorBean eb = new EditorBean();
		eb.setId(id);
		eb.setUsername(username);
		eb.setPassword(username);
		eb.setAddress(address);
		eb.setContact(contact);
		eb.setEmail(email);
		eb.setArea(area);
		eb.setDate(date);
		
		System.out.println("password is "+eb.getPassword());
		
		EditorDao edao = new EditorDao();
		boolean status = edao.addEditor(eb);
		if(status==true){
			response.sendRedirect("Success.jsp");
		}
		else {
			response.sendRedirect("Failure.jsp");
		}	
	}
}

EditorDao.java

package org.Cmtes.Imm.Dao;

import java.sql.*;
import org.Cmtes.Imm.Bean.EditorBean;

public class EditorDao {
	Connection con;
	public EditorDao()
	{
		try
		{
			Class.forName("oracle.jdbc.driver.OracleDriver");
			con = DriverManager.getConnection("jdbc:oracle:thin:@localhost:1521:oracle","scott","tiger");
		}
		catch(Exception e){
			System.out.println("Couldn't get the Connection");
		}
	}
	public boolean addEditor(EditorBean eb) {
		try {

			String query = "Insert into Editors values (?,?,?,?,?,?,?,?)";
			PreparedStatement ps = con.prepareStatement(query);
			ps.setLong(1, eb.getId());
			ps.setString(2, eb.getUsername());
			ps.setString(3, eb.getPassword());
			ps.setString(4, eb.getAddress());
			ps.setLong(5, eb.getContact());
			ps.setString(6, eb.getEmail());
			ps.setString(7, eb.getArea());
			ps.setString(8, eb.getDate());
			ps.execute();
			con.close();		
		}
		catch(Exception e){
			e.printStackTrace();
			return false;
		}
		return true;
	}
	public int loadID()
	{
		int no=0;
		try
		{
			String str="Select Max(ID) from Editors";
			Statement stmt=con.createStatement();		
			ResultSet rs=stmt.executeQuery(str);

			try
			{
				if(rs.next())
					no=Integer.parseInt(rs.getString("ID"))+1;
			}
			catch(Exception e)
			{
				no=1001;
			}
			stmt.close();
		}
		catch(Exception e)
		{
			e.printStackTrace();
		}

		return no;
	}
}

Web.xml

<?xml version="1.0" encoding="UTF-8"?>
<web-app version="2.5" 
	xmlns="http://java.sun.com/xml/ns/javaee" 
	xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" 
	xsi:schemaLocation="http://java.sun.com/xml/ns/javaee 
	http://java.sun.com/xml/ns/javaee/web-app_2_5.xsd">
	<servlet>
	<servlet-name>Edit</servlet-name>
	<servlet-class>org.Cmtes.Imm.Servlet.EditorServlet</servlet-class>
	</servlet>
	
	
	<servlet-mapping>
	<servlet-name>Edit</servlet-name>
	<url-pattern>/edit</url-pattern>
	</servlet-mapping>
	
  <welcome-file-list>
    <welcome-file>index.jsp</welcome-file>
  </welcome-file-list>
</web-app>

AddEditor.jsp

<%@ page language="java" import="java.text.*, java.util.*, org.Cmtes.Imm.Dao.*" %>

<%
		Format formatter = new SimpleDateFormat("dd-MMM-yyyy");
		Date date = new Date();
		String date1 = formatter.format(date);
		
		EditorDao edao = new EditorDao();
		int x = edao.loadID();
%>


<html>
<body>
<form action="./edit" method="POST">
<br>
<table>
 <tr>
 <th >Editor's Id : </th>
 <td><input type="text" name="t1" value="<%=x %>" disabled></td>
 </tr>
 <tr>
 <th >UserName:</th>
 <td><input type="text" name="t2" ></td>
 </tr>
 <tr>
 <th >Address:</th>
 <td><input type="text" name="t4" ></td>
 </tr>
 <tr>
 <th >Contact:</th>
 <td><input type="text" name="t5" ></td>
 </tr>
 <tr>
 <th >E-mail id:</th>
 <td><input type="text" name="t6" ></td>
 </tr>
 <tr>
 <th >Area:</th>
 <td><input type="text" name="t7" ></td>
 </tr>
 <tr>
 <th >Date of joining:</th>
 <td><input type='text' name='t8' size=15 value='<%=date1 %>' disabled></td>
 </tr>
 </table>
<p/><input type="submit" value="submit">
</form>
</body>
</html>

I have a “Editors” table in database with following columns:
SQL> desc editors;


Name Null? Type
----------------------------------------- -------- ----------------------------
ID NOT NULL NUMBER(5)
USERNAME VARCHAR2(30)
PASSWORD VARCHAR2(30)
ADDR VARCHAR2(30)
CNO NUMBER(10)
EMAIL VARCHAR2(30)
AREA VARCHAR2(30)
DOJ DATE

<SQL>




On running the application using tomcat 6, I am getting exception with the following stack trace :
HTTP Status 500 -
________________________________________
type Exception report
message
description The server encountered an internal error () that prevented it from fulfilling this request.
exception
java.lang.NumberFormatException: null
java.lang.Long.parseLong(Unknown Source)
java.lang.Long.parseLong(Unknown Source)
org.cmtes.Editor.Servlet.EditorServlet.doPost(EditorServlet.java:21)
javax.servlet.http.HttpServlet.service(HttpServlet.java:637)
javax.servlet.http.HttpServlet.service(HttpServlet.java:717)
note The full stack trace of the root cause is available in the Apache Tomcat/6.0.29 logs.
________________________________________
Apache Tomcat/6.0.29

[Christophe Verré]

Close all your input tags and retry.

[Kunal Lakhani]

i have tried that. but still, it showing the same error

I am inputing the following data:

Editor's Id : (Successfully Self generated)
UserName: kunal
Address: Samlong
Contact: 1234
E-mail id: abc
Area: Ranchi
Date of joining: (successfully Self generated)

[Christophe Verré]

On your webpage, what's the value of your "t1" textbox ?

[Kunal Lakhani]

"t1" related to my id, which is self generated.

EditorDao

 public int loadID()   
    {   
        int no=0;   
        try  
        {   
            String str="Select Max(ID) from Editors";   
            Statement stmt=con.createStatement();          
            ResultSet rs=stmt.executeQuery(str);   
  
            try  
            {   
                if(rs.next())   
                    no=Integer.parseInt(rs.getString("ID"))+1;   
            }   
            catch(Exception e)   
            {   
                no=1001;   
            }   
            stmt.close();   
        }   
        catch(Exception e)   
        {   
            e.printStackTrace();   
        }   
  
        return no;   
    }   
}  

AddEditor.jsp

 EditorDao edao = new EditorDao();   
        int x = edao.loadID();   

The id generated is 1001.

[Christophe Verré]

I mean, what is shown on your web browser ? Does the "Editor's Id" textbox show any value ?

[Kunal Lakhani]

Yes, it shows 1001

[Christophe Verré]

What about "Contact" ("t5") ? Did you enter a value in it ?

[Eduardo Yañez Parareda]

Kunal Lakhani wrote:
The id generated is 1001.

So rs.getString("ID") is null

[Christophe Verré]

Eduardo Yañez Parareda wrote:

Kunal Lakhani wrote:
The id generated is 1001.

So rs.getString("ID") is null

But that is not a problem.

[Kunal Lakhani]

yes Eduardo Yañez Parareda. That's only generating 1001.


Christophe Verré , yes i am entering values in t5, (value-123)

[Eduardo Yañez Parareda]

Kunal Lakhani wrote:yes Eduardo Yañez Parareda. That's only generating 1001.


Christophe Verré , yes i am entering values in t5, (value-123)

Print us the correct stacktrace because what you printed doesn't correspond with the source code you posted. Line 21 from EditorServlet is commented out...

[Mohamed Sanaulla]

The cause for exception is seen at this line: org.cmtes.Editor.Servlet.EditorServlet.doPost(EditorServlet.java:21)

But its is commented out. Can you post the code which caused the exception?

[Kunal Lakhani]

Eduardo Yañez Parareda, The stack trace i printed is correct.

[Eduardo Yañez Parareda]

Kunal Lakhani wrote:Eduardo Yañez Parareda, The stack trace i printed is correct.

I'm sorry, but it's impossible to have an exception caused in a commented out line...

[Mohamed Sanaulla]

Eduardo Yañez Parareda wrote:

Kunal Lakhani wrote:Eduardo Yañez Parareda, The stack trace i printed is correct.

I'm sorry, but it's impossible to have an exception caused in a commented out line...

+1 here. Without the correct code we cannot tell the cause for that exception.

[R Patel]

Hi,

I can see one issue is, your "t1" field is disabled. so whenever your form is getting submit, that field value will not get submit. So i suggest you can take that value under hidden variable. and can change the below line to new as i have mentioned.

existing line:

<td><input type="text" name="t1" value="<%=x %>" disabled></td> 

replace above line with below lines.

<td><input type="text" value="<%=x %>" disabled></td> 
<input type="hidden" name="t1" value="<%=x %>">

Regards,
Ronak.

[Jan Cumps]

I'm sorry, but it's impossible to have an exception caused in a commented out line...

The line numbering in this post doesn't neccessary match with the line numbering in the source file. Let's ask Kunal what the exact piece of code is where the exception is thrown.


Kunal, Can you tell us what this piece of code is in your original source file:
EditorServlet.java:21 ?

[Kunal Lakhani]

I am confused friends.

The problem has been solved. What i did is, removed the commented line & closed MyEclipse IDE & started it again.
I don't know what is happening. At present, i am executing the same code, and its running fine. This is the 2nd time i am facing such problem. And if i am changing the code in MyEclipse, to make it to come into effect, i need to restart the IDE, its not getting refreshed while compiling it again

Can anyone tell the reason for same?

[Kunal Lakhani]

Also, how to replace this scriptlets from EL in my jsp??

# <%  
#         Format formatter = new SimpleDateFormat("dd-MMM-yyyy");  
#         Date date = new Date();  
#         String date1 = formatter.format(date);  
#           
#         EditorDao edao = new EditorDao();  
#         int x = edao.loadID();  
# %>  

[Mohamed Sanaulla]

Kunal Lakhani wrote:Also, how to replace this scriptlets from EL in my jsp??

# <%  
#         Format formatter = new SimpleDateFormat("dd-MMM-yyyy");  
#         Date date = new Date();  
#         String date1 = formatter.format(date);  
#           
#         EditorDao edao = new EditorDao();  
#         int x = edao.loadID();  
# %>  

Please start a new thread for a new query

[Martin Vajsar]

Although you've probably solved your current problem, a hidden bug is ticking in your code. It is lurking in the following line:

            String query = "Insert into Editors values (?,?,?,?,?,?,?,?)"; 

Never ever use the INSERT statement without specifying the columns into which you're inserting, for two reasons:

1) If the number of columns in the table is changed, your program suddenly stops working. If you specify the columns, and a new nullable column is added (or column with default value specified), the statement will remain functional. New columns may be added for various reasons (eg. auditing, replication) that are independent of your application.

2) The second reason is much more serious. The order of columns in the table is not necessarily fixed. If the table is recreated for some reason, or column is dropped and added again for any reason imaginable (including inept DB admin), the order of columns might change. If you're lucky, your program crashes with a data conversion error, or breaks an existing constraint. However, your code might continue to work, but insert data into columns different from what is intended. If this is not caught early on, your database might get littered with errorneous data that will be difficult to disentangle.