RegularExpression in Java

[James Peter]

Hi All,

Below is my code.

package sample;

import java.util.regex.*;

public class TestClass {

	/**
	 * @param args
	 */
	public static void main(String[] args) {
		String testString ="S&a125";
		String result ="valid";
		//final String PASSWORD_PATTERN = "((?=.*\\d)(?=.*[a-z])(?=.*[A-Z])(?=.*[@#$%])(?=.^.{5,7}$))";
		final String PASSWORD_PATTERN = "((?=.*\\d)(?=.*[a-z])(?=.*[A-Z])(?=.*[@#$%]).{5,7})";
		
		Pattern lowerCasePattern = Pattern.compile( "[a-z]");
		Pattern upperCasePattern = Pattern.compile( "[A-Z]");
		Pattern digitPattern = Pattern.compile( "[0-9]");
		Pattern specialCharsDefaultPattern = Pattern.compile( "[@#$%^&*!]");
		Pattern lengthPattern = Pattern.compile( "^.{5,7}$");
		Pattern allInOnePattern = Pattern.compile(PASSWORD_PATTERN);
		

		Matcher digitMatcher = digitPattern.matcher(testString);
		Matcher lowerCaseMatcher = lowerCasePattern.matcher(testString);
		Matcher upperCaseMatcher = upperCasePattern.matcher(testString);
		Matcher specialCharacterMatcher = specialCharsDefaultPattern.matcher(testString);
		Matcher lengthMatcher = lengthPattern.matcher(testString);
		Matcher allInOneMatcher = allInOnePattern.matcher(testString);
		
		  if ( !lowerCaseMatcher.find() ) {
			  	print("No lowercase letter");
			 	result="invalid";		 
		 }else if ( !upperCaseMatcher.find() ) {
			    print("No uppercase letter");
			    result="invalid";		
		 }else if ( !digitMatcher.find() ) {
			    print("No numeric value");
			    result="invalid";		
		 }else if ( !specialCharacterMatcher.find() ) {
			    print("No Special Character");
			    result="invalid";		
		 }else if ( !lengthMatcher.find() ) {
			    print("Not valid length");
			    result="invalid";		
		 }
		  
		 print("Result is :"+result);
		 
		 if ( !allInOneMatcher.find() ) {
			  	print("Some thing is wrong in input value");
			 			 
		 }else {
			System.out.println("Test passed by AllInOnePattern");
		}

	}
	
	public static void print(String s){
		System.out.println(s);
	}
	

}

if i make individual patterns then output is coming properly.

but i want to get same output with one of below pattern.

		//final String PASSWORD_PATTERN = "((?=.*\\d)(?=.*[a-z])(?=.*[A-Z])(?=.*[@#$%])(?=.^.{5,7}$))";
		final String PASSWORD_PATTERN = "((?=.*\\d)(?=.*[a-z])(?=.*[A-Z])(?=.*[@#$%]).{5,7})";

but both are not working with min max length condition of the string. please let me know where i am doing wrong.

Thanks
Peter


[HENRY: Added Code Tags]

[Wouter Oet]

Please UseCodeTags when posting code. It will highlight your code and make it much easier to read. It probably will also increase the number of people helping you. Also use proper indentation. This is hard to read. You can edit your post with the button.

[Henry Wong]

James Peter wrote:
but both are not working with min max length condition of the string. please let me know where i am doing wrong.

How are you using the expression? Are you using the find() method? Or the matches() method?

With the second password pattern, the matches() method should work (or at least, by eyeballing it, I didn't actually try it out).

Henry

[James Sabre]

1) You haven't included '&' in your set of 'special' characters!
2) You need to use matches() and not find() or the length check term will pass for lengths greater than 7.

P.S. What business case can be made for limiting a password to less than 8 characters? Seems daft to me as presumably one is only storing a seeded digest and not the full password and it reduces significantly the entropy of the allowable passwords.

[James Peter]

Hi Henry,

Thanks for adding code tag. I was about to do that.

Hi James,

thanks for your comment. I forgot to add "&" character in the set. after adding it is working fine.


Rgds
Peter

[James Sabre]

James Peter wrote:Hi Henry,

Thanks for adding code tag. I was about to do that.

Hi James,

thanks for your comment. I forgot to add "&" character in the set. after adding it is working fine.


Rgds
Peter

But did you fix the 'length' term and change to use matches() rather than find()?

[James Peter]

yes James, I changed and it is working.