Simple file question

[abalfazl hossein]

import java.io.*;

public class Main {

    /**
     * @param args the command line arguments
     */
    public static void main(String[] args) throws IOException{

      
        FileInputStream in = null;

        try {
            in = new FileInputStream("myfile1.txt");

            InputStreamReader inchar = new InputStreamReader(in);

        System.out.println("Text from file ");

        //Reads a single character.
        System.out.println(inchar.read());

        } finally {
            
                inchar.close();
            

        }
    }

}

It has problem about this line:

  inchar.close();

[Wouter Oet]

That's because that variable is declared inside of the try block and because of that it's not visible from outside of the try block.
The solution: declare the variable outside of the try block and initialize it inside of it.

[Ralph Cook]

I'm going to guess that your compiler complains about the variable "inchar", because it is out of scope on that line. You declare it within the braces of your "try" block, so it is not visible within the braces of the "finally" block.

I have to guess because you have not provided us with an error message. In the future, I recommend that you give a little more information about what the problem really is -- if this had not been pretty obvious to me, I wouldn't have made a guess, and I wouldn't have searched hard. To get good help with questions, you need to provide folks with as much information as you can easily get, at least.

You might also try looking at the error message. One of the really good things about Java is the accuracy of its compiler's messages, i.e., it *usually* tells you exactly what is wrong and where.

rc

[abalfazl hossein]

package filereadchar;
import java.io.*;
public class Main {
    
    public static void main(String[] args) throws IOException{

      
        FileInputStream in = null;
        InputStreamReader inchar=null;

        try {
             in = new FileInputStream("myfile1.txt");
             inchar = new InputStreamReader(in);
             System.out.println("Text from file ");

             //Reads a single character.
             System.out.println(inchar.read());

        } finally {
                inchar.close();
         }
    }
}

Any suggestion to make it better?

[fred rosenberger]

abalfazl hossein wrote:It has problem about this line:

  inchar.close();

Please read our FAQs on why ItDoesntWorkIsUseless and why you should TellTheDetails.

(you can click on those phrases to be taken directly to the specific FAQ).

[Rob Spoor]

abalfazl hossein wrote:Any suggestion to make it better?

How about a null check? What will happen if the FileInputStream cannot be created? In other words, if line 12 throws an exception?