Resultset not Open?

[Qaiser Mehmood]

I get following error on Result set
java.sql.SQLException: ResultSet not open. Verify that autocommit is OFF.
at org.apache.derby.client.am.SQLExceptionFactory40.getSQLException(Unknown Source)
at org.apache.derby.client.am.SqlException.getSQLException(Unknown Source)
at org.apache.derby.client.am.ResultSet.next(Unknown Source)

public  ResultSet insertDb(int Id,String firstName,String lastName,String title) throws SQLException{
        try {
            try {
                Class.forName(driver);
                con = DriverManager.getConnection(connectionURL);
                 
                } catch (SQLException ex) {
                Logger.getLogger(Connect.class.getName()).log(Level.SEVERE, null, ex);
                } catch (ClassNotFoundException ex) {
                Logger.getLogger(Connect.class.getName()).log(Level.SEVERE, null, ex);
                }
    System.out.println(con.getAutoCommit());
    statement = con.createStatement() ;
    res = statement.executeQuery("SELECT * FROM CUSTOMER") ;
    con.setAutoCommit(false);
    System.out.println(con.getAutoCommit());
     
    while(res.next()){
        if(res.getString("ID").equalsIgnoreCase(Integer.toString(Id))){
            UNIQUE = false;
             error= "Duplicate Entry Found Please Enter New Data";
            throw new SQLException("Duplicate info<br>ID " + Id );
 
        }
    }
    // IF value to be added IS UNIQUE
    if(UNIQUE){
        String qry1= "insert into CUSTOMER(ID, FIRSTNAME,LASTNAME,TITLE) values(?,?,?,?)";
        stm  = con.prepareStatement(qry1);
        String ID=Integer.toString(Id);
        stm.setString(1, ID);
        stm.setString(2, firstName);
        stm.setString(3, lastName);
        stm.setString(4, title);
        stm.executeUpdate();
    }
}
catch(Exception e){
    String errorMessage = "Exception caught : ";
    System.out.println(errorMessage + e.toString());
 
}finally{   
    if (con != null){
    con.close();
    }
        }
 
return res;
    }

[Jan Cumps]

You close the connection in your finally block. This will also close the ResultSet 'res' that you return.

[Qaiser Mehmood]

Reultset res is outside finaly block.

[Paul Sturrock]

Qaiser Mehmood wrote:Reultset res is outside finaly block.

Not sure what you mean by that, but Jan is right. Your method returns a ResultSet that is closed, because you closed it in your finally block (by closing the connection).