jsp postgress connection

[ankur mawandia]

i am trying to connect a jsp page to the postgres db

i have written a html form and i am trying to post the data to the database

i am reciving an error

the jsp page is

<%@ page language="java" import="java.sql.*" %>
      <%
      String url = "jdbc:postgresql://localhost:5432/sample", user="postgres", passwd="ankur";
      Class.forName ("org.postgresql.Driver");
      Connection myConn = DriverManager.getConnection("jdbc:postgresql://localhost:5432/sample", "postgres", "ankur");
      Statement myStatement = myConn.createStatement ();
 String StrUser = request.getParameter("username");
 String StrPass = request.getParameter("password"); 
 String FirstName = request.getParameter("firstname"); 
 String MiddleName = request.getParameter("middlename"); 
 String LastName = request.getParameter("lastname");
String Dob = request.getParameter("dob"); 
 String City = request.getParameter("city"); 
 String State = request.getParameter("state"); 
 String Country = request.getParameter("country"); 
myStatement.executeUpdate("INSERT INTO Details([UserName], [Password], [FirstName], [MiddleName], [LastName],[DOB], [City], [State], [Country]) VALUES ('"+StrUser+"', '"+StrPass+"' , '"+FirstName+"', '"+MiddleName+"' , '"+LastName+"', '"+Dob+"', '"+City+"', '"+State+"', '"+Country+"')"); 
myStatement.close();
      myConn.close();

            %>

the error says
org.apache.jasper.JasperException: javax.servlet.ServletException: org.postgresql.util.PSQLException: ERROR: syntax error at or near "["
Position: 18

ng


thnx in advance
also i am still new so please point out the errors i am making

thnx

[Bear Bibeault]

Why is this code in a JSP rather than properly in a servlet?

[ankur mawandia]

i just want to check wether my postgres driver is properly installed or not.....and wether i can conncet to the database or not

[Sunny Bhandari]

I am not familiar with postgress but will advise to debug the code to check that the source of error is the INSERT statement.

You can also write a java class for that...

[Bear Bibeault]

Do it in a Java class like a servlet. Doing this in a JSP is a poor practice and problematic.

Compiling a Java class is likely to give you better error messages as well.

[Jeanne Boyarsky]

Ankur,
Welcome to CodeRanch!

I agree that it would be better to move this code out of the JSP. As for your error, it looks like you are connecting to the database and getting an error running the insert. There aren't braces around the column names in an insert. You can try running the SQL statement at the postgres command line to make sure it works.

[ankur mawandia]

thank you so much bear and jeanne..for your valueble sujjestion

the problems was in the query as you said
can you tell me how to set this properly in a servelet

[Vijitha Kumara]

...can you tell me how to set this properly in a servelet

Modern JSPs should not contain any Java code (if possible even the old code should not). Move them to controller/model classes appropriately.

If you are new to web development you may want to look at the MVC pattern.