Using System.currentTimeMillis() method

[Roger Fed]

hello
I've developed this time class
A no-arg constructor that creates a Time object for the current time. (The data fields value will represent the current time)
when running the program it display the hour data field decreased by 2 hours
is there any reason for this??
thanks in advance

public class Main {
    public static void main(String[] args) {
        Time time1=new Time();
        System.out.println("For first object:"+time1.getHour()+':'+time1.getMinute()+':'+time1.getSecond());
}

this is the Time class

public class Time {
    private int hour;
    private int minute;
    private int second;
    ////////////////////
    public Time()
    {
        long totalMilliSeconds=System.currentTimeMillis();
        long totalSeconds=totalMilliSeconds/1000;
        this.second=(int)(totalSeconds%60);
        long totalMinutes=totalSeconds/60;
        this.minute=(int)(totalMinutes%60);
        long totalHours=totalMinutes/60;
        this.hour=(int)(totalHours%24);
    }
    public int getHour(){
        return hour;
    }
    public int getMinute(){
        return minute;
    }
    public int getSecond(){
        return second;
    }
    public void display()
    {
        System.out.println("Time:"+hour+":"+minute+":"+second);
    }


}

[Bear Bibeault]

Time zone difference?

[Ernie Mcracken]

Works fine for me..

Time:21:18:55

[Rob Spoor]

One hour off here, and the reason is probably quite simple: daylight savings time. Your code assumes that each and every day since the epoch, January 1st 1970 at 0:00:00, is 24 hours. That assumption is wrong; there are days with 23 hours and days with 25 hours.

If you need this Time class you probably want to use java.util.Calendar to calculate the current values:

public Time()
{
    Calendar calendar = Calendar.getInstance();
    this.second = calendar.get(Calendar.SECOND);
    this.minute = calendar.get(Calendar.MINUTE);
    this.hour = calendar.get(Calendar.HOUR_OF_DAY);
}

[Roger Fed]

Thanks very much for helping me

[Rob Spoor]

You're welcome.

[Campbell Ritchie]

Even worse, the "epoch" was in GMT, but we had summer time all winter here in Britain in 1970, so the clocks all showed 1.00am then.