Problem regarding a field of type Bigdecimal

[nav katoch]

Hi all,

I don't know if this is the right forum to post my question. If it is not, then move to the right place. I have three conditions. I have three fields of type BigDecimal.
1. If I enter $100.00 in one field, then it should show $100.00 in the second field and $75 in the third field which is working fine.
2. If I enter $0.00 in one field, then it should show $0.00 amounts in other fields which is working fine too.
3. If I enter nothing or blank, then it should show blank for all the fields based on my condition but this is not working for second and the third fields and it reads the value from the first field.

I have the following code, so please guide me in this regard.

public class LITI_AutoPopEsStHghEsStLOnAssdAmnt extends TCDefaultActionHandler{
    TNProject dispute;
		
	public void action() {
		YNUser currentUser = FNUtility.getCurrentUser();
        TCLog.getRuleLogger().debug("In action() method Current User is ::--> " + currentUser);
		try{		
			FNUtility.switchToSystemUser();
			TCLog.getRuleLogger().debug("Running rule LITI_AutoPopEsStHghEsStLOnAssdAmnt::--> ");
			dispute = (TNProject) getObject();
            
            BNDetail disputeDetail = dispute.getDetailForKey("LITI");
            TNProject disputePA = (TNProject)disputeDetail.getDetailObjfValueForKey("LiPAPracticeArea");
            
            BigDecimal estimatedSettlementHigh;
            BigDecimal estimatedSettlementLow;
            BigDecimal authAssessedAmount = new BigDecimal(0);
            
            BigDecimal oneHundred = new BigDecimal ("100");
            BigDecimal seventyFive = new BigDecimal ("75");
            
            if((disputePA.getName().equals("Company Car")) || (disputePA.getName().equals("Premises")) || (disputePA.getName().equals("Product")) ){
                TCLog.getRuleLogger().debug("In Practice Area condition::--> ");
                authAssessedAmount = dispute.getDetailForKey("LITI").getDetailNumbValueForKey("LiAsAuthorizedAmount");
                TCLog.getRuleLogger().debug("authAssessedAmount ::--> " + authAssessedAmount);                
                    if(authAssessedAmount.equals("")){
                    TCLog.getRuleLogger().debug("In authAssessedAmount if condition:: authAssessedAmount==null ::--> " + authAssessedAmount);
                    dispute.getDetailForKey("LITI").setDetailNumbValueForKey(authAssessedAmount, "LiAsEstimatedSettlementHigh");
                    dispute.getDetailForKey("LITI").setDetailNumbValueForKey(authAssessedAmount, "LiAsEstimatedSettlementLow");
                }
                              
                dispute.getDetailForKey("LITI").setDetailNumbValueForKey(authAssessedAmount, "LiAsEstimatedSettlementHigh");
                estimatedSettlementHigh = dispute.getDetailForKey("LITI").getDetailNumbValueForKey("LiAsEstimatedSettlementHigh");
                TCLog.getRuleLogger().debug("In Practice Area condition:: estimatedSettlementHigh --> " + estimatedSettlementHigh);
                        
                if(authAssessedAmount != null){
                    estimatedSettlementLow = 
                        dispute.getDetailForKey("LITI").getDetailNumbValueForKey("LiAsAuthorizedAmount").multiply(seventyFive).divide(oneHundred);
                    TCLog.getRuleLogger().debug("In Practice Area condition estimatedSettlementLow::--> " + estimatedSettlementLow);
                    dispute.getDetailForKey("LITI").setDetailNumbValueForKey(estimatedSettlementLow, "LiAsEstimatedSettlementLow");
                }
                
                                                
            }
				
            
            
		}	finally {
			FNUtility.switchToUser(currentUser);
		}
	}

	public void parameterDeclaration() {
		// TODO Auto-generated method stub LiAsEstimatedSettlementLow
		
	}  

Thank you so much for your time.

Naveen Katoch

[Wouter Oet]

authAssessedAmount is an BigInteger and comparing it to a String doesn't work.

You should really reconsider renaming the class and method. Because what is a LITI_AutoPopEsStHghEsStLOnAssdAmnt?
You can't derive that from the name. And what does action do?

[Campbell Ritchie]

You might also consider an enum for the type of Action. Or maybe putting action types into a Map. Those multiple ||s are potentially error-prone. What happens if you add "Employment" as a potential type of dispute? What happens if your dispute is about a "Company car"?

[nav katoch]

Thank you so much Wouter and Campbell for your inputs. I will workaround. If I could not resolve this issue, then I will ask this in SCJP forum.

Thanks again,

Naveen Katoch

[Jesper de Jong]

nav katoch wrote:If I could not resolve this issue, then I will ask this in SCJP forum.

Why? This does not look like it has anything to do with the SCJP certification exam. Please stay in this topic with regard to this issue.

[Campbell Ritchie]

You're welcome

nav katoch wrote:. . . I will workaround. . . .

I am sure that by "workaround" you mean you will create a good solid solution, but workaround often means a Heath Robinson sort of solution which can be brittle and introduce more errors.

[nav katoch]

Hi Campbell,

I have resolved the issue with the following code and set my operator to Not Populated in my rule:-

public class LITI_AutoPopEsStHghEsStLOnAssdAmnt extends TCDefaultActionHandler{
    TNProject dispute;

    public LITI_AutoPopEsStHghEsStLOnAssdAmnt(){
    }

    public void action(){
        com.mitratech.teamconnect.entity.YNUser currentUser;
        currentUser = FNUtility.getCurrentUser();
        TCLog.getRuleLogger().debug((new StringBuilder("In action() method Current User is ::--> ")).append(currentUser).toString());
        try{
            FNUtility.switchToSystemUser();
            TCLog.getRuleLogger().debug("Running rule LITI_AutoPopEsStHghEsStLOnAssdAmnt::--> ");
            dispute = (TNProject)getObject();
            BNDetail disputeDetail = dispute.getDetailForKey("LITI");
            TNProject disputePA = (TNProject)disputeDetail.getDetailObjfValueForKey("LiPAPracticeArea");
            BigDecimal authAssessedAmount = new BigDecimal(0);
            BigDecimal oneHundred = new BigDecimal("100");
            BigDecimal seventyFive = new BigDecimal("75");
            if(disputePA.getName().equals("Company Car") || disputePA.getName().equals("Premises") || disputePA.getName().equals("Product")){
                TCLog.getRuleLogger().debug("In Practice Area condition::--> ");
                authAssessedAmount = dispute.getDetailForKey("LITI").getDetailNumbValueForKey("LiAsAuthorizedAmount");
                if(authAssessedAmount == null)
                    authAssessedAmount = new BigDecimal("0");  
                
                TCLog.getRuleLogger().debug((new StringBuilder("authAssessedAmount ::--> ")).append(authAssessedAmount).toString());
                if(authAssessedAmount.intValue() == 0){
                    TCLog.getRuleLogger().debug((new StringBuilder("In authAssessedAmount if condition:: authAssessedAmount==null ::--> ")).append(authAssessedAmount).toString());
                    dispute.getDetailForKey("LITI").setDetailNumbValueForKey(authAssessedAmount, "LiAsEstimatedSettlementHigh");
                    dispute.getDetailForKey("LITI").setDetailNumbValueForKey(authAssessedAmount, "LiAsEstimatedSettlementLow");
                } else{
                    dispute.getDetailForKey("LITI").setDetailNumbValueForKey(authAssessedAmount, "LiAsEstimatedSettlementHigh");
                    BigDecimal estimatedSettlementHigh = dispute.getDetailForKey("LITI").getDetailNumbValueForKey("LiAsEstimatedSettlementHigh");
                    TCLog.getRuleLogger().debug((new StringBuilder("In Practice Area condition:: estimatedSettlementHigh --> ")).append(estimatedSettlementHigh).toString());
                    BigDecimal estimatedSettlementLow = dispute.getDetailForKey("LITI").getDetailNumbValueForKey("LiAsAuthorizedAmount").multiply(seventyFive).divide(oneHundred);
                    TCLog.getRuleLogger().debug((new StringBuilder("In Practice Area condition estimatedSettlementLow::--> ")).append(estimatedSettlementLow).toString());
                    dispute.getDetailForKey("LITI").setDetailNumbValueForKey(estimatedSettlementLow, "LiAsEstimatedSettlementLow");
                }
            }
        }catch(Exception e){
            throw new TCApplicationException(e.getMessage());
        }finally {
            FNUtility.switchToUser(currentUser);
        }
               
    }   
    
    public void parameterDeclaration(){
    }
   
}

Thanks for your time. I appreciate you all.

Naveen Katoch

[Wouter Oet]

I've got some more remarks:

(Still) the class name
Line 11: TCLog.getRuleLogger().debug((new StringBuilder("In action() method Current User is ::--> ")).append(currentUser).toString()); Why not just concatenate with +?
Line 16: Why not use this object through out the method instead of getting it constantly with dispute.getDetailForKey("LITI");
Line 18: Why declare it there when it only gets used in the if-block and gets assigned there?
Line 19: Why declare it there when it only gets used on line 36?
Line 20: Why declare it there when it only gets used on line 36?
Line 30 & 33 in if and else part are the same.
Line 34: didn't you just set that?
Line 36: you're multiplying it with 75 and then 100? Why not multiply it with 7500?
Line 42: why not chain the exceptions and retain the stacktrace?

[nav katoch]

Hi Wouter,

Thank you so much for bringing these points in my notice. I highly appreciate your time and suggestion. I will modify it accordingly.

Naveen Katoch

[Wouter Oet]

You're welcome.

I just thought of another remark: line 18 & 25 can be modified to use BigDecimal.ZERO.

[Jesper de Jong]

Wouter Oet wrote:Line 36: you're multiplying it with 75 and then 100? Why not multiply it with 7500?

He's not multiplying by 75 and 100, but multiplying by 75 and dividing by 100.

[Rob Spoor]

So multiplying by a new BigDecimal("0.75") would work just as well.

[Campbell Ritchie]

Rob Spoor wrote:So multiplying by a new BigDecimal("0.75") would work just as well.

It wouldn't work as well at all. It would work better because there is only one new BigDecimal object created.