Apache Commons FileUpload with Zip Files

[Awet Haddis]

I am using the Apache FileUpload library to allow a user to upload a .zip file to my webpage. The trouble is, the library seems to store the
files as items. To get around this I cast them as zip files and then used java.util.zipfile classes and methods. The program stores a .tmp file in the
directory but I can tell that it has not been decompressed because it is the same size as the compressed file. I would appreciate any help or insight any one
may provide on this issue. Thank you in advance.

package org.nfis.ahpd.model;

import java.io.File;
import java.util.Iterator;
import java.util.List;

import javax.servlet.http.HttpServletRequest;
import javax.servlet.http.HttpServletResponse;

import org.apache.commons.fileupload.FileItem;
import org.apache.commons.fileupload.FileItemFactory;
import org.apache.commons.fileupload.disk.DiskFileItemFactory;
import org.apache.commons.fileupload.servlet.ServletFileUpload;

public class UploadFileProcess {
	
	
	public void processFile(HttpServletRequest request, HttpServletResponse response)
	{
		try {
	    	int maxMemorySize = 0;
			File tempDirectory = new File("C:/devel/eclipse 3.6.1/workspace/AHPD/appTempDir");
			//File tempDirectory = new File(request.get("appTempDir"));
			
	
			// Check that we have a file upload request
			boolean isMultipart = ServletFileUpload.isMultipartContent(request);
			
			// Create a factory for disk-based file items
			// Set factory constraints
			FileItemFactory factory = new DiskFileItemFactory(maxMemorySize, tempDirectory);
			
	
			// Create a new file upload handler
			ServletFileUpload upload = new ServletFileUpload(factory);
		
			// Parse the request
	        List items = upload.parseRequest(request);
	        
	    	// Process the uploaded items
			Iterator iter = items.iterator();
			FileItem item = (FileItem)iter.next();
			FormField formEntry = new FormField();
			ZippedFile zippedFile = new ZippedFile();
			
			while (iter.hasNext()) 
			{
			    if (item.isFormField()) {
			        formEntry.process(item);
			    } else {
			    	zippedFile.decompress(request, response, item);
			    }
			}
    	}catch(Exception e){e.printStackTrace();
		}
		
    }
}

package org.nfis.ahpd.model;

import java.io.BufferedInputStream;
import java.io.BufferedOutputStream;
import java.io.FileOutputStream;
import java.util.Enumeration;
import java.util.zip.ZipEntry;
import java.util.zip.ZipFile;

import javax.servlet.http.HttpServletRequest;
import javax.servlet.http.HttpServletResponse;

import org.apache.commons.fileupload.FileItem;

public class ZippedFile {

	public void decompress(HttpServletRequest request, HttpServletResponse response, FileItem item)
    {
    	
    	final int BUFFER = 2048;
    	try {
    		
    		BufferedOutputStream dest = null;
            BufferedInputStream is = null;
            
            ZipEntry entry;
            ZipFile zipFile = (ZipFile)item;
            Enumeration e = zipFile.entries();
            
            while(e.hasMoreElements()) 
            {
               entry = (ZipEntry)e.nextElement();
               
               System.out.println("Extracting: " + entry);
               
               is = new BufferedInputStream(zipFile.getInputStream(entry));
               
               int count;
               byte data[] = new byte[BUFFER];
               FileOutputStream fos = new FileOutputStream(entry.getName());
               dest = new BufferedOutputStream(fos, BUFFER);
               
               while ((count = is.read(data, 0, BUFFER)) != -1) 
               {
                  dest.write(data, 0, count);
               }
               dest.flush();
               dest.close();
               is.close();
               zipFile.close();
            }
	
    	}catch(Exception e){e.printStackTrace();
		}
    }
}

[Ulf Dittmer]

The trouble is, the library seems to store the files as items.

I don't quite follow - are you saying that the uploaded files are not byte-for-byte identical with the original files?

I can tell that it has not been decompressed because it is the same size as the compressed file.

If you upload a ZIP file, why would it get decompressed? That's not what FileUpload does.

[Awet Haddis]

Ulf Dittmer wrote:

The trouble is, the library seems to store the files as items.

I don't quite follow - are you saying that the uploaded files are not byte-for-byte identical with the original files?

I can tell that it has not been decompressed because it is the same size as the compressed file.

If you upload a ZIP file, why would it get decompressed? That's not what FileUpload does.

My class ZippedFile() takes in an 'item' (created by fileupload methods) and casts it as a 'zipfile'. In my method 'decompress' I attempt
to decompress the file. I don't think I was successful because it is byte-byte identical, meaning it was not decompressed.

[Ulf Dittmer]

Byte-for-byte identical seems unlikely - the output consist of multiple files, whereas the input is a single zip file, no?

If memory serves, it's possible to use ZIP as an archiver only, with no compression; make sure that's not what you have here.