Total newby JSP if block question is this legal

[Tony Evans]

If this block legal

in psdo code its

if(serverName = 'serverProd)
link = somethin1
else if(serverPort = 8080)
link = serverName:serverport
else
link = serverName

Thanks for any help

<%@ tag language="java" pageEncoding="ISO-8859-1"%>
<%@ taglib uri="/WEB-INF/tags/c.tld" prefix="c" %>

value link
	
<c:if test="${pageContext.request.serverName}"/>
<c:out value="${param.number}"/>
 <c:choose>
   <c:when test="${param.number=='serverProd'}">
	  link = "https://<c:out value="${pageContext.request.serverName}:${pageContext.request.serverPort}"/>"
    </c:when>
    <c:otherwise>
    <c:if test="${pageContext.request.serverPort}"/>
	<c:out value="${param.number}"/>
	<c:choose>
	<c:when test="${param.number=='8080'}">
	  link = "http://<c:out value="${pageContext.request.serverName}:${pageContext.request.serverPort}"/>"
    </c:when>
    <c:otherwise>
     link = "http://<c:out value="${pageContext.request.serverName}"/>"
    </c:otherwise>
    </c:choose>
    </c:otherwise>
    </c:choose>
    </c:if>

[Tony Evans]

sorry if blocks did not end right is this legal

<%@ tag language="java" pageEncoding="ISO-8859-1"%>
<%@ taglib uri="/WEB-INF/tags/c.tld" prefix="c" %>

value link
	
<c:if test="${pageContext.request.serverName}">
<c:out value="${param.number}"/>
 <c:choose>
   <c:when test="${param.number=='serverProd'}">
	  link = "https://<c:out value="${pageContext.request.serverName}"/>"
   </c:when>
   <c:otherwise>
    <c:if test="${pageContext.request.serverPort}">
	<c:out value="${param.number}"/>
	  <c:choose>
			<c:when test="${param.number=='8080'}">
	  			link = "http://<c:out value="${pageContext.request.serverName}:${pageContext.request.serverPort}"/>"
    		</c:when>
    		<c:otherwise>
     			link = "http://<c:out value="${pageContext.request.serverName}"/>"
    		</c:otherwise>
      </c:choose>
    </c:if>
   </c:otherwise>
  </c:choose>
 </c:if>

[Albareto McKenzie]

Almost, you have to do the set to the variable, you cannot declare things like "value link" in the middle of the page because that is only text (have you tried your example?) You have to set the value via <c:set tag

[Tony Evans]

Thanks link was only a placeholder I was more interested in getting the if then else block correct

<c:if test="${pageContext.request.serverName}">
<c:out value="${param.number}"/>
 <c:choose>
   <c:when test="${param.number=='serverProd'}">
	  <form action="https://<c:out value="${pageContext.request.serverName}"/>/user/login.do" method="post" focus="username" name="loginForm">
   </c:when>
   <c:otherwise>
    <c:if test="${pageContext.request.serverPort}">
	<c:out value="${param.number}"/>
	  <c:choose>
			<c:when test="${param.number=='8080'}">
	  			<form action="http://<c:out value="${pageContext.request.serverName}:${pageContext.request.serverPort}"/>/user/login.do" method="post" focus="username" name="loginForm">
    		</c:when>
    		<c:otherwise>
     			<form action="http://<c:out value="${pageContext.request.serverName}"/>/user/login.do" method="post" focus="username" name="loginForm">
    		</c:otherwise>
      </c:choose>
    </c:if>
   </c:otherwise>
  </c:choose>
 </c:if>

[Albareto McKenzie]

Well, actually you have a tag that doesn't end (<c:when test="${pageContext.request.serverPort}"> ) and a </c:otherwise> that doesn't close anything (line 19)

It's also a bit weird that param.number can have value serverProd or 8080, seems somehow strange.

For only two conditions I would use c:if instead of <c:choose, check this:

             <c:if test="${param.number=='8080'}">  
                 <form action="http://<c:out value="${pageContext.request.serverName}:${pageContext.request.serverPort}"/>/user/login.do" method="post" focus="username" name="loginForm">  
             </c:if>  
             <c:if test="${param.number!='8080'}">  
                 <form action="http://<c:out value="${pageContext.request.serverName}"/>/user/login.do" method="post" focus="username" name="loginForm">  
             </c:if>   

[Bear Bibeault]

Remember that you can have as many when's as you like.

[Tony Evans]

Cheers I got confused by an examples if you only doing one check when if you are doing a if/else blocl

<choose>
	<c:when test="${pageContext.request.serverName=='emea.blackrockcash.com'}">
  		<c:set var="args" value="https://${pageContext.request.serverName}"/>
	</c:when>
	<c:otherwise>
	  <c:when test="${pageContext.request.serverPort=='8080'}">
	  <c:set var="args" value="http://${pageContext.request.serverName}:${pageContext.request.serverPort}"/>
	  </c:when>
	  <c:otherwise>
	  <c:set var="args" value="http://${pageContext.request.serverName}"/>
	  </c:otherwise>
	</c:otherwise>
</choose>

<form action="<c:out value="${args}"/>/user/login.do" method="post" focus="username" name="loginForm">

[Bear Bibeault]

And remember that you can nest <c:choose> tags inside <c:when> tags.

[Tony Evans]

The finished working product, its a choose within a choose

<c:choose> <c:when test="${pageContext.request.serverName=='serverProd'}"> <c:set var="args" value="https://${pageContext.request.serverName}"/> </c:when> <c:otherwise> <c:choose> <c:when test="${pageContext.request.serverPort=='8080'}"> <c:set var="args" value="http://${pageContext.request.serverName}:${pageContext.request.serverPort}"/> </c:when> <c:otherwise> <c:set var="args" value="http://${pageContext.request.serverName}"/> </c:otherwise> </c:choose> </c:otherwise> </c:choose> <

[Sai Hegde]

Please post code within code blocks.