speed is increasing unexpectedly

[budsy remo]

hi , it's budsy again . I am having a strange problem .I have designed a game. In this game i am using a timer . This timer is associated with an actionlistener . Whenever you click on the ball the ball starts moving up till it hits the ceiling and starts moving towards the floor . Now no where in the code am i reducing the interval because of which the speed will increase but now the strange thing is that
whenever i click on the ball, it starts moving up(like it's supposed to) but the speed also increases . Can somebody explain why ?

import javax.swing.*;
import java.awt.event.*;
import java.awt.*;
import java.awt.geom.*;
public class AGame
{
	public static void main(String... args)
	{
		EventQueue.invokeLater(new Runnable()
		{
			public void run()
			{
				Wind w1=new Wind();
				w1.setVisible(true);
				w1.setDefaultCloseOperation(w1.EXIT_ON_CLOSE);	
			}
		});
	}
}
class Wind extends JFrame
{
	static JLabel l1;
	Wind()
	{
		setSize(500,700);
		setTitle("pop");
		setLayout(null);
		
		l1=new JLabel("0");
		l1.setBounds(300,300,100,100); 		

		JMove p1=new JMove();
		p1.setBounds(20,20,200,500);
		p1.setBackground(Color.red);
		p1.getSize();
		
		add(l1);
		add(p1);	
	}
}
class JMove extends JPanel
{	
	private int ycoord,speed;
	private double y=400,x=400;
	private Ellipse2D e1;
	private boolean flag=true;
	private boolean somevalue=true;
	private Timer t;
	JMove()
	{
		ycoord=getY();	
		addMouseListener(new MouseHandler());
		
	}
	public void paintComponent(Graphics g)
	{
		super.paintComponent(g);
		Graphics2D gd=(Graphics2D)g;
		e1=new Ellipse2D.Double(50,y,30,30);
		gd.draw(e1);
	}
	public Point2D find(Point2D p)
	{
		if(e1.contains(p))
		{
			return p;
		}
		return null;
	}
	public void drawAgain()
	{
		t=new Timer(1000,new Timely());
		t.start();
	}
	class Timely implements ActionListener
	{
		public void actionPerformed(ActionEvent e)
		{
			if(ycoord<e1.getY()&&flag)
			{
				y-=10;
				System.out.println("y decreasing");
			}
			else
			{
				System.out.println("y increasing");
				y=y+10;
				flag=false;
			}
			if(e1.getY()>=getHeight())
			{
				y=x;
				somevalue=false;
				//System.out.println("checkpoint");
				t.stop();
				//System.out.println("timer stopped");
				repaint();
			}
			if(somevalue)
			repaint();
		}	
	}
	class MouseHandler extends MouseAdapter
	{
		int score;
		public void mouseClicked(MouseEvent e)
		{
			Point2D p=null;
			somevalue=true;
			p=find(e.getPoint());
			if(p!=null)
			{
				flag=true;
				score++;
				t=new Timer(1000,new Timely());
				t.start();
				Wind.l1.setText(Integer.toString(score));
				System.out.println("mouse clicked");			
				//drawAgain();
			}
			else
			{
				if(t!=null)
				{
					System.out.println("stopped");
					//t.stop();
				}
			}	
		}
	}
}

[Darryl Burke]

In which method are you constructing a Timer?

What happens each time that method runs?

[budsy remo]

i am constructing the timer in the mouseClicked() method . Maybe that's the problem that the previous thread is never stopped ?
In that method Timer notifies the class that is implementing the actionlistener after some intervals and that class's actionPerformed checks the boundaries(Y coordinate)
and accordingly increases or decrease the value.

[budsy remo]

Maybe that's the problem that the previous thread is never stopped ?

thanks a lot the problem has been resolved ,turns out that was the problem but just another question , is timer a thread ?

[Darryl Burke]

another question , is timer a thread ?

The answer to that is in the API. Make a habit of reading the API for any unfamiliar class, it'll serve you well.