aspose file tools*
The moose likes Beginning Java and the fly likes Issues with if else statement Big Moose Saloon
  Search | Java FAQ | Recent Topics | Flagged Topics | Hot Topics | Zero Replies
Register / Login


Win a copy of Spring in Action this week in the Spring forum!
JavaRanch » Java Forums » Java » Beginning Java
Bookmark "Issues with if else statement" Watch "Issues with if else statement" New topic
Author

Issues with if else statement

Linda Selfridge
Greenhorn

Joined: Mar 26, 2011
Posts: 16
Hi!

I am very new to java programming and am trying to get an if else statement to work in relation to calculating taxation amounts.

Basically I need it to say: If salary is less than XXXX then tax = 0, otherwise if salary is greater than or equal to XXXXX then tax = (calculation), otherwise if salary is greater than or equal to XXXXX then tax = (calculation) etc

But at the moment it is only calculating on the first level of the calculation.

I really need help! My issue is between lines 38 & 47.


I hope someone can help!

Thanks in advance
Ernest Friedman-Hill
author and iconoclast
Marshal

Joined: Jul 08, 2003
Posts: 24187
    
  34

Hi,

Welcome to JavaRanch!

Well, one problem is that the tests are going to be executed in order, but they all overlap. For example, if projectedAnnual is 100,000, the program is first going to check if it's less than or equal to 6000, which it's not, but then it's going to check if it's greater than or equal to 6000, which it is, so that piece of code will be executed, and that's it -- no more "else" clauses will be considered, since one was already satisfied. You need to either re-order them, or turn the tests around to be "less than" rather than "greater than", so the smaller tests won't apply for the bigger numbers.


[Jess in Action][AskingGoodQuestions]
hypGnosis von Schwarz
Greenhorn

Joined: Oct 01, 2005
Posts: 2
Linda Hi!

First thing that caught my eye was:

What if 'projectedAnnual' equaled exactly 6000? Which 'if' stmt do you want to be followed? (<= 6000 or >= 6000)?

Since 'projectedAnnual' tops out at 150000, perhaps that should be the first amount tested, no?

With an ascending set of values, your code will never get to anything past the 'greater-than' 6000... cuz it's all greater than 6000, i.e., 25000 > 6000, 75000 > 6000, 150000 > 6000.

Flip the sequence & you'll be a happy camper!
Greg Brannon
Bartender

Joined: Oct 24, 2010
Posts: 561
You could accomplish what you're trying to do without them, but you could use multiple tests in your if statements. An advantage is that readability is improved, a disadvantage is that it's adding complexity, perhaps unnecessarily.

e.g.:



Always learning Java, currently using Eclipse on Fedora.
Linux user#: 501795
Linda Selfridge
Greenhorn

Joined: Mar 26, 2011
Posts: 16
You guys are legends!

I did what you said and flipped the statements around and it now calculated properly! YAY! YAY! YAY! I was up till 4am this morning trying to fix the issue!

I am forever in everyones debt!

For future reference the code now looks like this....



Thank you again!
hypGnosis von Schwarz
Greenhorn

Joined: Oct 01, 2005
Posts: 2
Linda, Hello again!

Hope you check back, because I have one additional comment.

You should remove the statement at line 50: if (projectedAnnual <= 6000)
and simply let the tax bracketing fall through to: yearTax = 0.00 ... the default tax amount

Besides that, what if the taxable amount is exactly 6000? It is referenced with equal signs in both lines 47 and 50.

Drop line 50 & you're on your way.
Linda Selfridge
Greenhorn

Joined: Mar 26, 2011
Posts: 16
Thanks I will give it a go.

Cheers
Igor Mechnikov
Ranch Hand

Joined: Feb 13, 2011
Posts: 100

Is it safe to assume that hoursWorked number is at least 38?


String knock = "\u042F \u0418\u0433\u043e\u0440\u044c";
Darryl Burke
Bartender

Joined: May 03, 2008
Posts: 4642
    
    5

Maybe that implies that you're also penalized at time-and-a-half if you don't wok a minimum of 38 hours

Good catch, Ilya!


luck, db
There are no new questions, but there may be new answers.
 
wood burning stoves
 
subject: Issues with if else statement