problem in my action class

hey i have prepared a project till 2 days before it was working properly but now its not entering the success page

i have to create a new project everytime with a new name then it starts

tell me what can be the problem

thank you

Can't help without any exception/error logs. Please post them.

thanks sagar for your prompt reply but there is no error

as soon as i click my submit button no success is there i remain on mu first page

thank you

Aditi agarwal wrote:as soon as i click my submit button no success is there i remain on mu first page

Have you confirmed that you specify the correct action path and that action is mapped to correct action class.
Also, paste the relevant code showing the FORM page and struts config file mapping for that action.

thak you sagar

actually it was working properly 2 days back before i introdue sessions & hashing Salting method

i think some problem over there

my userlogin.jsp is:-

<%@ page language="java" pageEncoding="ISO-8859-1"%>
<%@ taglib uri="http://struts.apache.org/tags-bean" prefix="bean"%> 
<%@ taglib uri="http://struts.apache.org/tags-html" prefix="html"%>
 
<html> 
	<head>
	<meta http-equiv="Content-Type" content="text/html; charset=UTF-8"> 
<meta http-equiv="expires" content="now"> 
<meta http-equiv="pragma" content="no-cache"> 
<meta http-equiv="Cache-Control" content="no-cache">

<%
		response.setHeader("Cache-Control","no-cache"); //HTTP 1.1
		response.setHeader("Pragma","no-cache"); //HTTP 1.0
		response.setDateHeader ("Expires", 0); //prevents caching at the proxy server
	%>
	<% 
	
    //session.invalidate();
	session = request.getSession(true);
	Integer salt = new Integer(ams.form.HashingsaltingForm.generateIntSalt()); 
	String address=request.getRemoteAddr();
	session.setAttribute("address",address);
    session.setAttribute("salt",salt);
    
%>

<title>JSP for UserLoginForm form</title>
				
		
	</head>
	<script type="text/javascript" language="JavaScript">
<!-- Copyright 2002 Bontrager Connection, LLC

function getCalendarDate()
{
   var months = new Array(13);
   months[0]  = "January";
   months[1]  = "February";
   months[2]  = "March";
   months[3]  = "April";
   months[4]  = "May";
   months[5]  = "June";
   months[6]  = "July";
   months[7]  = "August";
   months[8]  = "September";
   months[9]  = "October";
   months[10] = "November";
   months[11] = "December";
   var now         = new Date();
   var monthnumber = now.getMonth();
   var monthname   = months[monthnumber];
   var monthday    = now.getDate();
   var year        = now.getYear();
   if(year < 2000) { year = year + 1900; }
   var dateString = monthname +
                    ' ' +
                    monthday +
                    ', ' +
                    year;
   return dateString;
} // function getCalendarDate()

function show_now(){
var my_day=new Date()
//var dt = new Date(\"Aug 16, 2005 05:55:00\");

var day_name=new Array(7);
day_name[0]="Sunday"
day_name[1]="Monday"
day_name[2]="Tuesday"
day_name[3]="Wednesday"
day_name[4]="Thursday"
day_name[5]="Friday"
day_name[6]="Saturday"
return  day_name[my_day.getDay()];
}
//-->
</script>

<body style=" background-color:#FFFFCC;">
		<html:form action="/userLogin" method="post" onsubmit="return validateUserLoginForm(this);"> <table >
<tr>
	<td>	
		<img src="images/lion4.gif"/>
	</td>
		<th rowspan="2" align="center">
			<font size="5"  face="Georgia, Arial" color="maroon"><br>Ministry of

Petroleum &  Natural Gas </font> <br/>
 			  <font size="4" face="Georgia, Arial" color="maroon">O&M Activity Monitoring system</font>
		</th>
</tr>
<tr>
		<td>
		
<script type="text/javascript" language="JavaScript"></script>

</td></tr>
		</table>
		<br/><br/><br/><br/>
		<center>
		<table border="1"> 
			<tr><td>username  </td><td> <html:text property="username"/><html:errors property="username"/><br/></td></tr>
			<tr><td>password </td><td> <html:password property="password"/><html:errors property="password"/><br/></td></tr>
		<tr><td colspan="2" align="center"><html:submit/><html:cancel/></td></tr>
		</table>
		<br/><br/><br/><br/>
		<font size="2" align="center"  face="Georgia, Arial" color="maroon">Designed & Developed By NIC</font>
<img src="images/niclogo.gif"/>
		</center>
		
		</html:form>
		
				<html:javascript formName="userLoginForm"/>
		
	</body>
</html>

my userloginaction

/*
 * Generated by MyEclipse Struts
 * Template path: templates/java/JavaClass.vtl
 */
package ams.action;

import java.sql.Connection;
import java.sql.ResultSet;
import java.sql.SQLException;

import javax.servlet.http.HttpServletRequest;
import javax.servlet.http.HttpServletResponse;
import javax.servlet.http.HttpSession;

import org.apache.struts.action.Action;
import org.apache.struts.action.ActionForm;
import org.apache.struts.action.ActionForward;
import org.apache.struts.action.ActionMapping;

import ams.database.database;
import ams.form.HashingsaltingForm;
import ams.form.UserLoginForm;

/** 
 * MyEclipse Struts
 * Creation date: 03-29-2011
 * 
 * XDoclet definition:
 * @struts.action path="/userLogin" name="userLoginForm" input="/userLogin.jsp" scope="request" validate="true"
 * @struts.action-forward name="failure" path="/userLogin.jsp"
 * @struts.action-forward name="success" path="/userloginsuccess.jsp"
 */
public class UserLoginAction extends Action {
	/*
	 * Generated Methods
	 */

/** 
	 * Method execute
	 * @param mapping
	 * @param form
	 * @param request
	 * @param response
	 * @return ActionForward
	 */
	public ActionForward execute(ActionMapping mapping, ActionForm form,
			HttpServletRequest request, HttpServletResponse response) {
		UserLoginForm userLoginForm = (UserLoginForm) form;// TODO Auto-generated method stub
		String username=userLoginForm.getUsername().trim();
		String password=userLoginForm.getPassword().trim();
		
		HttpSession session1=request.getSession(false);
		int veryfy=((Integer) session1.getAttribute("salt")).intValue();
		if(veryfy!=userLoginForm.getSalt())
		return mapping.findForward("failure");
		Connection con=null;
		ams.database.database datasource= new database();
	        ResultSet rs=null;
	        java.sql.Statement st=null;
	   try
		{
			con=datasource.getConnection();
			st=con.createStatement();
		rs=st.executeQuery("select loginname,password from ams_login where loginname= '"+username+"'");
		while(rs.next())
			{
			String userName=rs.getString("loginname").trim();
			String passWord=rs.getString("password").trim();
	if((username.equals(userName))&&(password.trim().equalsIgnoreCase(HashingsaltingForm.md5EncryptedPassword(rs.getString("password").trim()
					+userLoginForm.getSalt()))))
			{
		return mapping.findForward("success");
			}
	else
			{
		return mapping.findForward("failure");
			}
			}
			}
	catch(Exception e){}
	finally {
	      // Always close the database connection.
	      try {
	        if (con != null) con.close();
	      }
	      catch (SQLException ignored){
	        System.out.println(ignored);
	      }
	    }
	return mapping.findForward("failure");
	}
}

now tell me what is the problem & wat should i do to remove that error

2 things I want to point out here, they may or may not solves the problem, but very important.

Aditi agarwal wrote:
<%
response.setHeader("Cache-Control","no-cache"); //HTTP 1.1
response.setHeader("Pragma","no-cache"); //HTTP 1.0
response.setDateHeader ("Expires", 0); //prevents caching at the proxy server
%>
<%

//session.invalidate();
session = request.getSession(true);
Integer salt = new Integer(ams.form.HashingsaltingForm.generateIntSalt());
String address=request.getRemoteAddr();
session.setAttribute("address",address);
session.setAttribute("salt",salt);

%> [/code]

Using Java code in JSP is very old and unhealthy practice. Avoid it completely.

Aditi agarwal wrote:
my userloginaction
[code=java]
catch(Exception e){}
[/code]

When I see such empty catch block, I get very furious.

Thats alos one problem why you didn't get any thing on console or in logs. Pl print the stack trace.

One question, is it production code ?, then beware of SQL injection in below code.

[code] rs=st.executeQuery("select loginname,password from ams_login where loginname= '"+username+"'"); [/code]

thanks for your reply sohan & i am sorry for the above mentioned mistakes

I will try that there are no empty catch blocks & also i would like to tell you that i need code in jsp but i will try to avoid it

but one question what i sthis production code i donot understand this.
& if any clue for my problem then please help me

thank you

Aditi agarwal wrote:thanks for your reply sohan &

sohan,

Thanks for the new name. Pl see my signature, 3rd column.

Aditi agarwal wrote:but one question what i sthis production code i donot understand this.

Production code means is that code goes into production server, or you are just trying some code for sake of practice.

Aditi agarwal wrote:& if any clue for my problem then please help me

Try following my advice #2, about try catch block.

I am so sorry sagar

but i think your try catch idea works

thanks

any one please reply i need it

Aditi agarwal wrote:any one please reply i need it

but you said in your previous reply that try.. catch block solves your problem ??

yes it worked for some time but agian that problem arises