javamail: method blocks instead of throwing exception

[Julien Martin]

Hello,

I have the following code in a Swing/Spring application:

 private void envoyerMail(final List<Sculpture> nouvellesSculptures, final Abonne abonne) {
        log.debug("envoyerMail");
        final ResourceBundle rb = ResourceBundle.getBundle("resources", new Locale(abonne.getAbonneLocale()));
        final Date aujourdhui = new Date();
        final int entierAleatoirePositif = Math.abs(new Random().nextInt());
        MimeMessagePreparator preparator = new MimeMessagePreparator() {

            @Override
            public void prepare(MimeMessage mimeMessage) throws MessagingException, IOException, VelocityException {
                MimeMessageHelper mMessage = new MimeMessageHelper(mimeMessage, "UTF-8");
                mMessage.setSentDate(aujourdhui);
                mMessage.setFrom("webmaster-" + entierAleatoirePositif + "@jeanbaptistemartin.com", rb.getString("artiste.titre"));
                mMessage.setReplyTo("[e-mail]");
                mMessage.setTo(abonne.getAbonneEmail());
                mMessage.setSubject(rb.getString("sujet.alerte.nouvellesSculptures"));
                Map model = new HashMap();
                model.put("abonne", abonne);
                model.put("nouvellesSculptures", nouvellesSculptures);
                model.put("dateTool", new DateTool());
                String text = VelocityEngineUtils.mergeTemplateIntoString(velocityEngine, "mailing-nouvelles-sculptures_" + abonne.getAbonneLocale() + ".ftl.htm", model);//todo i18n
                mMessage.setText(text, true);
            }
        };
        this.mailSender.send(preparator);
    }

When the email address I try and send the message to is erroneous i.e. julien@domain or [e-mail] the above method blocks indefinitely without throwing any exception...

Note that it runs within a SwingWorker.

Can anyone please help?

Thanks in advance,

Julien.

[Ramon Anger]

Hi Julien,

why not throw your own TimeoutException after x seconds?

Cheers,
Ramon

[Julien Martin]

Hello Ramon,
I altered my app as follows:

  @Override
    @Transactional(propagation = Propagation.REQUIRED, rollbackFor = RuntimeException.class)
    public boolean mailAbonne(List<Sculpture> sculpturesChoisiesPourMailing, Abonne abonne) {
        try {
            for (Sculpture sculpture : sculpturesChoisiesPourMailing) {
                MailingAbonnePK mapk = new MailingAbonnePK(sculpture.getSculptureID(), abonne.getAbonneID());
                MailingAbonne ma = new MailingAbonne(mapk, new Date());
                dao.persistMailingAbonnee(ma);
            }
            envoyerMail(sculpturesChoisiesPourMailing, abonne);
            return true;
        } catch (MailSendException e) {
            log.error("MailException");
            throw new RuntimeException();
        }
    }

Now I do rethrow a RuntimeException. However it still blocks and no rollback is performed...
Any other idea?
J.

[Ramon Anger]

Hi Julien,

I'm afraid this is not exactly what I meant. Please try the following:

1. Sending your mails has to happen in its own Thread.
2. In case your mail sending thread has successfully send the mail, you set a variable back in your main thread.
3. In your main thread you set a timer or something that realizes how many time has been spent.
4. After your time limit has been reached, you could check whether the mail sending thread set that variable yet (see 2.). If not, stop that thread and you could go on in your main thread.

BTW: Are you sure, that the mail connection you use to send that email, has no timeout parameter that can be set?

Cheers,
Ramon

[Julien Martin]

Good point Ramon.
First: I dropped the thread implementation: it now execute sequentially.
Second: upon your advice, I added this to my javamailsender bean:

<property name="javaMailProperties">
            <props>
                <prop key="mail.smtp.connectiontimeout">1000</prop>    
                <prop key="mail.smtp.timeout">1000</prop>    
            </props>    
</property>

I have the same behavior as before.
Julien.

[Ramon Anger]

Hi Julien,

a value of 1000 would mean timeout after 1 second.
Can you ensure that the properties you've set are known to your mail session at runtime?
There should be a Session.getProperties() method and/or Session.getProperty("mail.smtp.connectiontimeout") method.

If not set, mail.smtp.connectiontimeout and mail.smtp.timeout are both infinite and that's the behaviour your code shows ...

Cheers,
Ramon

[Julien Martin]

I checked that my JavaMailSenderImpl does have a getJavaMailProperties method and also that the values are in the mailSender's session.

mailSender.getJavaMailProperties()//ok

and

mailSender.getSession().getProperty("mail.smtp.timeout")//ok

However, it does seem those properties are ignored...
Regards,
Julien.

[Paul Clapham]

If you're trying to debug JavaMail, one of the recommended things to try is turning on debug mode, so you can see the conversation between your code and the server.

However you seem to be trying to debug JavaMail and Spring at the same time. I recommend putting Spring aside and debugging JavaMail by itself to start with, otherwise you don't know whether you are debugging JavaMail or Spring.