looping through an enum?

[Jon Camilleri]

Rather than hand-typing each of the following enums, is there some way to loop through each value and read its .ordinal() value?

@SuppressWarnings({ "unused", "null" })
	//TODO: write ranking rules
	private static ArrayList<Player> getWinner(ArrayList<Player> _players) {
		
		ArrayList<Player> _winners = null;
		_winners.addAll(_players);
		long _handRanking = 0;
		int _highCardPoints = 0; 
		long _totalScore = 0;
		boolean _rankingFound = false;
		
		/*TODO:	1. Player.setRanking(_ranking) for each of the players:
		Ranking 
		for hand # - highest ranking wins
		
		_highCardPoints = High-card ranking scores																Score
		Card.Rank.Suit.ACE																						+14
		Card.Rank.Suit.KING																						+13
		Card.Rank.Suit.QUEEN																					+12
		Card.Rank.Suit.JACK																						+11
		Card.Rank.Suit.TEN																						+10
		Card.Rank.Suit.NINE																						+9
		Card.Rank.Suit.EIGHT																					+8
		Card.Rank.Suit.SEVEN																					+7
		Card.Rank.Suit.SIX																						+6
		Card.Rank.Suit.FIVE																						+5
		Card.Rank.Suit.FOUR																						+4
		Card.Rank.Suit.THREE																					+3
		Card.Rank.Suit.TWO																						+2																																	

		_handRanking = Scores by hand ranking	
		----------------------																										
		1. 		Straight flush.  Five cards in sequence all of the same suit.									*1000000000
		2. 		Four of a kind.  Four cards of the same rank i.e. two pairs.									*100000000
		3.		Full house.		 Three cards of the same rank, and, a pair of cards with the same rank.			*10000000
		4.		Flush.			 Five cards of the same suit.													*1000000
		5.		Straight.		 Five cards in sequence, not necessarily of the same suit.						*100000
		6. 		Three of a kind. Three cards of the same rank.													*10000
		7.		Two pair.		Two pairs of cards, each having the same rank.  Higher ranks win.				*1000
		8.		One pair.		One pair of cards with the same rank.											*100
		9.      High card.		Cards in order of their rank. 													*10
		
		
		Higher cards get higher points.
		Further information at http://en.wikipedia.org/wiki/Poker_hands.
		*/
		
		/*TODO: If two or more players have equal high ranking, then players get to split the pot, hence, add both players to the winning
				ArrayList and return the ArrayList.
		*/
		
		for (Player _p : _players) {
			for (int i = 0; i < _players.size(); i++) {
			ArrayList<Card> _cardsAtHand = new ArrayList<Card>();
			_cardsAtHand = _players.get(i).getCardsHeld();
			/* TODO: code rankings... WIP
			 * if straight flush then it is not any other ranking...nested ifs 
			*/
			
			/* Straight flush */
			int _suitCount = 0;
			int _rankCount = 0;
			for (Card _card: _cardsAtHand) {
				
				switch (_card.getSuit()) {
						case CLUBS	:		_suitCount += Card.Suit.CLUBS.ordinal(); 		break;
						case DIAMONDS : 	_suitCount += Card.Suit.DIAMONDS.ordinal(); 	break;
						case HEARTS : 		_suitCount += Card.Suit.HEARTS.ordinal(); 		break;
						case SPADES :   	_suitCount += Card.Suit.SPADES.ordinal();		break;
						default :			break;
				}
				
				switch (_card.getRank()) {
					case ACE 	:	_rankCount += Card.Rank.ACE.ordinal();	break;
					case KING 	:	_rankCount += Card.Rank.KING.ordinal(); break;
					case QUEEN	:	_rankCount += Card.Rank.QUEEN.ordinal(); break;
					case JACK	:	_rankCount += Card.Rank.JACK.ordinal(); break;
					case TEN    :	_rankCount += Card.Rank.TEN.ordinal(); break;
					case NINE	:	_rankCount += Card.Rank.NINE.ordinal(); break;
					case EIGHT	:	_rankCount += Card.Rank.EIGHT.ordinal(); break;
					case SEVEN  : 	_rankCount += Card.Rank.SEVEN.ordinal(); break;
					case SIX 	:	_rankCount += Card.Rank.SIX.ordinal(); break;
					case FIVE	:	_rankCount += Card.Rank.FIVE.ordinal(); break;
					case FOUR	:	_rankCount += Card.Rank.FOUR.ordinal(); break;
					case THREE	:	_rankCount += Card.Rank.THREE.ordinal(); break;
					case TWO	:	_rankCount += Card.Rank.TWO.ordinal(); break;
				}
			}
			/* all hands must be from the same suit, hence, the total points must be the squares of the Card.Suit.<RANK>.ordinal() values */
			if (!(_suitCount == 0 || _suitCount == 5 || _suitCount == 10 || _suitCount == 15)) 
				_handRanking = 0;
			
			/* cards must have subsequent values */
			
			_totalScore = _highCardPoints * _handRanking;	
		}}
		
		//TODO: set winners...
		_winners.trimToSize();
		return _winners;
		}

[b]Card[/b]
package poker;

public class Card {

	public Card(Suit suit, Rank rank) {
        this.suit = suit;
        this.rank = rank;

    }
	public Card(short _suit, short _cardnumber)
	{
		switch (_suit) {
		case 1 :
			this.suit = Suit.CLUBS;
			break;
		case 2 :
			this.suit = Suit.DIAMONDS;
			break;
		case 3 :
			this.suit = Suit.HEARTS;
			break;
		case 4 :
			this.suit = Suit.SPADES;
			break;
		default :
			break;
		}

		//TODO: re-rank cards in order of card ranking in Card.java.
		switch (_cardnumber) {
		case 1 :
			this.rank = Rank.ACE;
			break;
		case 2 :
			this.rank = Rank.KING;
			break;
		case 3 :
			this.rank = Rank.QUEEN;
			break;
		case 4 :
			this.rank = Rank.JACK;
			break;
		case 5 :
			this.rank = Rank.TEN;
			break;
		case 6 :
			this.rank = Rank.NINE;
			break;
		case 7 :
			this.rank = Rank.EIGHT;
			break;
		case 8 :
			this.rank = Rank.SEVEN;
			break;
		case 9 :
			this.rank = Rank.SIX;
			break;
		case 10 :
			this.rank = Rank.FIVE;
			break;
		case 11 :
			this.rank = Rank.FOUR;
			break;
		case 12 :
			this.rank = Rank.THREE;
			break;
		case 13 :
			this.rank = Rank.TWO;
			break;
		default : break;
		}
	}

	@Override
    public String toString() {
        return rank.toString().toLowerCase() + " of " + suit.toString().toLowerCase();
    }
	
	@Override
	public int hashCode() {
		
		int _hash = 7;  
		_hash = _hash * 31 + suit.hashCode();  
		_hash = _hash * 31 + rank.hashCode();  
		return _hash;   
	}

	@Override
	public boolean equals (Object other) {
		if ((other == null) || (!(other instanceof Card))) return false;

		if (this == other) return true;
		
		if (getClass() != other.getClass()) return false;
		
		Card card = (Card) other;
		return  card.suit == this.suit &&
				card.rank == this.rank &&
				other.hashCode() == this.hashCode();	
	}

protected enum Suit {
        CLUBS("Clubs"), DIAMONDS("Diamonds"), HEARTS("Hearts"), SPADES("Spades");

        private String name;
        Suit(String name) { this.name = name; }
        public String getName() { return name; }
    }

    protected enum Rank {
    	ACE("Ace"), KING("King"), QUEEN("Queen"), JACK("Jack"), TEN("Ten"), 
    	NINE("Nine"), EIGHT("Eight"), SEVEN("Seven"), SIX("Six"), FIVE("Five"), 
    	FOUR("Four"), THREE("Three"), TWO("Two");

        private String name;
        Rank(String name) { this.name = name; }
        public String getName() { return name; }
    }

    public Suit getSuit() {
        return this.suit;}

    public Rank getRank() {
        return this.rank;
    }

    private Suit suit;
    private Rank rank;

}

[Wouter Oet]

Have you looked at the methods of an enum? Which of those could help to iterate through the values?

// Yes the hint is intentionally.

[Mike Simmons]

Errr, the method Jon needs isn't really listed under Enum, since it's a static method attached to each individual Enum subclass. Jon, you need to follow the link to JLS 8.9 where they talk about the valueOf() and values() methods.

[Jon Camilleri]

Mike Simmons wrote:Errr, the method Jon needs isn't really listed under Enum, since it's a static method attached to each individual Enum subclass. Jon, you need to follow the link to JLS 8.9 where they talk about the valueOf() and values() methods.

"ordinal

public final int ordinal()
Returns the ordinal of this enumeration constant (its position in its enum declaration, where the initial constant is assigned an ordinal of zero). Most programmers will have no use for this method. It is designed for use by sophisticated enum-based data structures, such as EnumSet and EnumMap.
Returns:
the ordinal of this enumeration constant"

Java 1.6 API at http://download.oracle.com/javase/6/docs/api.

[Jon Camilleri]

Wouter Oet wrote:Have you looked at the methods of an enum? Which of those could help to iterate through the values?

// Yes the hint is intentionally.

Excuse me?

[Mike Simmons]

Yes, Jon, your original post made it fairly clear you already know about the ordinal() method. But there is another method that you need, which will help address the problem you asked about, to avoid typing all those names. That's what I was pointing you towards.

[Mike Simmons]

Jon Camilleri wrote:

Wouter Oet wrote:Have you looked at the methods of an enum? Which of those could help to iterate through the values?

// Yes the hint is intentionally.

Excuse me?

I'm guessing the missing final word was "vague".

[Jon Camilleri]

Mike Simmons wrote:Yes, Jon, your original post made it fairly clear you already know about the ordinal() method. But there is another method that you need, which will help address the problem you asked about, to avoid typing all those names. That's what I was pointing you towards.

The syntax looks more gory, I'm not sure how to translate it to shorter code...

"valueOf

public static <T extends Enum<T>> T valueOf(Class<T> enumType,
String name)
Returns the enum constant of the specified enum type with the specified name. The name must match exactly an identifier used to declare an enum constant in this type. (Extraneous whitespace characters are not permitted.)
Parameters:
enumType - the Class object of the enum type from which to return a constant
name - the name of the constant to return
Returns:
the enum constant of the specified enum type with the specified name
Throws:
IllegalArgumentException - if the specified enum type has no constant with the specified name, or the specified class object does not represent an enum type
NullPointerException - if enumType or name is null
Since:
1.5"

http://download.oracle.com/javase/6/docs/api

[Mike Simmons]

Well, no, that wasn't it either. Keep reading. And is it really necessary to requote all this stuff here? I would think we're all able to follow links.

[Mike Simmons]

By the way, if someone could edit the first post in this thread to remove all those the extra useless spaces at the end of line 29 of the code block, it would do wonders for making this thread readable again. It didn't look this bad when first posted, so I don't know what happened. But that's why we're all having to use the horizontal scroll bars now.

[Jon Camilleri]

Mike Simmons wrote:By the way, if someone could edit the first post in this thread to remove all those the extra useless spaces at the end of line 29 of the code block, it would do wonders for making this thread readable again. It didn't look this bad when first posted, so I don't know what happened. But that's why we're all having to use the horizontal scroll bars now.

Sorry, if there's some spacing I can update let me know I didn't see anything out of place, I was just asking for an example..

System.out.println(Rank.valueOf("ACE"));

[Stephan van Hulst]

Jon, do you know how to use Javadoc?

Try making a Javadoc of your Suit or Rank classes. Then read the page, and see what methods are there.

[Wouter Oet]

Or read this page.