Can a MailSender participate in a transaction?

[Julien Martin]

Hello,
I would like for my mailAbonne method to be fully transactional. I noticed that even on a MailException being thrown the data is persisted by the dao (dao.persistMailingAbonnee(ma);). What's wrong with my configuration?
Can anyone please help?
Thanks in advance,
Julien.

  <bean id="mailSender" class="org.springframework.mail.javamail.JavaMailSenderImpl">
        <property name="host" value="${mail.server}"/>
        <property name="port" value="${mail.port}"/>
    </bean>

 <bean id="transactionManager" class="org.springframework.jdbc.datasource.DataSourceTransactionManager">
        <property name="dataSource" ref="dataSource"/>
    </bean>

    @Transactional(propagation = Propagation.REQUIRES_NEW, rollbackFor = {MailException.class})
    private boolean mailAbonne(List<Sculpture> sculpturesChoisiesPourMailing, Abonne abonne) {
        try {
            for (Sculpture sculpture : sculpturesChoisiesPourMailing) {
                MailingAbonnePK mapk = new MailingAbonnePK(sculpture.getSculptureID(), abonne.getAbonneID());
                MailingAbonne ma = new MailingAbonne(mapk, new Date());
                dao.persistMailingAbonnee(ma);
            }
            envoyerMail(sculpturesChoisiesPourMailing, abonne);
            return true;
        } catch (MailException e) {
            log.error("MailException");
            log.error(e);
            return false;
        }
    }

[Mark Spritzler]

Um, because you catch MailException, it will never throw MailException out of that method for the TransactionManager to roll it back.

If you catch it, you must re throw it if you want to release it out of the catch.

Mark

[Julien Martin]

Mark Spritzler wrote:Um, because you catch MailException, it will never throw MailException out of that method for the TransactionManager to roll it back.

If you catch it, you must re throw it if you want to release it out of the catch.

Mark

Good point! I should have spotted that. However when I remove the try/catch the exception is no longer thrown... Any idea why?
regards,
J.

[Julien Martin]

Hello Mark,
I changed my method to public as you advised. Here is how it looks now:

  @Transactional(propagation = Propagation.REQUIRES_NEW, rollbackFor = {MailException.class})
    public boolean mailAbonne(List<Sculpture> sculpturesChoisiesPourMailing, Abonne abonne) {
        try {
            for (Sculpture sculpture : sculpturesChoisiesPourMailing) {
                MailingAbonnePK mapk = new MailingAbonnePK(sculpture.getSculptureID(), abonne.getAbonneID());
                MailingAbonne ma = new MailingAbonne(mapk, new Date());
                dao.persistMailingAbonnee(ma);
            }
            envoyerMail(sculpturesChoisiesPourMailing, abonne);
            return true;
        } catch (MailException e) {
            //log.error("MailException");
            //log.error(e);
            throw new MailException("MailException", e) {
            };
        }
    }

I get the same behavior as before...
Any other idea?
J.

[Mark Spritzler]

Do you have a

<tx:annotation-driven/> tag in your configuration to tell Spring you are using the @Transactional annotations and therefore Spring will create a Proxy around your object to add Transactionlity to it?

Thanks

Mark

[Mark Spritzler]

OH, and that method is in your interface that that class implements?

Mark

[Julien Martin]

Mark Spritzler wrote:OH, and that method is in your interface that that class implements?

Mark

Yes it is indeed.

[Julien Martin]

Mark Spritzler wrote:Do you have a

<tx:annotation-driven/> tag in your configuration to tell Spring you are using the @Transactional annotations and therefore Spring will create a Proxy around your object to add Transactionlity to it?

Thanks

Mark

Yes it is too.

[Julien Martin]

The problem seems to be that the timeout is set to indefinitely on my mailsender although I tried to set it to 1 second as follows:
<bean id="mailSender" class="org.springframework.mail.javamail.JavaMailSenderImpl"> <property name="host" value="${mail.server}"/> <property name="port" value="${mail.port}"/> <property name="javaMailProperties"> <props> <prop key="mail.smtp.connectiontimeout">1000</prop> <prop key="mail.smtp.timeout">1000</prop> </props> </property> </bean>
and so the method hangs indefinitely. Hence the rollback is not performed...
Anyone any other idea how to sort this out?
Regards,
J.

[Julien Martin]

Sorry it does time out but the method still hangs indefinitely. Here is what the log says:

ERROR [18:13:24,990] (DesktopService.java:171) - org.springframework.mail.MailSendException: Mail server connection failed; nested exception is javax.mail.MessagingException: Could not connect to SMTP host: smtp.wanadoo.fr, port: 25;
nested exception is:
java.net.SocketTimeoutException: connect timed out. Failed messages: javax.mail.MessagingException: Could not connect to SMTP host: smtp.wanadoo.fr, port: 25;
nested exception is:
java.net.SocketTimeoutException: connect timed out; message exceptions (1) are:
Failed message 1: javax.mail.MessagingException: Could not connect to SMTP host: smtp.wanadoo.fr, port: 25;
nested exception is:
java.net.SocketTimeoutException: connect timed out

Why then won't it roll back the transaction??
Regards,
Julien.

[Mark Spritzler]

So it is throwing a MailSendException

But that isn't the Exception you are catching, unless MailSendException is a subclass of the Exception type that you are catching.

Mark

[Julien Martin]

Hi Mark,

I managed to isolate the problem. I now know it has nothing to do with the java mail api.

Here is my method:

@Transactional(propagation = Propagation.REQUIRED, rollbackFor = {RuntimeException.class})
    public boolean mailAbonne(List<Sculpture> sculpturesChoisiesPourMailing, Abonne abonne) {
        try {
            for (Sculpture sculpture : sculpturesChoisiesPourMailing) {
                MailingAbonnePK mapk = new MailingAbonnePK(sculpture.getSculptureID(), abonne.getAbonneID());
                MailingAbonne ma = new MailingAbonne(mapk, new Date());
                dao.persistMailingAbonnee(ma);
            }
            envoyerMail(sculpturesChoisiesPourMailing, abonne);//deliberately throws a RuntimeException
            return true;
        } catch (RuntimeException e) {
            log.error("Exception");
            log.error(e);
            throw new RuntimeException();//hangs here
        }
    }

I deliberately throw a RuntimeException from the envoyerMail method and it hangs where it is noted //here. I also know that Spring does create the beans properly and advises them propertly according to the @Transactional annotation because it says so in the logs. It is as if my method wouldn't manage to rethow the RuntimeException...
What could I be getting wrong?
Julien.

[Mark Spritzler]

Try

    @Transactional  
    public boolean mailAbonne(List<Sculpture> sculpturesChoisiesPourMailing, Abonne abonne) {  
        try {  
            for (Sculpture sculpture : sculpturesChoisiesPourMailing) {  
                MailingAbonnePK mapk = new MailingAbonnePK(sculpture.getSculptureID(), abonne.getAbonneID());  
                MailingAbonne ma = new MailingAbonne(mapk, new Date());  
                dao.persistMailingAbonnee(ma);  
            }  
            envoyerMail(sculpturesChoisiesPourMailing, abonne);//deliberately throws a RuntimeException  
            return true;  
        } catch (RuntimeException e) {  
            log.error("Exception");  
            log.error(e);  
            throw e;  
        }  
    }  

[Julien Martin]

Mark,
I tried as you advised. Same behaviour as before...

I don't know if that is relevant but here is how my method is called:

private DesktopServiceIF dService;

  ac = new ClassPathXmlApplicationContext("desktop-application-config.xml");
  dService = (DesktopServiceIF) ac.getBean("desktopService");

 private void jButtonLancerMailingActionPerformed(java.awt.event.ActionEvent evt) {                                                     
        this.jButtonLancerMailing.setEnabled(false);
        SwingWorker mailingWorker = new SwingWorker<Integer, Object>() {

            @Override
            protected Integer doInBackground() throws Exception {
                int nombreDeMailsEnvoyes = dService.traiterMailing();//traiterMailing is non transactional and in turn calls mailAbonne which is transactional
                jLabel_resultats_mailing.setText(nombreDeMailsEnvoyes + " mails envoyés");
                return nombreDeMailsEnvoyes;
            }

            @Override
            protected void done() {
                jButtonLancerMailing.setEnabled(true);
            }
        };

        mailingWorker.execute();

    }                                                    

Please let me know if the fact that my bean is called from a swingworker matters or not.

Regards,
Julien.