• Post Reply
  • Bookmark Topic Watch Topic
  • New Topic

confusion - unlock and delete

 
Makeshkumar Subramaniam
Greenhorn
Posts: 21
Chrome Eclipse IDE Java
  • Mark post as helpful
  • send pies
  • Quote
  • Report post to moderator
hi,
I've just started with this URLyBird assignment. I'm implementing methods

unlock(rec, cookie) throws RecordNotFoundException,SecurityException
and
delete(rec, cookie) throws RecordNotFoundException,SecurityException.

i wonder what if following scenario happens.

consider the following code:



as unlock() is throwing RecordNotFoundException, I'm checking if the given recNo is valid one (using record flag) before unlocking the record(removing this record entry from lock map).

my question is: since record 10 is already deleted. when the control reaches data.unlock(10,c), RecordNotFoundException would be thrown. is it okay ?? or should I change the code as to check record-valid after unlocking, i mean removing recordNo entry from lock map?.

thanks in advance.
 
Roel De Nijs
Sheriff
Posts: 10203
129
AngularJS Chrome Eclipse IDE Hibernate Java jQuery MySQL Database Spring Tomcat Server
  • Mark post as helpful
  • send pies
  • Quote
  • Report post to moderator
My unlock-method does not contain any check to see if recNo is valid, because that makes no sense. The RecordNotFoundException is only thrown by the lock (and find) method(s).
 
Roberto Perillo
Bartender
Posts: 2271
3
Eclipse IDE Java Spring
  • Mark post as helpful
  • send pies
  • Quote
  • Report post to moderator
Roel De Nijs wrote:My unlock-method does not contain any check to see if recNo is valid, because that makes no sense.


Agreed.

Makeshkumar, what you can do is verify if the record to be unlocked was locked (or, if it is in the structure that keeps the locked records - normally a Map<Long, Long>); if it wasn't, then you can throw IllegalStateException.
 
  • Post Reply
  • Bookmark Topic Watch Topic
  • New Topic