A Very little problem in h:dataTable implementation

[Adnan Gondal]

Hi all! I'm having a bean class employee having attributes id,name along with public getters and setters.

I'm using following bean for db connection and getting values from database table.

TableBean.java:

 
public class TableBean{
 public Connection getVConnection() throws Exception{
	  String driver = "oracle.jdbc.driver.OracleDriver";
	  String url = "jdbc:oracle:thin:@localhost:1521:globldb3";
	  String username = "scott";
	  String password = "tiger";
	  Class.forName(driver);
	  Connection conn = DriverManager.getConnection(url, username, password);
	  return conn;
	  }    
    private List<Employee> perInfoAll = new ArrayList(); 
        public List<Employee> getPerInfoAll() {
	int i = 0;
	Connection conn = null;
	PreparedStatement pstmt = null;
        try {
		conn = getVConnection();
	        String query = "select * from employee where e_id>5400";
	        pstmt = conn.prepareStatement(query);
                rs = pstmt.executeQuery();
	        while(rs.next()){
		   System.out.println(rs.getString(1));
                   perInfoAll.add(i,newEmployee(rs.getInt(1),rs.getString(2)));
                   i++;
	         }
	  }catch (Exception e){
	       e.printStackTrace();
	  }
	 return perInfoAll;
     }

Following is jsf page:

<h:dataTable value="#{TableBean.perInfoAll}" var="e">
<h:column>
    <f:facet name="header">Employee id</f:facet>
    #{e.id};
</h:column>

<h:column>
    <f:facet name="header">Employee name</f:facet>
    #{e.name};
</h:column>

Kindly reply.
Thanks in advance.

[Stefan Evans]

Actually I would say that your problem is in your data layer.

Question: What do you expect the ResultSet returned from this method to do?

Fun fact #1: You cannot access data in a result set that is closed
Fun fact #2: You close the results set in the finally statement of your method which returns the result set.

I suspect that might be the technical source of your problem.

In general, returning a ResultSet from a method is normally a bad idea.
The standard practice is to iterate of all the results in the result set, store them into a List of Beans, close the result set, and return the List of beans.