Solved : Java CheckBox to insert data

[Sander Silva]

Problem solved, Thank you very much for all who read and reply.

I'm using Netbeans 7.0 to develop a programme to Insert data into a MS Access database.

[Rob Spoor]

Welcome to the Ranch!

Could you next time please indent your code? It's almost impossible to read like this.

Sander Silva wrote:

public void insert1(int VID,String Name)
{
try{
s = DBConn.createStatement();
s.execute("insert into Main (VID,Name) values ("VID",'"Name"')");
}
catch (Exception e) {
System.out.println("Error: " + e);
}
}
public void insert2(int VID,String Color)
{
try{
s = DBConn.createStatement();
s.execute("insert into Col (VID,Color) values ("VID",'"Color"')");
}
catch (Exception e) {
System.out.println("Error: " + e);
}
}
 
public void insert3(int VID,String Color)
{
try{
s = DBConn.createStatement();
s.execute("insert into Col (VID,Color) values ("VID",'"Color"')");
}
catch (Exception e) {
System.out.println("Error: " + e);
}
}
 
public void insert4(int VID,String Color)
{
try{
s = DBConn.createStatement();
s.execute("insert into Col (VID,Color) values ("VID",'"Color"')");
}
catch (Exception e) {
System.out.println("Error: " + e);
}
}

1) There is no difference between insert2, insert3 and insert4. All that differs is the arguments when you call them. Make them into two methods, and rename them for clarity.
2) Those execute lines won't even compile; that's not how you concatenate Strings. You need + for that:

public void insertMain(int VID,String Name) {
    try {
        s = DBConn.createStatement();
        s.execute("insert into Main (VID,Name) values (" + VID + ",'" + Name + "')");
    }
    catch (Exception e) {
        System.out.println("Error: " + e);
    }
}

public void insertCol(int VID,String Color) {
    try {
        s = DBConn.createStatement();
        s.execute("insert into Col (VID,Color) values (" + VID + ",'" + Color + "')");
    }
    catch (Exception e) {
        System.out.println("Error: " + e);
    }
}

Of course, PreparedStatement is the preferred way because it prevents SQL injection (look it up if you don't know what that means).

My program is now able to add all 3 fileds via it's UI.
I have 3 colors in 3 checkboxes, now it is only capable of
adding only 1 color at a time. When I select more than 1 color (2 or3)
it's not working.

That's because you only call insert1 and insert2. You never call insert3 or insert4. You'll need to call four insert statements:

private void jButton1ActionPerformed(java.awt.event.ActionEvent evt) { 
    // TODO add your handling code here:

    Keytest d=new Keytest();

    int VID=Integer.parseInt(jTextField1.getText());
    String Name=jTextField2.getText();

    d.openDb();
    d.insertMain(VID,Name);
    
    if (jCheckBox1.isSelected()){
        String Color=String.valueOf(jCheckBox1.getText());
        d.insertCol(VID,Color);
    }
    if (jCheckBox2.isSelected()){
        String Color=String.valueOf(jCheckBox2.getText());
        d.insertCol(VID,Color);
    }
    if (jCheckBox3.isSelected()){
        String Color=String.valueOf(jCheckBox3.getText());
        d.insertCol(VID,Color);
    }
    d.closeDb();
} 

Thank you very much 4 reading my post. Hope som1 can give lil help.
Havanice day!

Please UseRealWords: "for" not "4"; "someone" not "som1". "little" not "lil". "Have a nice day" not "Havanice day".

[Sander Silva]

Oh woderful reply. 100% clear.
My problem is fully solved.
Thank you 1000 times!

[Darryl Burke]

Sander Silva wrote: Oh woderful reply. 100% clear.
My problem is fully solved.

I'm happy for you, but wouldn't you like to share your joy with the good folks over at the Oracle forums, so they don't waste time on your question?

Here too, we ask that you BeForthrightWhenCrossPostingToOtherSites

[Sander Silva]

Oh Sorry for wasting time on others. I delete all my posts @ other forums including Oracle forum.

[Campbell Ritchie]

Sander Silva wrote:. . .. I delete all my posts @ other forums including Oracle forum. . . .

No, don't delete any posts. It makes the replies look nonsensical. What you should do is post a link saying "somebody on JavaRanch helped me," or similar.